Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 15 Sep 2023 09:13:02 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Yu Liao <liaoyu15@huawei.com>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
        <ira.weiny@intel.com>, <rafael@kernel.org>
CC:     <liaoyu15@huawei.com>, <liwei391@huawei.com>, <lenb@kernel.org>,
        <robert.moore@intel.com>, <linux-acpi@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ACPI: NFIT: Fix incorrect calculation of idt size
Message-ID: <6504828ead258_3777b52948f@iweiny-mobl.notmuch>
References: <20230826071654.564372-1-liaoyu15@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230826071654.564372-1-liaoyu15@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V/g2LdUmBrSLkDXpSdFOlZhbh4s7zLRmhgUj7wY9QswAT26739nnCwYLK2pS?=
 =?us-ascii?Q?yRDw5UUyvftKTsPKWBYI2troB0U9IG75lR3gmvqOGM3ck33VrnnpYtOcrWxI?=
 =?us-ascii?Q?qwGTYhmYBE51ZNMQgB8TUlwOkUVE+UaahyDvR+0OG4IjSZhQXX0VoMxvvoI8?=
 =?us-ascii?Q?f8zqMcYLVj30x4LFs5TKcXCnP71aItbEHSBqdcO/C8S3fNl/chNuLmKmAsSs?=
 =?us-ascii?Q?OwsVMstli0t7VUGorx2rSZuyplS/j0GgbNKZzR+9UG7l8Jxbqn5sk34KGFGR?=
 =?us-ascii?Q?xWEocmnjzJ4BTIWXSVjtIbjdNS0GQ5ENP3Qk0FnkRYHsvaYJyJeEvaEvlEnP?=
 =?us-ascii?Q?gwP9uCoQgoMCGo38sXJIuwvVoiwhKN5LoYMOt40fBg0dur42CXHAWz6ne5Tp?=
 =?us-ascii?Q?QOkmqkr3NFlmhv7a3nILGH9Fh4RSTSB1k1JI0FKMwymxY7/kzXX/aRGW9D8K?=
 =?us-ascii?Q?pQ1Z297RbMCmyR7/cdoTVUIHd4saLOpzCajnqQ7Vm7PRlwW3i4tpIJ8A6+nW?=
 =?us-ascii?Q?scjGrHAPk595xQl22FUiSAEpIBazGHvFCSdtBmqRj9YaNyV6vZw0UELoR8L/?=
 =?us-ascii?Q?h5iVlW6q287PdqnWFRoVDjjLP8VO1f3seJZWxkfToY+vfUd9mSGBkrtOQcHU?=
 =?us-ascii?Q?XwMjvYKhh0uO7Wq3ygAt+NJOA4HH/wwIGxXr3gGMwNPma8BerjN/6VD+is+v?=
 =?us-ascii?Q?ApxYQ/zuRLH28ZqUbxY8mCGMxehvpe9+cKSOTdtSWDA9smK0IC+MJdAmM/v3?=
 =?us-ascii?Q?f1JHoF8x1G0oQVrHkpxnryASBIf/CIz/sRRw4QKEwler9QU4CwptjnPfRKWC?=
 =?us-ascii?Q?qMDyl7BCJFW3qDqLqJFuUoRgFx4eSwEIPsIWoY9oAhP1tMcMP6F8ZcfNfhOC?=
 =?us-ascii?Q?7xg1rZzWBXtUfFYQnujgQ1vse3oJvCz/c3nq1lnURufkBjOy+jmSOyIGcrf1?=
 =?us-ascii?Q?ShiFt/5kWjjG2qCBEGbyVHCk8aYU695EQhNbvhxME1dUAyvsdAJLVECmzrXu?=
 =?us-ascii?Q?QygxQFcCg4IU0o4eJqhd/T6tA+csGiIoH6HqHCNMtAG0k7wvi4KtOdcQ6JO3?=
 =?us-ascii?Q?qkCoVmINvjWFhshJWS4zo1qrb/IkDp1hExGqMXRyjeyjeUdO8GfOmobo61Gh?=
 =?us-ascii?Q?+zUISrUzDrdY/D1uS1oTZdc+XVTEUXuX1Mx2D+ibVzKuVtqSGT8/r1udoMnS?=
 =?us-ascii?Q?BNYFDgwKwKJgZMVJtsqaJp0DlSfhoL+ks/i40ZyaN/nktBGEuT+c+eGco/Fs?=
 =?us-ascii?Q?3BBaoWhILHpoFU0RUfGY7LgEbduTsTEYPz2qHJ7AGZM0Y5bmS7u8mGIJn4KS?=
 =?us-ascii?Q?ECtsuFDR8g8Y1NPE76ibn5iO/XWQkukQwCW+wc/HcFQgUGUkfmBh5LxvP5Vd?=
 =?us-ascii?Q?FvyYrYcUxcU8zbKsosb8vEitU+f7Vi+/idrYvWlr48y22Lzb8L2r61iWZi6b?=
 =?us-ascii?Q?vaZXLvLoxhGio10qP69wspncwJd0T0pot+OyKDPDeLT//IOav0dDzIDxOCBb?=
 =?us-ascii?Q?vm6qwaeE4E0WsBE1lFjjJ3ZTL9qoH2RxjsrLW0VIfztmQwZso7LcuE49327f?=
 =?us-ascii?Q?aQAu9OOtNyvUIRkgy1sEmSup6JHkLGc+mitphMBr?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3946f9ae-f24e-495e-aa54-08dbb606a4da
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 16:13:05.6879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m8GrUS//VekOKvBTv9BDeXhModk5b3y2fMV8oOpmpAzhM364G+tSmzf8QYfWwM7p/bcCwcEhsXd4BMnm/z3DzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4548
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 09:20:50 -0700 (PDT)

Yu Liao wrote:
> acpi_nfit_interleave's field 'line_offset' is switched to flexible array [1],
> but sizeof_idt() still calculates the size in the form of 1-element array.
> 
> Therefore, fix incorrect calculation in sizeof_idt().
> 
> [1] https://lore.kernel.org/lkml/2652195.BddDVKsqQX@kreacher/
> 
> Fixes: 2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace 1-element array with flexible array")
> Cc: stable@vger.kernel.org # v6.4+
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
> v1 -> v2: add Dave's review tag and cc nvdimm@lists.linux.dev
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 07204d482968..305f590c54a8 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -855,7 +855,7 @@ static size_t sizeof_idt(struct acpi_nfit_interleave *idt)
>  {
>  	if (idt->header.length < sizeof(*idt))
>  		return 0;
> -	return sizeof(*idt) + sizeof(u32) * (idt->line_count - 1);
> +	return sizeof(*idt) + sizeof(u32) * idt->line_count;
>  }
>  
>  static bool add_idt(struct acpi_nfit_desc *acpi_desc,
> -- 
> 2.25.1
>