Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4700606rdb; Fri, 15 Sep 2023 09:37:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzNw3uGvKYncs4u08kJeHV3Nf5bsuzh9/aA8yyIU9N7U/gEOui9RGu4dTQjH/LNs4ya81C X-Received: by 2002:a17:903:32c3:b0:1c3:f764:8428 with SMTP id i3-20020a17090332c300b001c3f7648428mr2718016plr.0.1694795832972; Fri, 15 Sep 2023 09:37:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694795832; cv=none; d=google.com; s=arc-20160816; b=xJ3AlydmYgmx+mglJlsaBFYLmLhT46VO3i8RzR3ot8T58e00KaprokS4NttnAPtZ6a gDdyYXTFk4k4WOQD/fGa1oH3S/an9uXyoODxjbEt+66XaHeNL1OunNjrdoHvCakZIDcI ZyTpCH3akeJdkxb2bfNWYimFFUupYztYDrC0cY6fdZXYv9DU+ctB3Moi71T5ZfjbfuMF Q42uj0GSjzgKYebBJJySCSwrMXrxjVcETj9NrtVMhPJsK1yJu0vHrLzf5YS3WM0dLLLu p87HZonRGN2vEuPGfCY544DJg3jyKGLGj9wvGCaR+jmJK1p9Cr69O9XK1ZUqesIIJXg8 Adcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=1yldzElETnKeG++jsfq4NDMKuUjbp7vxfG0LMRVCp+g=; fh=UufWz7cauOp0inZdl9iQ0uIfae4KkQHK/FSfbPiiJj8=; b=mRpoNEnKIddq0EYu7NVyUNTY84UkhgxnBnnn+w2lmXp0e44zhi5VyuC1Gw8BdcS59X Bdvr8ruwHNnVAq7AxlzIgrXC3l6TecWKYuDmHL7ObxNHbfSAnAfr/SnJiTPUVFTeXy6+ sB4HmnUfZQ86CM0dBFMR71SrIHgSM61wjwIxindHpajTALfH5hQ0FXKuGzvOwgz8OiWQ VrqqP8K8gSaaTsME5CE7s8EW3H4+n/blk18Y2AmWoWBTZMYWt7IpsDEjRMfDutvCOjfA YpkkdRFapZSbOpt7JQI/+gKlpNVRzwE6kc4ERfBCBm7B8diBMcl+LLLXWGSOAW+UsnuD AxKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gC4Y5GJ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id l9-20020a170903120900b001bc2c086880si3809450plh.306.2023.09.15.09.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 09:37:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gC4Y5GJ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 9FF6083A6C62; Fri, 15 Sep 2023 07:23:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235619AbjIOOW6 (ORCPT + 99 others); Fri, 15 Sep 2023 10:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235323AbjIOOW5 (ORCPT ); Fri, 15 Sep 2023 10:22:57 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D5951AC; Fri, 15 Sep 2023 07:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:From:Sender:Reply-To:Subject:Date: Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1yldzElETnKeG++jsfq4NDMKuUjbp7vxfG0LMRVCp+g=; b=gC4Y5GJ0aa3btSElsa7kth3hsR Imj4jo7cfSaCOxWwacFJtO0H3jCEEism5QMuYcKyRLmBb0oqzdZdMjyodqdEW9wgprGVJqA8kcsIR Yq7PcDp/9EmKpZsmluS23ulfsem7FOqamfTpw12+A3YghxYaLIUace+RMYWKE4F2qjpA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qh9iP-006YAD-9H; Fri, 15 Sep 2023 16:22:37 +0200 Date: Fri, 15 Sep 2023 16:22:37 +0200 From: Andrew Lunn To: Parthiban Veerasooran , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, corbet@lwn.net, steen.hegelund@microchip.com, rdunlap@infradead.org, horms@kernel.org, casper.casan@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, horatiu.vultur@microchip.com, Woojung.Huh@microchip.com, Nicolas.Ferre@microchip.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Alexandru Tachici Subject: Re: [RFC PATCH net-next 0/6] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Message-ID: References: <20230908142919.14849-1-Parthiban.Veerasooran@microchip.com> <20230915-wizard-junction-b58f2aad64c5@ifak-system.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915-wizard-junction-b58f2aad64c5@ifak-system.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 15 Sep 2023 07:23:00 -0700 (PDT) On Fri, Sep 15, 2023 at 03:56:59PM +0200, Alexander Dahl wrote: > Hello, > > this is interesting, by chance I just looked at a chip claiming > similar features today, which already has a driver in kernel: Analog > Devices ADIN1110. Ah, interesting. I had no idea this driver/device is an OA TC6 device. So ideally, we want the adin1110.c to also use the new framework, and remove the duplicate code. Parthiban, please look at the driver and make sure the APIs are such that Alexandru Tachici can swap his driver to using it. Having two implementations should help make it clear what is the same and what is different. Andrew