Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 15 Sep 2023 17:02:31 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Dean Luick <dean.luick@cornelisnetworks.com>
cc:     linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>,
        Lukas Wunner <lukas@wunner.de>,
        Alexandru Gagniuc <mr.nuke.me@gmail.com>,
        Krishna chaitanya chundru <quic_krichai@quicinc.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Alex Deucher <alexdeucher@gmail.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2 04/10] drm/IB/hfi1: Use RMW accessors for changing
 LNKCTL2
In-Reply-To: <c0e07dbf-e19e-43b7-9c95-8025a12323b8@cornelisnetworks.com>
Message-ID: <5ec088ff-c6fa-57af-117-c78376b9db31@linux.intel.com>
References: <20230915120142.32987-1-ilpo.jarvinen@linux.intel.com> <20230915120142.32987-5-ilpo.jarvinen@linux.intel.com> <c0e07dbf-e19e-43b7-9c95-8025a12323b8@cornelisnetworks.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1332323370-1694786558=:2347"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1332323370-1694786558=:2347
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 15 Sep 2023, Dean Luick wrote:
> On 9/15/2023 7:01 AM, Ilpo Järvinen wrote:
> > Don't assume that only the driver would be accessing LNKCTL2. In the
> > case of upstream (parent), the driver does not even own the device it's
> > changing the registers for.
> >
> > Use RMW capability accessors which do proper locking to avoid losing
> > concurrent updates to the register value. This change is also useful as
> > a cleanup.
> >
> > Suggested-by: Lukas Wunner <lukas@wunner.de>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> I believe the subject should begin with "RDMA/hfi1:", the current expectation for all devices in drivers/infiniband.

Thanks, I'll update it. I hadn't realized given the shortlogs of the other 
commits (no idea where I managed to get that "drm" from, but it's also 
gone now).

> > ---
> >  drivers/infiniband/hw/hfi1/pcie.c | 30 ++++++++----------------------
> >  1 file changed, 8 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
> > index 08732e1ac966..60a177f52eb5 100644
> > --- a/drivers/infiniband/hw/hfi1/pcie.c
> > +++ b/drivers/infiniband/hw/hfi1/pcie.c
> > @@ -1212,14 +1212,11 @@ int do_pcie_gen3_transition(struct hfi1_devdata *dd)
> >                   (u32)lnkctl2);
> >       /* only write to parent if target is not as high as ours */
> >       if ((lnkctl2 & PCI_EXP_LNKCTL2_TLS) < target_vector) {
> > -             lnkctl2 &= ~PCI_EXP_LNKCTL2_TLS;
> > -             lnkctl2 |= target_vector;
> > -             dd_dev_info(dd, "%s: ..new link control2: 0x%x\n", __func__,
> > -                         (u32)lnkctl2);
> > -             ret = pcie_capability_write_word(parent,
> > -                                              PCI_EXP_LNKCTL2, lnkctl2);
> > +             ret = pcie_capability_clear_and_set_word(parent, PCI_EXP_LNKCTL2,
> > +                                                      PCI_EXP_LNKCTL2_TLS,
> > +                                                      target_vector);
> >               if (ret) {
> > -                     dd_dev_err(dd, "Unable to write to PCI config\n");
> > +                     dd_dev_err(dd, "Unable to change PCI target speed\n");
> 
> To differentiate from the dev_err below, add "parent", i.e. "Unable to change parent PCI target speed".
> 
> 
> >                       return_error = 1;
> >                       goto done;
> >               }
> > @@ -1228,22 +1225,11 @@ int do_pcie_gen3_transition(struct hfi1_devdata *dd)
> >       }
> >
> >       dd_dev_info(dd, "%s: setting target link speed\n", __func__);
> > -     ret = pcie_capability_read_word(dd->pcidev, PCI_EXP_LNKCTL2, &lnkctl2);
> > +     ret = pcie_capability_clear_and_set_word(dd->pcidev, PCI_EXP_LNKCTL2,
> > +                                              PCI_EXP_LNKCTL2_TLS,
> > +                                              target_vector);
> >       if (ret) {
> > -             dd_dev_err(dd, "Unable to read from PCI config\n");
> > -             return_error = 1;
> > -             goto done;
> > -     }
> > -
> > -     dd_dev_info(dd, "%s: ..old link control2: 0x%x\n", __func__,
> > -                 (u32)lnkctl2);
> > -     lnkctl2 &= ~PCI_EXP_LNKCTL2_TLS;
> > -     lnkctl2 |= target_vector;
> > -     dd_dev_info(dd, "%s: ..new link control2: 0x%x\n", __func__,
> > -                 (u32)lnkctl2);
> > -     ret = pcie_capability_write_word(dd->pcidev, PCI_EXP_LNKCTL2, lnkctl2);
> > -     if (ret) {
> > -             dd_dev_err(dd, "Unable to write to PCI config\n");
> > +             dd_dev_err(dd, "Unable to change PCI target speed\n");
> 
> To differentiate from the dev_err above, add "device", i.e. "Unable to change device PCI target speed".

Okay, I'll change those. Thanks for taking a look.

-- 
 i.

--8323329-1332323370-1694786558=:2347--