Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Matyas, Daniel" <Daniel.Matyas@analog.com>
To:     Conor Dooley <conor@kernel.org>
CC:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH v3 2/5] dt-bindings: hwmon: Add possible new properties to
 max31827 bindings
Thread-Topic: [PATCH v3 2/5] dt-bindings: hwmon: Add possible new properties
 to max31827 bindings
Thread-Index: AQHZ5uGIjIOQar6MckC5UCinrmR7m7AaZXqAgAGe7UA=
Date:   Fri, 15 Sep 2023 15:31:13 +0000
Message-ID: <PH0PR03MB677168B3D2689B4D553443E089F6A@PH0PR03MB6771.namprd03.prod.outlook.com>
References: <20230914075948.208046-1-daniel.matyas@analog.com>
 <20230914075948.208046-2-daniel.matyas@analog.com>
 <20230914-qualify-ragweed-b06b7b7923c9@spud>
In-Reply-To: <20230914-qualify-ragweed-b06b7b7923c9@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ll8cR23h7fDOl5QA5/yZ/h1hmFXAvQ6ctq4jvi0WKUiAztfH9klBapmJGG9m?=
 =?us-ascii?Q?zfXwCNCUt7wv6YOeGk5iZDcFey+IL8cdAA9aYCrwtLVQBRCTIzDPI+3YO13H?=
 =?us-ascii?Q?w8vrFDUAHW8Ec4ijeatDE97zaIFS+k1v+Fxe5zViSp0arFAgPn0KOsb3R795?=
 =?us-ascii?Q?06ZSssHbGY6kgFx30ImQKU/p+nWOy1Fh6govhUReHPUyLu33NLWHpkFReC3A?=
 =?us-ascii?Q?DLZ5b/a0F/MX8Kaa9BuwLMl54xmAQmWRGK0fDIoU7ntLBpkFGpmwAO2UCRAe?=
 =?us-ascii?Q?uXXAn5CqhRa9gwrFk6vP6vk8Solv1wjj7yWJq1+z8OJ4wR2jqFOH0+NFau+h?=
 =?us-ascii?Q?YoJbHDUHfPnIOxUCWVSaIVoYHewWyJZFQAXpGpkA73hPfOBsLPJnqOK/++NQ?=
 =?us-ascii?Q?gsR+al0SE1S5KTgUfW34a1/Gy0mGCYNypi1lWc8LQNUsMXENY+bgPbSinyzQ?=
 =?us-ascii?Q?MCbrmuhDdtOdcQhWFn5FtFFklCkcMypagkvaK+rIqdhBbwS3flOf1rxB2b4+?=
 =?us-ascii?Q?2zNVep8lDEze1AnyzQW42xuC4u/gDXR/zo0ObEz28hBQS5y5XaUtCnS0yjHD?=
 =?us-ascii?Q?fQ9ZJBLq2b8jJJfE5vNqwI2NMcdGLuRGRwytQEaObBhsloFqV0O9OHw3dToI?=
 =?us-ascii?Q?gWLEypDH9bpBYwGHmDPcLtHZ9uG9uzbvUYIVxUJwNxYPUEies+hWIbS2RK6U?=
 =?us-ascii?Q?l3v85XIYITm9phrMbAFMbjTScBtFjBy3JXFRAo2765UWPM4vQEb1yfK8OV3x?=
 =?us-ascii?Q?J6QSPhEnghWBka+eq1I0qV1MwPffBsvmMJAngETSoRbfHT5JqhOYcS3zSsEW?=
 =?us-ascii?Q?FOiQth3jsQcftXMSF7WzWTFdPojcb7HCDCNER1gfykisLJjbiUoQk1BOJewi?=
 =?us-ascii?Q?gFXwxLqKDTiZis5pmKFVsFZ+0SZ94v3S890FDV9gdhMoiSUosTIv0Lf+Lv2R?=
 =?us-ascii?Q?c1fVroVYqgyVXEF+byiwB1NHSlGnHxmALArnuNZ/V/6/pnsud2Jd1tqvaEZO?=
 =?us-ascii?Q?0/qKYEaZbFKpJtOT10iaPjRPBvaT8oXcII2NK6GXC8xDnRh2PXoFLik+xqRd?=
 =?us-ascii?Q?F6yMz3JvQasqV1AJv9jWlEkphTWz4h+PO5vLGollHcTOMb2MwRbL8RydfySB?=
 =?us-ascii?Q?76kHcZ4sBnBhvI/bS8P7f2yLczweadwQAqRETAN1T7myFjIR6JnZXS4URF+H?=
 =?us-ascii?Q?7m8VTBZ6dmZPdUiKiMgP6oFH0OKmU2950EGGhjtiOMTdhgAzELC7ZYgS+iil?=
 =?us-ascii?Q?uS3s8WEZQu8Ao3pJQXA+AwuKxgzLTqykhMuVgIIkMO8lLttDI9Vauftvzc5L?=
 =?us-ascii?Q?Ot4btsWEYVhFWNzO66skj34zYNdCJnPZd47nu1Xiff+x1+J9xdm7ekLA7/1j?=
 =?us-ascii?Q?KA8XQk2CADJleUxTMfXD1J81iMIsY/XgsH6K9mr1bDNuzT5OPf1Rz2WerSBf?=
 =?us-ascii?Q?VrZrbrUQov8PJrd9El471YAJOAELVYeo+k1ywA8jufj7jcu+y+Uz5cVm2JhZ?=
 =?us-ascii?Q?N1s6N32e6qNERe5YE2RQWVCdGDtyQkCyks51Pt9tAOpx/gNTlfBJqQfx1Rnm?=
 =?us-ascii?Q?H6OSCzpT72p5C6vvGGjzbFlGkOtbXikwz9P54o6e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6771.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4678d8d-9f5d-4e88-2252-08dbb600cb72
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 15:31:13.2447
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: d0BIfqjC+k5sSZVAFxvh0Ut60F7op8Qq086AEb/oO1l1PIHB+9YFCCit9kNs6Bkn5JWO4OrFw4PiKrcmljRUl62w/xqEFFSErs59jZX0OjU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB7101
X-Proofpoint-ORIG-GUID: kj6RlJ20phUWQyhWC6MbLQkUQnGRHIY1
X-Proofpoint-GUID: kj6RlJ20phUWQyhWC6MbLQkUQnGRHIY1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-15_12,2023-09-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 priorityscore=1501 impostorscore=0 mlxlogscore=999 clxscore=1011
 lowpriorityscore=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0
 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2308100000 definitions=main-2309150138
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 15 Sep 2023 08:32:05 -0700 (PDT)


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Thursday, September 14, 2023 5:42 PM
> To: Matyas, Daniel <Daniel.Matyas@analog.com>
> Cc: Jean Delvare <jdelvare@suse.com>; Guenter Roeck <linux@roeck-
> us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; linux-
> hwmon@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v3 2/5] dt-bindings: hwmon: Add possible new
> properties to max31827 bindings
>=20
> [External]
>=20
> On Thu, Sep 14, 2023 at 10:59:45AM +0300, Daniel Matyas wrote:
> > These modify the corresponding bits in the configuration register.
> >
> > adi,comp-int is a hardware property, because it affects the behavior
> > of the interrupt signal and whatever it is connected to.
> >
> > adi,timeout-enable is a hardware property, because it affects i2c bus
> > operation.
> >
> > Signed-off-by: Daniel Matyas <daniel.matyas@analog.com>
> > ---
> >
> > v2 -> v3: Changed commit subject and message
> >
> > v1 -> v2: Added adi,timeout-enable property to binding. Fixed
> > dt_binding_check errors.
> >
> >  .../bindings/hwmon/adi,max31827.yaml          | 35
> +++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > index 2dc8b07b4d3b..6bde71bdb8dd 100644
> > --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> > @@ -32,6 +32,37 @@ properties:
> >        Must have values in the interval (1.6V; 3.6V) in order for the d=
evice
> to
> >        function correctly.
> >
> > +  adi,comp-int:
> > +    description:
> > +      If present interrupt mode is used. If not present comparator mod=
e
> is used
> > +      (default).
> > +    type: boolean
> > +
> > +  adi,alrm-pol:
>=20
> Characters are not at a premium, is there a reason not to use the full
> words? "flt-q" in particular would be quite cryptic if I saw it in a dts.
>=20
> > +    description:
> > +      Sets the alarms active state.
> > +            - 0 =3D active low
> > +            - 1 =3D active high
> > +      For max31827 and max31828 the default alarm polarity is low. For
> max31829
> > +      it is high.
>=20
> This constraint can be expressed in the binding, rather than in free form
> text like done here. Ditto below.
>=20
> Thanks,
> Conor.
>=20

Ok, but how? The default values are different depending on the compatible s=
tring. I searched for similar examples, but I found nothing...

Some bindings use 'default: ' to declare the default values, but this is th=
e default for every chip.

Kind regards,
Daniel

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum: [0, 1]
> > +
> > +  adi,flt-q:
> > +    description:
> > +      Select how many consecutive temperature faults must occur before
> > +      overtemperature or undertemperature faults are indicated in the
> > +      corresponding status bits.
> > +      For max31827 default fault queue is 1. For max31828 and
> max31829 it is 4.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum: [1, 2, 4, 8]
> > +
> > +  adi,timeout-enable:
> > +    description:
> > +      Enables timeout. Bus timeout resets the I2C-compatible interface
> when SCL
> > +      is low for more than 30ms (nominal).
> > +    type: boolean
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -49,6 +80,10 @@ examples:
> >              compatible =3D "adi,max31827";
> >              reg =3D <0x42>;
> >              vref-supply =3D <&reg_vdd>;
> > +            adi,comp-int;
> > +            adi,alrm-pol =3D <0>;
> > +            adi,flt-q =3D <1>;
> > +            adi,timeout-enable;
> >          };
> >      };
> >  ...
> > --
> > 2.34.1
> >