Date: Wed, 7 Nov 2007 17:39:39 +0000
From: Christoph Hellwig <hch@infradead.org>
To: "Yang, Bo" <Bo.Yang@lsi.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org,
       James.Bottomley@SteelEye.com, akpm@osdl.org,
       linux-kernel@vger.kernel.org
Subject: Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load
Message-ID: <20071107173939.GD25560@infradead.org>
References: <20071030173645.GA16455@infradead.org> <9738BCBE884FDB42801FAD8A7769C26501CA1BB0@NAMAIL1.ad.lsil.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9738BCBE884FDB42801FAD8A7769C26501CA1BB0@NAMAIL1.ad.lsil.com>
User-Agent: Mutt/1.4.2.3i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1289
Lines: 24

On Tue, Nov 06, 2007 at 12:04:31PM -0700, Yang, Bo wrote:
> I see that scsi_scan_host_selected is in scsi_priv.h and currently is
> not used by any other driver. The scsi_priv.h is not part of the include
> dir (/include/scsi). One of the major Linux distro's don't even include
> this file in /usr/src/kernels. Also it looks like at this time this
> function may not be available (not exported?) for driver modules to use.
> Even if I include scsi_priv.h I get "unknown symbol" for this function
> while loading.

Yes, it would have to be exported and moved to a public header.

> May be in the long run we can solve all these issues to call
> scsi_scan_host_selected. However, the current implementation works fine
> and has been tested by LSI and others. This implementation doesn't break
> any protocol nor does it adversely affect any driver functionality.

Your implementation adds state to scanning that could easily break and
makes the driver complex for things that don't belong into a driver,
so there's a clear NACK for this from me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/