Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <46816f54-72b3-efd0-c8d8-9778e4b3c4b3@intel.com>
Date:   Fri, 15 Sep 2023 10:12:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 01/10] platform/x86/intel/ifs: Store IFS generation number
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <20230913183348.1349409-2-jithu.joseph@intel.com>
 <e7f8136d-d07a-1668-2667-d2836c7112a@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <e7f8136d-d07a-1668-2667-d2836c7112a@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjVpRWhBdWtVWlIvZE1VbllwM2VEZ1dTUHRCMDdZeWxQY1JqVS9KTCtrUFEr?=
 =?utf-8?B?ZXlUMG5QUkVHMEF4VytFZGJzbm9IeTY4aiswTW5kUWVjTHlqaDJnV0RVd1p6?=
 =?utf-8?B?MkNGN253cmRVUkhHLzIrYmhiVk1maDdpVzRhMTdKS0w0OFVNakpMYW1PMDNa?=
 =?utf-8?B?d015bStNdmZ5c291RW5jOXQ4WXlTOEhVQWxMZE1HVWZZQ2x3Vm9Vd01RenNV?=
 =?utf-8?B?NHVZMXVJQ0JGbE81R0RQSVp5ZVN1NytQbnVHalB1V3A4OC9HdFo2UTE3cTMx?=
 =?utf-8?B?ZTFXaCszRHM2N0tiQWtXY25FcldaRVMyUFIrbm1OaUhGUDBTc0VtVVVxbXdH?=
 =?utf-8?B?M3BhY3lBWDdiM254QUs5YjdYNVJJekIyc1dkcjlONytVTm00VHE0alJKWkJl?=
 =?utf-8?B?eDVNcDhRRy85UjdmVlhaOTBLKzNGRjFJNXN2S1dQeS9wK0Zqd1VuQkwwWjFv?=
 =?utf-8?B?OWpSVTJIMmtvSWR1cDZZaDBZeVFOUWR3MGdjUDNreG52MFRZMm9HMEIxby9v?=
 =?utf-8?B?K0luNVdWWnhsTENWeW5BTGpIeGVnbGpkYXVmMHBUdDZLMWxOYTJtOFUzOVpm?=
 =?utf-8?B?ZFIvVDRwZFNlMHlITURCakZ5d0tpZVBsRU43eTVQQlJubTlPRmI2NzlGMnN5?=
 =?utf-8?B?MVJZOWVpQXpvLzdMdjRwMEhnUUkrbWx2M1c4OFlHbjE5V3A3Qm9xeTI2eGUz?=
 =?utf-8?B?b0NndzZCK2t6WSswT1MzNGlGRDZzM1ZTSFdFY0JZTXFCeXdVV0pHcnBkWUda?=
 =?utf-8?B?RnBkeXZSalNGVlVOR1hmMmoyT3NjQ3FEbDdVUGJiSjB4YWN3WmVrS2pUdXVp?=
 =?utf-8?B?Ym1YR1dyMXpRSUpFNzMrcnFQc3lRbnUvbUNyeDkxeFJmUjdhNE0yY2NOdWV2?=
 =?utf-8?B?cUF1NzRWRVlLQ2JPSWh6Um5HdTFpektud1pyVHBXWHpJNDJEdmowNVAyOVA2?=
 =?utf-8?B?N2JBeHhMVE1XNGF2N2p4ekdkcWI3bzUzWElDZ09vbitZb2ZNM1RIVFlzbGxm?=
 =?utf-8?B?ckx1UWF6eEpoOWNlcm1XZUpHWGQycWVMajFTdFlaelRXSk9CU0huUlRZV2ta?=
 =?utf-8?B?T0xCUDllOW1ISW4vQ1hGMFZFUERmUnpSYTMwcC9OdmlhcjNmR3IvQ29Cb2J1?=
 =?utf-8?B?UVJOVmhZVGZFYyswYkZEeTQwcDlzR09DZEFiQUtsSXRpSFNKaUFvdHhTQmhj?=
 =?utf-8?B?WjFUSjk3YjBOdVI3bEpiaHJwWndGR0NocHkzbThBQWRWNTU4d2NjSUlTU3hC?=
 =?utf-8?B?eVpVNHV2alM5QVI2Y3Q0bk1reDZMcGhtS09UKytnbU5ieW1Ga0FrcS94TGMv?=
 =?utf-8?B?U24vYThESkoyTXRVN1lPaW03NW5XZVJDSjhQWGJNVnU1UWxSRzNYMTF4NzUy?=
 =?utf-8?B?WS8yV3g5WkNPaHQ4RkJESzZNT3BEN0xGMklZWnVRZTczb0pVRHhwWHN3eHR3?=
 =?utf-8?B?TUV2WlorOS9JMlNvUnMyTVg5U0dDbEMrZ3JtUGtKaEI3UEl5VjFTamdZUW03?=
 =?utf-8?B?cE8zT20vMnZrZGhodFFTaWJxQ2NUZjBEK0FyNlo2UjN5UE9ETkRrdHJtWk0x?=
 =?utf-8?B?L2x4VERnMndIbXlTV01EVzU3Lzk4Y3JkU1dEME1qMEt5c2xGTXd4bForV3cw?=
 =?utf-8?B?a3NKdmtFbkVZbGlYN2dDcE9EQm9NLy93OURyNWNMaDNWSXkxOWdNcTlaWG9I?=
 =?utf-8?B?Z1RwSlk4OS8rcExEVlJ5eFd3aVMxd2R3VnVzWlJTTVdQMlFXK0xGNnJBRURR?=
 =?utf-8?B?UVhhc1ZYeG1YQVRuZzIxOVN1bTZ4VjdEeTlzcnFqL2puMklESm1JNWgvWGlZ?=
 =?utf-8?B?MDhDSlozTjFmY3RTZm1MMkJXRDFQL2VKTTdCZU5jWDFJRUh0UkdvUVZ2aGFw?=
 =?utf-8?B?SHkwdHdWRXlRb1VzZzhROHVBR0dIK2M0clVRSUxPSmMxVGtBSmdhUVBGejh6?=
 =?utf-8?B?eHJVMEUxc3BHRnFPdlB5em9tTEpxUmk4UEw1NlFVYk5LbmM0bUl5bHF3emtO?=
 =?utf-8?B?eW9lWGowN0YwdlZZTzREV3F5eW9telMyb09tS3B6NjdRY2QvLysrQ05HQVNM?=
 =?utf-8?B?TmFuSUcrL2FDM2d6Wmx4dzlEUFg0SjRrb3F2VU9RSnpWSmxKVGUzcFNFK2ox?=
 =?utf-8?B?Tm9XWXN0VkFoWTlxczVXTlZqLzlXdmVYeHUvNUpCdXNVNFJEcVUyZVkvbkor?=
 =?utf-8?B?Q3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c881e41a-d10a-41a9-a81e-08dbb60f0214
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 17:12:58.0413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4v9h3OzXEyq6C7ZDkI5H3Q7Vh1PtgE0chfb7DXjeWhQZ86j4NW47CrRzOYtbOCHHX7uQr6P04Bd59FUElU95sA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7153
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 15 Sep 2023 10:14:12 -0700 (PDT)

Appreciate the review

On 9/15/2023 9:22 AM, Ilpo Järvinen wrote:
> On Wed, 13 Sep 2023, Jithu Joseph wrote:
> 
>> IFS generation number is reported via MSR_INTEGRITY_CAPS.
> 
> Please use more characters per line, the limit is 72 characters.
> 

Noted
...


>> +#define MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT	9
>> +#define MSR_INTEGRITY_CAPS_SAF_GEN_REV_MASK	(0x3ull << MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT)
> 
> GENMASK_ULL(), don't add _SHIFT at all as FIELD_GET/PREP() will handle 
> it for you.

Thanks, Will change
...

>>  struct ifs_work {
>> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
>> index 306f886b52d2..88d84aad9334 100644
>> --- a/drivers/platform/x86/intel/ifs/core.c
>> +++ b/drivers/platform/x86/intel/ifs/core.c
>> @@ -94,6 +94,8 @@ static int __init ifs_init(void)
>>  	for (i = 0; i < IFS_NUMTESTS; i++) {
>>  		if (!(msrval & BIT(ifs_devices[i].test_caps->integrity_cap_bit)))
>>  			continue;
>> +		ifs_devices[i].rw_data.generation = (msrval & MSR_INTEGRITY_CAPS_SAF_GEN_REV_MASK)
>> +							>> MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT;
> 
> FIELD_GET(), don't forget to make sure use have the include for it.

Will change


Jithu