Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20230915065043.3401840-1-make_ruc2021@163.com>
In-Reply-To: <20230915065043.3401840-1-make_ruc2021@163.com>
From:   Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date:   Fri, 15 Sep 2023 11:05:00 +0200
Message-ID: <CAAEAJfANY07RE4Dw1LwDuCpv_qj_RQoLyXpLsC6r=rnfiN3QHw@mail.gmail.com>
Subject: Re: [PATCH] media: verisilicon: fix use after free bug in
 hantro_remove due to race condition
To:     Ma Ke <make_ruc2021@163.com>
Cc:     p.zabel@pengutronix.de, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ma,

This was already discussed:

https://patchwork.kernel.org/project/linux-media/patch/20230313154132.36841=
81-1-zyytlz.wz@163.com/

Thanks,
Ezequiel

On Fri, Sep 15, 2023 at 8:51=E2=80=AFAM Ma Ke <make_ruc2021@163.com> wrote:
>
> In hantro_probe, vpu->watchdog_work is bound with hantro_watchdog functio=
n. In
> hantro_end_prepare_run, it will started by schedule_delayed_work. If ther=
e is an
> unfinished work in hantro_remove, there may be a race condition and trigg=
er UAF
> bug.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/media/platform/verisilicon/hantro_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/me=
dia/platform/verisilicon/hantro_drv.c
> index 423fc85d79ee..1a5b3a85c520 100644
> --- a/drivers/media/platform/verisilicon/hantro_drv.c
> +++ b/drivers/media/platform/verisilicon/hantro_drv.c
> @@ -1187,6 +1187,7 @@ static void hantro_remove(struct platform_device *p=
dev)
>
>         v4l2_info(&vpu->v4l2_dev, "Removing %s\n", pdev->name);
>
> +       cancel_delayed_work_sync(&vpu->watchdog_work);
>         media_device_unregister(&vpu->mdev);
>         hantro_remove_dec_func(vpu);
>         hantro_remove_enc_func(vpu);
> --
> 2.37.2
>