Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230912090051.4014114-17-ardb@google.com> <ZQQiUxh5vmeZnp7s@gmail.com>
 <ZQRAckHVxQZRNEGA@gmail.com>
In-Reply-To: <ZQRAckHVxQZRNEGA@gmail.com>
From:   Ard Biesheuvel <ardb@google.com>
Date:   Fri, 15 Sep 2023 15:21:36 +0200
Message-ID: <CAGnOC3Zw49_30FkGY=RRLn-sCHNgFY_T0ugNJZCgg_T3opHm+Q@mail.gmail.com>
Subject: Re: [PATCH v2 00/15] x86/boot: Rework PE header generation
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ard Biesheuvel <ardb@kernel.org>,
        Evgeniy Baskov <baskov@ispras.ru>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Jones <pjones@redhat.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Kees Cook <keescook@chromium.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 15, 2023 at 1:31=E2=80=AFPM Ingo Molnar <mingo@kernel.org> wrot=
e:
>
>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
> > > Ard Biesheuvel (15):
> > >   x86/efi: Drop EFI stub .bss from .data section
> > >   x86/efi: Disregard setup header of loaded image
> > >   x86/efi: Drop alignment flags from PE section headers
> > >   x86/boot: Remove the 'bugger off' message
> > >   x86/boot: Omit compression buffer from PE/COFF image memory footpri=
nt
> > >   x86/boot: Drop redundant code setting the root device
> > >   x86/boot: Grab kernel_info offset from zoffset header directly
> > >   x86/boot: Drop references to startup_64
> >
> > I've applied these first 8 patches to tip:x86/boot with minor edits.

Thanks.

> > (Please preserve existing comment capitalization conventions ...)
> >

Ack

> > >   x86/boot: Set EFI handover offset directly in header asm
> > >   x86/boot: Define setup size in linker script
> > >   x86/boot: Derive file size from _edata symbol
> > >   x86/boot: Construct PE/COFF .text section from assembler
> > >   x86/boot: Drop PE/COFF .reloc section
> > >   x86/boot: Split off PE/COFF .data section
> > >   x86/boot: Increase section and file alignment to 4k/512
> >
> > The rest conflicted with recent upstream changes, and I suppose it's
> > prudent to test these changes bit by bit anyway.
>

Agreed. So you mean this conflicts with other stuff queued up in -tip
already, right?

> So, the first 8 patches broke the x86-64-defconfig-ish Qemu bzImage bootu=
p,
> due to the 8th patch:
>
>   988b52b207a9fe74c3699bda8c2256714926b94b is the first bad commit
>   commit 988b52b207a9fe74c3699bda8c2256714926b94b
>   Author: Ard Biesheuvel <ardb@kernel.org>
>   Date:   Tue Sep 12 09:01:01 2023 +0000
>
>       x86/boot: Define setup size in linker script
>
> I've removed it for now - but this side effect was not expected.
>

No, definitely not expected. I tested various combinations of i386 /
x86_64 built with GCC / Clang doing EFI or BIOS boot.

I'll rebase the remaining stuff onto -tip and see if I can reproduce this.