Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   "Romanowski, Rafal" <rafal.romanowski@intel.com>
To:     "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Catherine Sullivan <catherine.sullivan@intel.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>,
        Greg Rose <gregory.v.rose@intel.com>,
        "Eric Dumazet" <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net] i40e: Fix VF VLAN offloading when
 port VLAN is configured
Thread-Topic: [Intel-wired-lan] [PATCH net] i40e: Fix VF VLAN offloading when
 port VLAN is configured
Thread-Index: AQHZ4aKcjkLdlaYlbUOWPTquLsEBLbAPta4AgAvoEFA=
Date:   Fri, 15 Sep 2023 08:42:24 +0000
Message-ID: <BL0PR11MB35210D095CD20FD123F915FD8FF6A@BL0PR11MB3521.namprd11.prod.outlook.com>
References: <20230907154457.3861711-1-ivecera@redhat.com>
 <26c81971-70eb-ed0d-749f-6d910ad786f8@intel.com>
In-Reply-To: <26c81971-70eb-ed0d-749f-6d910ad786f8@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N9zKeh9+aOaT/XspDcMG4IYujxA4lVibX0SrUc72Tcb1jS5QN0ZWFd74+TqE?=
 =?us-ascii?Q?oA/oADqGJsPv1vFj0DLNJs7kg1v1lm2dt/w7byJP1G9aqF2aoodsNMZcA5mh?=
 =?us-ascii?Q?NYfFDPBlY+lYIDk7ZKmRQBamA8XjPUSYsQbJ/qaTNzpVOKrhARmKdUyClw3c?=
 =?us-ascii?Q?a52V1Ur+YT0FlU+iVZStBVz6+p5FxLDGgsIBwqQIsWjoE5GeTeI+3LVMl0I9?=
 =?us-ascii?Q?aMDtA9IgJ/tKuBKC9KCBiwjHX2yxGE/C3FdSbJvJ1ydOyA8CRCl2kNjqVua8?=
 =?us-ascii?Q?nzu20PIsZx7v83XnK0mavBP8anufFiud8bOQ2Pui2K9+v6suftxaghVcRFVq?=
 =?us-ascii?Q?VcSes+0YVKSCp0YiBPOrF/cvvEIbCuCIGqXG87eNA+tgjdD0Fb2uhCsLu6GD?=
 =?us-ascii?Q?yde9az4Iu1wK54WlI76lKe5m5dG+wNFdJ6ZrMEwItOjxPbVMob0eqOtguwD9?=
 =?us-ascii?Q?TKxDt3DNZoOyvpUB5Is4LrMgO6ENHuVbYSwjGkUuXpu3zGcVc1tWF2fpJsVz?=
 =?us-ascii?Q?Y9un+mW0yjq5IMcXRjPKCpq0Qc6+mee6D07fy8vD8WV8sr2q90O6vBkytv/j?=
 =?us-ascii?Q?lnCxna9ioR3bX9NsQz8rn8rdj0JTo+M3/Irjivdxb1tP0xQrdodZFUJCNHax?=
 =?us-ascii?Q?jCb4CVZ7qhXmMwJCWIhDeyhq+lB3zbbY5Wc7RKlCQiBaDVZo3+tAWIEnfx4p?=
 =?us-ascii?Q?h0sIlr+DSigzeXjXSQRFGpzKrRqLm1VQ2ygYmZZh07mC1hO2VzG/2pl0/bCK?=
 =?us-ascii?Q?sw03UrYmzhfTVuLgqVuRJ7Gq0L4jORJfGDrIymFXnilysNOhZyRkMf+4gIeG?=
 =?us-ascii?Q?QKe84mmZJ81e6WFJu/hqYGtF/I8OUKkNieNVtYTph4Jb9b3KsrW2q8PQYhHM?=
 =?us-ascii?Q?pHkfOkUG/BydF99KBKU5J9nC1KGk/TTIS44Wtvb6hKfVNfmouwZN/Ah9J6b8?=
 =?us-ascii?Q?yCMIWp3vpOui+sDENR9ck8Gx3yuYhejY0rnz0p3t5NA9pMW7u8ceEhoc8/sA?=
 =?us-ascii?Q?qDk4KKKHphGR9Y4Pjxfsoj6qjCq4qsa3Bpx4Oo/3TmNBq1xSABTtb1AAJeJZ?=
 =?us-ascii?Q?SzOgNnWoGd5v/3uXxySwkgzO2beEd7bdOroRphHZ6D6W+R6UJtMydFD5vpeg?=
 =?us-ascii?Q?GElYgLcEjHtCttN1fEJ6GyV7rPwkXTYXdPd+J9r5uBWCcAUfN3OoxVCgmEUK?=
 =?us-ascii?Q?K38LrSQxXsPSmJbwRbbd8PVYoTbOqoXa1QQwtm7CCGebUh/MrJFCnB/Pre18?=
 =?us-ascii?Q?UreOssD+7BUfzB0xYf0jKdtHdVWeNtGusV2R0ZEj9jaR1KteyrFkn2ih7bg9?=
 =?us-ascii?Q?eUo/gWa635kNuXKnr3wGNn/LlzsJBJ0Bm5tn/U4GJCBdOKaKzxXJ4BHFCVe/?=
 =?us-ascii?Q?oNm2rtXaWyFffEyaKFXT1/c/3tpmtIwzj5AABtieAigQ/GSKXFKrTjt3Xv0Y?=
 =?us-ascii?Q?yxAl1uWF/JqjwjMylD2g+B6OWqCesIdqtzxWX1iBlgwFKu2dFZ12o90iNO7E?=
 =?us-ascii?Q?6PPUqpFf9tevk14lxbGN41XmLLOfJ1MTEC8FrURcqDhpSZfUiwskdK6FeNnI?=
 =?us-ascii?Q?KFIoSrKEKbDU2Beo5LObltxM84E/F4ZFbBtofgoH6DX7MsN1YtGefAq6cDow?=
 =?us-ascii?Q?ig=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3521.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01ba1ffc-9efd-4b8d-a1b7-08dbb5c7af37
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 08:42:24.5572
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fjh31JVRodLhRQIFv1kg0pnNluab2k85XTn/VNixlwL579hAg2rqXvJGJ0spRfaWunGTBlVpEga8OmrYqeJ656HiklaZXNEm19TbIeoZ0GU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6941
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 15 Sep 2023 01:42:34 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Thursday, September 7, 2023 8:53 PM
> To: ivecera <ivecera@redhat.com>; netdev@vger.kernel.org
> Cc: Catherine Sullivan <catherine.sullivan@intel.com>; moderated list:INT=
EL
> ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>; open list <linux-
> kernel@vger.kernel.org>; Greg Rose <gregory.v.rose@intel.com>; Eric Dumaz=
et
> <edumazet@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Jeff Kirsher <jeffrey.t.kirsher@intel.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David
> S. Miller <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Fix VF VLAN offloading w=
hen
> port VLAN is configured
>=20
> On 9/7/2023 8:44 AM, Ivan Vecera wrote:
> > If port VLAN is configured on a VF then any other VLANs on top of this
> > VF are broken.
> >
> > During i40e_ndo_set_vf_port_vlan() call the i40e driver reset the VF
> > and iavf driver asks PF (using VIRTCHNL_OP_GET_VF_RESOURCES) for VF
> > capabilities but this reset occurs too early, prior setting of
> > vf->info.pvid field and because this field can be zero during
> > i40e_vc_get_vf_resources_msg() then VIRTCHNL_VF_OFFLOAD_VLAN
> capability is reported to iavf driver.
> >
> > This is wrong because iavf driver should not report VLAN offloading
> > capability when port VLAN is configured as i40e does not support QinQ
> > offloading.
> >
> > Fix the issue by moving VF reset after setting of vf->port_vlan_id
> > field.
> >
> > Without this patch:
> > $ echo 1 > /sys/class/net/enp2s0f0/device/sriov_numvfs
> > $ ip link set enp2s0f0 vf 0 vlan 3
> > $ ip link set enp2s0f0v0 up
> > $ ip link add link enp2s0f0v0 name vlan4 type vlan id 4 $ ip link set
> > vlan4 up ...
> > $ ethtool -k enp2s0f0v0 | grep vlan-offload
> > rx-vlan-offload: on
> > tx-vlan-offload: on
> > $ dmesg -l err | grep iavf
> > [1292500.742914] iavf 0000:02:02.0: Failed to add VLAN filter, error
> > IAVF_ERR_INVALID_QP_ID
> >
> > With this patch:
> > $ echo 1 > /sys/class/net/enp2s0f0/device/sriov_numvfs
> > $ ip link set enp2s0f0 vf 0 vlan 3
> > $ ip link set enp2s0f0v0 up
> > $ ip link add link enp2s0f0v0 name vlan4 type vlan id 4 $ ip link set
> > vlan4 up ...
> > $ ethtool -k enp2s0f0v0 | grep vlan-offload
> > rx-vlan-offload: off [requested on]
> > tx-vlan-offload: off [requested on]
> > $ dmesg -l err | grep iavf
> >
> > Fixes: f9b4b6278d51ff ("i40e: Reset the VF upon conflicting VLAN
> > configuration")
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>=20
> Change looks reasonable to me and since it fixes your reproducer above, t=
hen
> excellent! Thank you!
>=20
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>=20
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>