Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 13 Sep 2023 13:36:30 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Jiri Slaby <jirislaby@kernel.org>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tty/serial: Sort drivers in makefile
In-Reply-To: <e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org>
Message-ID: <e25ef4f-48bb-eeff-f181-794afe716a81@linux.intel.com>
References: <20230912103558.20123-1-ilpo.jarvinen@linux.intel.com> <e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-11916867-1694601394=:1849"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-11916867-1694601394=:1849
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 13 Sep 2023, Jiri Slaby wrote:

> On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> > Sort drivers in alphabetic order in Makefile to make it easier to find
> > the correct line. In case the CONFIG and filenames disagree, sort using
> > the filename (but ignoring "serial" prefixes).
> 
> Overall looks good.
> 
> I just want to make sure you considered the below, as you don't say explicitly
> in the commit log.
> 
> The order in the makefile defines the link order. So built-in drivers are
> loaded in that order. So are you sure your patch doesn't change order of some
> drivers which need to be in a specific order?

Thanks for taking a look.

I limited the ordering to non-library like "leaf" driver files so it 
should be safe. Except for 8250_early that was in middle of drivers so
I moved it before the driver section but that doesn't alter anything 
important AFAICT.

In any case, I double-checked this again and only thing I found out is 
that for some reason SERIAL_8250_EXAR depends on 8250_PCI but nothing uses 
the 4 functions 8250_pci.c EXPORTs (which I'll address shortly).


-- 
 i.

--8323329-11916867-1694601394=:1849--