Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4830689rdb; Fri, 15 Sep 2023 13:46:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8+G/k7+SJ4GaB+3k0yVKOXI0L5Bctsjc8Pohx8oKkX/GvwNc5IcogFmtLLyfBwPFQvcEP X-Received: by 2002:a17:90a:fb92:b0:26b:66f7:c9be with SMTP id cp18-20020a17090afb9200b0026b66f7c9bemr2647668pjb.10.1694810770554; Fri, 15 Sep 2023 13:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694810770; cv=none; d=google.com; s=arc-20160816; b=s3DyOoC5tUvYMrT4kmuqK0FBjIRODwG9A2hrSuHo+LFDzd32SK7jcBAyGb/8rVw1zT p1Hf9mjm4Usb2+fv3UCOQ4PGgwgqc6/cpRH4bB3zNAMDHxiNHM1c+taaON8oBybATXiW rPx7jfBjdFpNQsRNtMKVcxQrn7j/TjXA+NLdnZahQybTR6rvF0fVmbcM3hRbT0OhlwNB ZT6DbITRBqLUZx2t1ypjolNJK6z33ddXv2vB9WWQ4f1gS/uWbdcmIwET1wVahXKyTdnn 1umhBKFKevFVgZILf5dgKETZ4+N6edM7fwLUoIU2niMShcQQ2mPD5QhuTImGerK5GX2s tZ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=4ZS93HQjg+3yZppe9BDFA0lNQehCr7DbnGsXiOwc2hY=; fh=s4OKqumzB/EA7Wlo6l6N/EI1/DaboBh5MrEtNeNZamY=; b=NGb0AIiS8Ys1FwYaD5HhLcmYCld7LKs7w/Q3yT2s0PQV8WeJF1uFrG1KCdVv8zaGlm v41p0v3uCxioHsjAAFJs/ZiM+0/btnG4UQMW4+Uei6xwFwvU5zaZif2GGFuR6Rumh+wW zTDZT+ZaV3tEpjTWKs/OyPrWqMTz6Wlo7ZXWu+M1/1HeIr7T3bcV+8yXaC2G/VgGHR8d QyjGhAW9bhyow8zLYvsvrlf6+4JLhsEdNpqhazX5ySUpLfjtjN6kp9K6ICJU5kTHebid HJ7miApYy9W/DQgqf4ulGo+HSMidlnG7IkpTKYGHDFkuY80nFO3cYT7nkDpiKyAiq9b5 xGYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XzuUR6ic; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id e5-20020a17090a804500b002681dc4472esi5881547pjw.134.2023.09.15.13.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:46:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XzuUR6ic; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 73CB980A2383; Fri, 15 Sep 2023 09:38:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234803AbjIOQhs (ORCPT + 99 others); Fri, 15 Sep 2023 12:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235238AbjIOQhi (ORCPT ); Fri, 15 Sep 2023 12:37:38 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4922DE69; Fri, 15 Sep 2023 09:37:29 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1c26bb27feeso1353113fac.0; Fri, 15 Sep 2023 09:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694795848; x=1695400648; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4ZS93HQjg+3yZppe9BDFA0lNQehCr7DbnGsXiOwc2hY=; b=XzuUR6ic1iTpnVyIqBe5Oug9uCU+VKzlS0itXz01AuNbO8UycyWVePNcpOURbFnrTW LdVGnWppV7s8bVlDqDZcqeZ7aBdRN5YOiniI9mud/Az38wRvu2m+E+C/l0Ttlvx8HaDk s4qZr5Z12UuFERNE2kMwnP9aY1qT+++zU4xDcyUGxtXurfX2IHusR689OONNltdde4ev FaADrnEnt7M3Y3DXyM0yyt4gdGUD+h8nHEQm4D1uGxe7i7DRoirbmN9ah1Nmcw+qmHXf lB25ffdqEQCYPFFnK3y4r0F8/jJKK0QKSXoNARD7cFkEuWGkdwO3q6k8twyi8070cufy hgjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694795848; x=1695400648; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ZS93HQjg+3yZppe9BDFA0lNQehCr7DbnGsXiOwc2hY=; b=Qk+sM/6LAVmbOvKOP4Bjt4oGFU9cWIUMdk8RkbEYQFEYyAn6laZqGdghZoOEPCgzC+ rbAH7ZBtxC3VH0j++3NXXVGvtGTEEKNON7/DLzxSYRGseRbIk6u1uUqYPSjx/1lkWmF3 jKHHkHZHPwins1Qey4cYqtQrSsLuQDrRoK4utYqqNjJcgSPNVjs86Cokl0ONhHY95R0Y GA+Xpcf/UA+Wa+X+NavPSlMYGg9Cc1rppxO0pZnbixxP5GbX8WZCeUX9Dj5hwfFT4GAo ZIQ1g1t3Zy0eWsCGOL4AnWN/FNIATtF6sQi7edpU7OAA1B1UKxqBi878U56UgOU+1BMT NfxA== X-Gm-Message-State: AOJu0YwvIjAZsUMPI/ciGr1K+9NQzzRgegG2rj5YxwCgOnxRkleQEGNX Q57EBLuuuc1BDsW7qc538Qw= X-Received: by 2002:a05:6870:e9a4:b0:1bf:8c9a:9a2c with SMTP id r36-20020a056870e9a400b001bf8c9a9a2cmr2238684oao.15.1694795848361; Fri, 15 Sep 2023 09:37:28 -0700 (PDT) Received: from [10.67.51.148] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id m10-20020ac866ca000000b004055d45e420sm1265339qtp.56.2023.09.15.09.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 09:37:27 -0700 (PDT) Message-ID: <86f42ef5-096c-7eaf-9273-feea82947eef@gmail.com> Date: Fri, 15 Sep 2023 09:37:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH net-next 1/2] net: dsa: microchip: Move *_port_setup code to dsa_switch_ops::port_setup() Content-Language: en-US To: Oleksij Rempel , "David S. Miller" , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , "Russell King (Oracle)" Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Petr Machata , Lukasz Majewski References: <20230914131145.23336-1-o.rempel@pengutronix.de> From: Florian Fainelli In-Reply-To: <20230914131145.23336-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 15 Sep 2023 09:38:17 -0700 (PDT) On 9/14/23 06:11, Oleksij Rempel wrote: > Right now, the *_port_setup code is in dsa_switch_ops::port_enable(), > which is not the best place for it. This patch moves it to a more > suitable place, dsa_switch_ops::port_setup(), to match the function's > purpose and name. > > This patch is a preparation for coming ACL support patch. > > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian