Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758615AbXKGS2x (ORCPT ); Wed, 7 Nov 2007 13:28:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753262AbXKGS2n (ORCPT ); Wed, 7 Nov 2007 13:28:43 -0500 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:42131 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757896AbXKGS2m (ORCPT ); Wed, 7 Nov 2007 13:28:42 -0500 Date: Wed, 7 Nov 2007 10:28:40 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: akpm@linux-foundatin.org cc: Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman Subject: Re: [patch 04/23] dentries: Extract common code to remove dentry from lru In-Reply-To: <20071107085027.GA6243@cataract> Message-ID: References: <20071107011130.382244340@sgi.com> <20071107011227.298491275@sgi.com> <20071107085027.GA6243@cataract> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 46 On Wed, 7 Nov 2007, Johannes Weiner wrote: > Hi Christoph, > > On Tue, Nov 06, 2007 at 05:11:34PM -0800, Christoph Lameter wrote: > > @@ -613,11 +606,7 @@ static void shrink_dcache_for_umount_sub > > spin_lock(&dcache_lock); > > list_for_each_entry(loop, &dentry->d_subdirs, > > d_u.d_child) { > > - if (!list_empty(&loop->d_lru)) { > > - dentry_stat.nr_unused--; > > - list_del_init(&loop->d_lru); > > - } > > - > > + dentry_lru_remove(dentry); > > Shouldn't this be dentry_lru_remove(loop)? Correct. Andrew: This needs to go into your tree to fix the patch that is already there: [PATCH] dcache: use the correct variable. We need to use "loop" instead of "dentry" Signed-off-by: Christoph Lameter Index: linux-2.6/fs/dcache.c =================================================================== --- linux-2.6.orig/fs/dcache.c 2007-11-07 10:26:20.000000000 -0800 +++ linux-2.6/fs/dcache.c 2007-11-07 10:26:27.000000000 -0800 @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub spin_lock(&dcache_lock); list_for_each_entry(loop, &dentry->d_subdirs, d_u.d_child) { - dentry_lru_remove(dentry); + dentry_lru_remove(loop); __d_drop(loop); cond_resched_lock(&dcache_lock); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/