Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4840791rdb; Fri, 15 Sep 2023 14:06:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOFfFOArxhRtXcca9Is96ClCxuSQWhrfs5AwxAlSkdgptHNB6LurkIo5QTHKWbm68ts34p X-Received: by 2002:a17:903:11cf:b0:1c4:fae:bf28 with SMTP id q15-20020a17090311cf00b001c40faebf28mr2874443plh.32.1694812016653; Fri, 15 Sep 2023 14:06:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694812016; cv=none; d=google.com; s=arc-20160816; b=EUth58kf1VQU+J1Uz3+DyYMe2jsSWbGVawNTuKNgdXuYLMjvZ848YM+rOidPNxH1r5 h2WJxYg41Lra+79+uewwsh24VjOh6QwIrhk4TM4cY02FV/55m+3snwbrYbG34HAt7Ckc 4BHYotMPF8NCmJ6/izKHROFHqwY60vf2VJtwJacs5D6WJVGEHe1uUaP2pQxZOwB1Y64y UXHTYlRmxsjOjlCXQdXFvud2qgv/bh8gXZyfoEv4rA+wfHV+88W/K9zCkIX9PmMz7TqM kfvPNtbn+VixUv5XR3msSJ5Jjth5ntlSyptYJBeimp23dTr8Py9MnEZ2Hby5i+y/HV2I JMtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0azTSzwIO5wB3GjrjXO4srn8WzFckAJ3B02EBtBBaAM=; fh=W11qpygqhVl+bKjrif44rQ6UzYM3D5CrbTfnG3zvQNY=; b=hruWDt16ukCnrj7Gp3fIr/t/3oJ7dmD3HTea35Cn/u020guFOD2ZEv1GxMU//4NMJb XdQmbhOrFl06IF2lrAZWfYeZv8Dhoh5uh6ojulqZkkJSNPCBO4r4pd42HlhMXhBTH+/e x3pvfg1JEAHLS4s42r1SCoANo02vNR4LQObtSePFSkPM5ElfPMc4nq7MutRF/2BtsE2o a9w2Ccp+BLK+FPyJInrsR6h1Igm0HsnZxMPXVbFOZ1rysgO09seC8TUlzBPcjOYUa5jZ eu+slKK+s3+blkWH27z/o/oyrfWwyxfmx+bz37ev9NQ3pTm+RJyxUzouKcg7a1BXOnCL KMCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="C9/rSjco"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a7-20020a170902900700b001c3e500e6d4si3807384plp.344.2023.09.15.14.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 14:06:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="C9/rSjco"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 663DE8088A40; Fri, 15 Sep 2023 12:44:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237009AbjIOToI (ORCPT + 99 others); Fri, 15 Sep 2023 15:44:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237024AbjIOTnh (ORCPT ); Fri, 15 Sep 2023 15:43:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EEA21FC9; Fri, 15 Sep 2023 12:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0azTSzwIO5wB3GjrjXO4srn8WzFckAJ3B02EBtBBaAM=; b=C9/rSjcoPUh83yvuYT6V9HdPDk 6NZtX7sEyAlPQ+xzU2EUKDtgrkAYfJ/sDrJ0RRW3Hl7HCLdA/HGZcClVAs+2MrrcwQgSIVqPsqbHn kMypNEs/d22C3W1VJp9oSnmdUwXQ8l52qTb4no+CrXXKt4CqRj9uN4IrJ+ku5dsLYxilzy+t6bBtX hqcksK4ufOtltzXJepTD3NjIOc0KzbxzYmJPJbxJ5eL9HdOBJLGbnNPOzBgFHbz2G9OS7wRmuRSbs D/gBMKLBS1PjL4GRTudevFiq5/W0OkDwgT26S7PaRIZGwQsSKKHmm4A6MWvjR/4qz2uC+9zgoMDDP ZS85RvVA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhEiu-00Bfub-Ib; Fri, 15 Sep 2023 19:43:28 +0000 Date: Fri, 15 Sep 2023 20:43:28 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 04/23] filemap: set the order of the index in page_cache_delete_batch() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-5-kernel@pankajraghav.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 12:44:42 -0700 (PDT) On Fri, Sep 15, 2023 at 08:38:29PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Similar to page_cache_delete(), call xas_set_order for non-hugetlb pages > while deleting an entry from the page cache. Is this necessary? As I read xas_store(), if you're storing NULL, it will wipe out all sibling entries. Was this based on "oops, no, it doesn't" or "here is a gratuitous difference, change it"?