Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759383AbXKGSey (ORCPT ); Wed, 7 Nov 2007 13:34:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753578AbXKGSep (ORCPT ); Wed, 7 Nov 2007 13:34:45 -0500 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:59705 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752151AbXKGSeo (ORCPT ); Wed, 7 Nov 2007 13:34:44 -0500 Date: Wed, 7 Nov 2007 10:34:42 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Johannes Weiner cc: akpm@linux-foundatin.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman Subject: Re: [patch 12/23] SLUB: Trigger defragmentation from memory reclaim In-Reply-To: <20071107092822.GC6243@cataract> Message-ID: References: <20071107011130.382244340@sgi.com> <20071107011229.423714790@sgi.com> <20071107092822.GC6243@cataract> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 32 On Wed, 7 Nov 2007, Johannes Weiner wrote: > > @@ -210,6 +218,8 @@ unsigned long shrink_slab(unsigned long > > shrinker->nr += total_scan; > > } > > up_read(&shrinker_rwsem); > > + if (gfp_mask & __GFP_FS) > > + kmem_cache_defrag(zone ? zone_to_nid(zone) : -1); > > return ret; > > } > > What about the objects that kmem_cache_defrag() releases? Shouldn't > they be counted too? > > ret += kmem_cache_defrag(...) > > Or am I overseeing something here? kmem_cache_defrag returns the number of pages that were released by defrag actions. shrink_slab returns the number of objects released by the shrinkers. kmem_cache_defrag has no way of knowing how many objects where released by the kick methods. The kick method may have chosen to reallocate the object. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/