Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <dae23faf-577a-182d-537a-70acb9e0dcfa@intel.com>
Date:   Fri, 15 Sep 2023 13:13:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 10/10] platform/x86/intel/ifs: ARRAY BIST for Sierra
 Forest
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <20230913183348.1349409-11-jithu.joseph@intel.com>
 <cabbda89-f89f-aa75-d661-c8d5f6cc5d93@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <cabbda89-f89f-aa75-d661-c8d5f6cc5d93@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUtTZGloeTdlSXlNTWQ2U2NEaDB5ZVV3Q05HRVF4dW5ZanVBV3NrZTJWL01x?=
 =?utf-8?B?SG5sMDJSY1lXWUc3cmp2VERVZTJreG8rSG5pNlRGbEZLNmpvZVlMQklRTURh?=
 =?utf-8?B?TXRRNzNOUHpsN091aVErNzVXVXVSbXhKRDNDTTVkaGJ1L1pVYUJoK3lIMWo3?=
 =?utf-8?B?UU9PMGJ4NmhLT1pvcnJBQzZTeCszWSttK3RYdG5zZlk1N1plK2N3TEJpQnBz?=
 =?utf-8?B?cXB1QUg3TkdwVUNwN1hsL2t5QnNvdGF1Z2JKYzgzNlBEbzl6ZWVQWUJxQkxN?=
 =?utf-8?B?bWthZU5CaEk4dnhBU3NXcVZsZGJVbGxGUmI1ZzhoVWdzMWI2dXQ4VFlteTdZ?=
 =?utf-8?B?aTdoU0FwblY4OTYrRWdDS1E2NU5ZaWlRUG0wbFZ3SEN5NElmVlIrYVh2MWRJ?=
 =?utf-8?B?UlJMZjk4MjUwM1hhUlNGWGlJb3R1QzNjekM5L3dvRUpGQnJoeTY3cExhZnRl?=
 =?utf-8?B?MTl1VWVqbFRrUjV5VlU1eWZaQk4vV0JjQUJSUElOeDVJZkJIYTlUQUV3NXJ2?=
 =?utf-8?B?aTcrYXcydWlOdFZsdlZ2YnpLYTUxZnFjaGVjd2IrbzEzTktYYkdoMmw4d2Ey?=
 =?utf-8?B?aGdPMnpPK0xqbHJKTFVuVVdMdC9LU2R0YVRCK1hSR3ZyOTE0Tk5sTTQ5L0h4?=
 =?utf-8?B?a2NJU2tuWW1YODBLdk00aDBtcEU0dzBLdVd2WWFjVG53SDNFRCtISWtCdElJ?=
 =?utf-8?B?N2Y5WDd3TUhBeHRtVTVJeUJHd09LUTZwYTg1SGZjT1c0N2FDK0RSQmF5Q1Vu?=
 =?utf-8?B?VlJheTZyYkxDdFkyVTM0dkoydzBBemZrZGhTeC82T3ppcVRwWUYvc3B1WFhi?=
 =?utf-8?B?S1Zyb3NSM2ZSWWR0UWw5Uk5oT2JTOEZLN2lnTnpyRzFyM04zRUhyWGFESy9M?=
 =?utf-8?B?Q2lQMWh4RkdXTVlnZ21PT0FPL2JlV2dMdFZnR1QrMzUvTWNkL1ltbDAyc1VK?=
 =?utf-8?B?cWVWYitMb1FDOXIrZ1JSN0d0dHF4aEVaY1Urd1d2SVZWSy9adHAvb0tEYnl4?=
 =?utf-8?B?Y0FBRzVxK09jazIwMXJWWFpHZ1EyOHZIYzhGUkVGZjdQOTk3MDk5Vm9USzJ1?=
 =?utf-8?B?MGdXaEpNaHZUSlpZaDJpZnZNTXlCMDcwYzFYUkJBejhnV0pNakU2MzlqcXN2?=
 =?utf-8?B?WDVES2w1d2w1dXlTV0tEbUJVTmlReHlQcS9TN2JWdU5NNERQcWxmbHVJZ01T?=
 =?utf-8?B?Y0o3KzlMcDFlU3JUWVNSSFF1N1BVUjVHbko2ZjM2a0FMSklCb2J5OTV1RlNH?=
 =?utf-8?B?RXY0NGtUTGw3NldrMjQ3dTJkT3R3U3puZWgxaEdnaXMvTlQrYjUycXJQa2ty?=
 =?utf-8?B?bmtycFVlQXlJZlZwQldnYmdCUy83cU1rMVlaYUNNOXphK20zR1o0QXNpNm85?=
 =?utf-8?B?NnBrQkZvOExDQzJrcXNEU2dwWUpWdHZMRHNKeHJMQXRVeVdvUE5VQVdrbGwx?=
 =?utf-8?B?NUhFY01jVU1tNEdTTWlZVUc3VW5yN2gxYmN6dFhndGM5VjNHd2NTMzhjTVJN?=
 =?utf-8?B?aWVVVlRkMm1xTGIrVFhrcytyUmowVkYwYldxckRka3RvQnhRTTFwZnpFelhW?=
 =?utf-8?B?U1lUV0ZlVHdQa0VBNm11V3cvVE9GaXYvUzM5bjZTOHhBMGR4NVo2WU0vSVNj?=
 =?utf-8?B?RklPV3ZNdEJhQkVUSXB5UFkwc08xNDhXSUdwZlQyaGs2KzBQUEhpbllTcVh2?=
 =?utf-8?B?RmlwYXpYaWFkMFJoSy9oUW42STgxaytRNHJlNkFVWjhoMjZYYzRFSlRLVDM4?=
 =?utf-8?B?NTJ3VFRSNXhSNHhNNTlqWWpQbnFxeWFFRGkwbUxiM0tsMjFGb0ZqSXNzQ1Rj?=
 =?utf-8?B?MkZzcFplM1kzemtFWVkvR3E0THNGQ2lMaHUrbHV4N3FBN0RpQjBsQUN4RE5F?=
 =?utf-8?B?SVNneXB6V243T1kwOXUrTHRpRjRObU5tWG5JQU83QWI2cFJxYkFhcFNjYjhm?=
 =?utf-8?B?MzlyZC9LTURuMkVUcGNReHdBR2lheHBrUCtJdHdJLzZYeDZpKzI4a3ViUC9r?=
 =?utf-8?B?VER2ZER3NTJmbHllSUwrZG5FNE9vTTZCelhyeTdSYTNYSmZvdVNqZS83Tm12?=
 =?utf-8?B?SW4wWktUdTFnQkVnOFFTMk9XZjJvZTVVT09mMjFJMy9Qd1ZQdll2L3FOaW5m?=
 =?utf-8?B?RytEVUJBN0dSZ2ZSemFURGc2cUZIZjZjREsxL2dYeFM1dzdPbUluY250T0pk?=
 =?utf-8?B?UFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e9d645b7-81ff-4f02-89a9-08dbb628376e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 20:13:24.9717
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TjwO4wZmMumryGw+upBlrjW9kNxVulvZbUerFUcAZhKBridKTfP4DNf7CvDMSlSII/p4AM+61GaqkVlZWtCmoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7090
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:14:43 -0700 (PDT)


On 9/15/2023 10:04 AM, Ilpo Järvinen wrote:
> On Wed, 13 Sep 2023, Jithu Joseph wrote:
> 

...

>> diff --git a/drivers/platform/x86/intel/ifs/runtest.c b/drivers/platform/x86/intel/ifs/runtest.c
>> index 997d2f07aa0c..9cfd5c015cb2 100644
>> --- a/drivers/platform/x86/intel/ifs/runtest.c
>> +++ b/drivers/platform/x86/intel/ifs/runtest.c
>> @@ -327,6 +327,38 @@ static void ifs_array_test_core(int cpu, struct device *dev)
>>  		ifsd->status = SCAN_TEST_PASS;
>>  }
>>  
>> +#define ARRAY_GEN1_TEST_ALL_ARRAYS	(0x0ULL)
>> +#define ARRAY_GEN1_STATUS_FAIL		(0x1ULL)
> 
> Unnecessary parenthesis
> 

noted

...

>> +
>> +static void ifs_array_test_gen1(int cpu, struct device *dev)
>> +{
>> +	struct ifs_data *ifsd = ifs_get_data(dev);
>> +	u64	status = 0;
> 
> Just use space instead of tab.
> 

Will do


Jithu