Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 15 Sep 2023 22:13:40 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     linux-media@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation: dt-bindings: media: i2c: Add ROHM
 BU64754 bindings
Message-ID: <20230915-starch-bankable-c4102e405a73@spud>
References: <20230915165946.4183839-1-kieran.bingham@ideasonboard.com>
 <20230915165946.4183839-2-kieran.bingham@ideasonboard.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kq4SaRLaezFRFdFr"
Content-Disposition: inline
In-Reply-To: <20230915165946.4183839-2-kieran.bingham@ideasonboard.com>
Precedence: bulk


--kq4SaRLaezFRFdFr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Yo,

On Fri, Sep 15, 2023 at 05:59:45PM +0100, Kieran Bingham wrote:
> Add YAML device tree bindings for the ROHM BU64754 VCM Motor Driver for
> Camera Autofocus.
>=20
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  .../bindings/media/i2c/rohm,bu64754.yaml      | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  7 +++
>  2 files changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/rohm,bu64=
754.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yam=
l b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml
> new file mode 100644
> index 000000000000..22da4a46bb0c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2023 Ideas on Board Oy.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/rohm,bu64754.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BU64754 Actuator Driver for Camera Autofocus
> +
> +maintainers:
> +  - Kieran Bingham <kieran.bingham@ideasonboard.com>
> +
> +description: |

That | is surplus to requirements since you have no formatting to
preserve.

> +  The BU64754 is an actuator driver IC which can control the actuator
> +  position precisely using an internal Hall Sensor.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - rohm,bu64754

Why such a complicated pattern when you only have one item here?
Why not just const: rohm,bu64754?

Otherwise, looks fine to me.

--kq4SaRLaezFRFdFr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQTJBAAKCRB4tDGHoIJi
0pX7APoD4Kw9SlBLfhiuKvhkDRf+fTvAqfbXIgomg0v8+f45SAD/c6EsQdkx35AK
UEbTPbXlg9E1wyDB8q8C/ELFMgIXJQk=
=bR/q
-----END PGP SIGNATURE-----

--kq4SaRLaezFRFdFr--