Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <d4e74e31-246c-1f8c-1465-b0bb6ce8454c@gmail.com>
Date:   Fri, 15 Sep 2023 17:49:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] tty: serial: ma35d1_serial: Add missing check for ioremap
To:     Chen Ni <nichen@iscas.ac.cn>, ychuang3@nuvoton.com,
        schung@nuvoton.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
References: <20230915071106.3347-1-nichen@iscas.ac.cn>
Content-Language: en-US
From:   Jacky Huang <ychuang570808@gmail.com>
In-Reply-To: <20230915071106.3347-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/9/15 下午 03:11, Chen Ni wrote:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> Add check for ioremap() and return the error if it fails in order to
> guarantee the success of ioremap().
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/tty/serial/ma35d1_serial.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 465b1def9e11..4a9d1252de35 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -695,6 +695,9 @@ static int ma35d1serial_probe(struct platform_device *pdev)
>
>          up->port.iobase = res_mem->start;
>          up->port.membase = ioremap(up->port.iobase, MA35_UART_REG_SIZE);
> +       if (!up->port.membase)
> +               return -ENOMEM;
> +
>          up->port.ops = &ma35d1serial_ops;
>
>          spin_lock_init(&up->port.lock);
> --
> 2.25.1
>

Thank you for this update.

Acked-by: Jacky Huang <ychuang3@nuvoton.com>


Best Regards,
Jacky