Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.84 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.84; helo=inpost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <a94e6fc8-4f08-7877-2ba0-29b9c2780136@seco.com>
Date:   Fri, 15 Sep 2023 11:36:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553
Content-Language: en-US
To:     Markus Schneider-Pargmann <msp@baylibre.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Vivek Yadav <vivek.2311@samsung.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Simon Horman <simon.horman@corigine.com>
References: <20230721135009.1120562-1-msp@baylibre.com>
 <20230721135009.1120562-6-msp@baylibre.com>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20230721135009.1120562-6-msp@baylibre.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original: 7H56qJfUBavGAh4QOLJaTaMEZ8qj82FpZbDwRf4FYLAEMePBsHV9fnXq0xAVy66dEJP59U3Z0PLsVHS1+/qtKTXPiJNXzyxzNpgft3ZECdJ+Z7g19HTPeDB4WNnoj/VXxZpeu3wvClwqpeCUXLQGm2fsWrhKB7ZPI/HNHONmnAVNOmJ3g+I1Eno9a41/VxrjjYlnHWSRqtE7VJuPweuggdCQiPODI94gHfuUF4LZRLQ2Y4lisvniMnDsWMdCbw8/aqakDpMnBMP+Xs/NUrqFOOVIODLmpPrANrw8cIFrPkabgHQjIAPBsqlu+glh8zTAacFJ92tYYvy3IcI+Qfi89otPTZsgpk/w/1QWZ9utngzMf5k5FuRNyFlFPhe2PGuDcJkgMBVa4SZr9gkXwB5FM8fdLH9q+MbDpoIkk3q3qIyWciP3wqYNv3QWXjDqLy8I01IAinrs2NSo9rMf8wOdk68Hj+uBd9hthwQgcZiJBmP6YEchXWOmUffny3TX9QBHW2SWA4E9io8yVWX60wqSrJOiaQtrVHp8296yf4kRWJVbfhh7EDNTu+HAcWoNcveKa6Hl7AMG1Yi8up7kvAKxu8u9U4uceDT/E50q1jMGLGhe7OlCEtOk5NPRmxutgcx5LjTNtUaSHYFU0ZSqBiutzK6fqaYzOkRkTP6hziJE2H6shkap0BC49b4gZNPVMCh9
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39850400004)(136003)(376002)(396003)(186009)(451199024)(1800799009)(38100700002)(2616005)(6666004)(478600001)(26005)(36756003)(6486002)(6512007)(53546011)(6506007)(52116002)(66556008)(66946007)(110136005)(41300700001)(66476007)(316002)(54906003)(31686004)(38350700002)(5660300002)(44832011)(2906002)(8676002)(8936002)(4326008)(4744005)(31696002)(86362001)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6248
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM6EUR05FT065.eop-eur05.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 3ab34520-c284-4119-8045-08dbb6019760
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nf4pFu6JiHWZIuw4fErCH+RcjhVj88DSft0foEkADv94axB84tL3pklRnpVsJVRJHFvhyci+WuXoPMc8KbLiFNIzNHSYfeOLva9JaJWIA6gjVI7Q862/MutC0eiTL8QPWCuEu8khv7CqyGlLLV3Pw1Fy1c3N/vQ5u0YJvP0lpDd5Pm3bxwwSNloJBEvqRpYMrSb8Q9mAamuAMmk25/0BdF5t39iktVy/mIZPCMWI3bxJTm6VJfJRvpmW+do3p9U+2UiSHhCBYyVhzc9uYRhblYg4+60pW1Rx6y0TNeIvSz+78kk+gMn9cjtYbrf7EbCwr3NMcCaIvIzS6FhsBpoesGXzHL7Ns8ZVzaCycb4/OtxknZFOdDQwpcj/jhQXbW7v4L/FKmr7KrTMk9a3bhs5ddxLUwyO9qg/HCanANEAh1cwQb8ypA5/pC6yzIk46ESTpA2pbPWG5cGPpY7g1nILZnyHdaQfRkwJeNDcVUfLDb0bdZLnCZ2dwvm1vWhfR7bmbcOeoLT82MfH7g8JC26l84/+6oMbPARlPOmRBQ6VyC9ThgN/8k71YIfDqoz/ihI3Gv6OzDqop8uveY4KgriDSDauY+5khJYBdkCXvuc7Pl9JGNlrQd+63Lqp0G7jgL5ta04BmenAFkKN7ve5YbPBt7yZ3KVHQQEueE0ZYy4/glybLswZQvIPnNSBOo+XUYYS4artOUeY4XqS7Jf1OPRyLf6DGNdtsBfTFGfJ6Ak5M7qcNfmdggReRDc2RlF9le3MACl3aMMxpsJKPAEh+dWGVQ==
X-Forefront-Antispam-Report: CIP:20.160.56.84;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:inpost-eu.tmcas.trendmicro.com;PTR:inpost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(136003)(396003)(39850400004)(346002)(376002)(82310400011)(186009)(451199024)(1800799009)(46966006)(36840700001)(5660300002)(26005)(8676002)(8936002)(4326008)(2906002)(4744005)(7416002)(86362001)(31696002)(36756003)(7636003)(356005)(7596003)(82740400003)(36860700001)(47076005)(34020700004)(336012)(44832011)(40480700001)(6506007)(6486002)(6666004)(2616005)(110136005)(54906003)(70586007)(70206006)(53546011)(478600001)(31686004)(41300700001)(6512007)(316002)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 15:37:04.0450
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d0d54e89-dbf1-4b2e-5510-08dbb6019c8f
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.84];Helo=[inpost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource: AM6EUR05FT065.eop-eur05.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6368
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 15 Sep 2023 08:37:51 -0700 (PDT)

On 7/21/23 09:50, Markus Schneider-Pargmann wrote:
> +static const struct tcan4x5x_version_info tcan4x5x_versions[] = {
> +	[TCAN4552] = {
> +		.name = "4552",
> +		.id2_register = 0x32353534,
> +	},
> +	[TCAN4553] = {
> +		.name = "4553",
> +		.id2_register = 0x32353534,

Should this be 0x33353534?

> +	},
> +	/* generic version with no id2_register at the end */
> +	[TCAN4X5X] = {
> +		.name = "generic",
> +		.has_wake_pin = true,
> +		.has_state_pin = true,
> +	},
> +};

--Sean