Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 14 Sep 2023 23:18:31 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>, Tristram.Ha@microchip.com,
        Eric Dumazet <edumazet@google.com>, davem@davemloft.net,
        Woojung Huh <woojung.huh@microchip.com>,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        Oleksij Rempel <linux@rempel-privat.de>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW
 offloading for KSZ9477
Message-ID: <20230914231831.0f406585@wsk>
In-Reply-To: <20230913184206.6dmfw4weoomjqwfp@skbuf>
References: <20230912092909.4yj4b2b4xrhzdztu@skbuf>
        <20230912160326.188e1d13@wsk>
        <20230912160326.188e1d13@wsk>
        <20230912142644.u4sdkveei3e5hwaf@skbuf>
        <20230912170641.5bfc3cfe@wsk>
        <20230912215523.as4puqamj65dikip@skbuf>
        <20230913102219.773e38f8@wsk>
        <20230913105806.g5p3wck675gbw5fo@skbuf>
        <20230913141548.70658940@wsk>
        <20230913135102.hoyl4tifyf77kdo2@skbuf>
        <20230913184206.6dmfw4weoomjqwfp@skbuf>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/f7Bh6uyRP=wObsNfKuHGfr2";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/f7Bh6uyRP=wObsNfKuHGfr2
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Vladimir,

> On Wed, Sep 13, 2023 at 04:51:02PM +0300, Vladimir Oltean wrote:
> > > I'm really stunned, how much extra work is required to add two
> > > callbacks to DSA subsystem (to have already implemented feature)
> > > for a single chip IC. =20
> >=20
> > Some observations are best kept to yourself. This is only the
> > second HSR offload in the entire kernel. To complain that the
> > infrastructure needs some extensions, for something that wasn't
> > even needed for the first implementation (tracking a MAC address),
> > is unrealistic. =20
>=20
> Can you please test the attached incremental patch, which applies on
> top of your RFC v4 series? It contains an implementation of my own
> review feedback.

Thanks for preparing the patch - it clarified all the point from
previous e-mails... (and shed some light on mine understanding of DSA
internals)

It works when applied on top of v4. No performance regressions (with
nuttcp) observed.

I've also tested the scenario when one tried to alter lan1 after HW
offloading enabled. It was not possible to alter the MAC address.


As fair as I understood from the commit message - some part of this
patch needs to be applied before HSR offloading v4.

Hence I will wait for it to be posted and upstreamed.

Only then some of this patch code would be squashed to v5 of hsr
support.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/f7Bh6uyRP=wObsNfKuHGfr2
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmUDeKcACgkQAR8vZIA0
zr2aiQgAjbddYHIsZ5gXqPROrAWEQ6T4afqk4bryUfpgNiXiT6uDYt+m0ohRfezL
gzEU+D1pom+5m9YPNXJpM67lIO1HKx55v30d7vOo3wY4xwPYBDvo9kkK2j0gtEHl
6iJoJn6tTqZnY6Oyusd4WfUo2YSmFyM6PwyaRf5vYtGDhnjogKEn7oBf7nPMJt71
D+fGRo5eJuV8Ckdez7BzePskYzCr3VygnBoZfVWcQhfSA4JlhQfednx/WslgPNFS
75XhnDxePuozbC1rUt1LBAzXYvEOgWG6T6oElIXBCB2TsrIWcuIXeIS9Ys26ZsH/
F+IqSoVI5kWml9IvOiscMxUwFkTx2w==
=5sNg
-----END PGP SIGNATURE-----

--Sig_/f7Bh6uyRP=wObsNfKuHGfr2--