Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Fri, 15 Sep 2023 09:44:45 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Chen Ni <nichen@iscas.ac.cn>, <oohall@gmail.com>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <aneesh.kumar@linux.ibm.com>
CC:     <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Chen Ni <nichen@iscas.ac.cn>
Subject: Re: [PATCH v3] libnvdimm/of_pmem: Use devm_kstrdup instead of
 kstrdup and check its return value
Message-ID: <650489fd836d_37804029451@iweiny-mobl.notmuch>
References: <20230914070328.2121-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230914070328.2121-1-nichen@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZSeadA40id4rlQ6ez9iYNEz8IgcSCQGNACTNouYv9s2CvE9tfjTFTExWOI35?=
 =?us-ascii?Q?rW+Gsx72KeYHJmQ3QzoLYgdYmB1CopFPShxE+qnij4VJxnpSZKTWW05tUF8Z?=
 =?us-ascii?Q?kTTNlzxutUbQEb3CC3amtv0lPsb9d3/8us/vK845CqrqBJ3/j/xjzNoojxTq?=
 =?us-ascii?Q?ftASZFJ6d3vnBnuBlj1iRW5jTpXDnw2JOP9iphCS3OSH2gDqOYn2NP4yv4a7?=
 =?us-ascii?Q?VeL8eecBx6+8T/Q9DC+ql9ub6KZYxQsUXZzR4tWLm1o6I+qswyLf0RCPnUXF?=
 =?us-ascii?Q?cd48ELDBnxR7/y3B0SONPgnslXtsorGFtDsEW/w88+0Rms1gnjNGN+ZCv+8d?=
 =?us-ascii?Q?imOL4FxnPc5eHsdpVl4oPCETFkJoZ8QvBeiIxntSfJ7lTTwuQvLAoteMwlZ4?=
 =?us-ascii?Q?fYgx34D+Nt90iH8OGPvY5kUt+zoYZbmddLE6LDX4A0lOGdBkaOpPariNh0PJ?=
 =?us-ascii?Q?3sEupPr8Zs3iutpKH8PpgWzyc4A8T49faL+7H4JAdhXUGljySQg6BL0vQFas?=
 =?us-ascii?Q?8w7ugX0ifa2yIWCJIGSP5y+I/VuP4t0ptXpYdIEI6j3AsmZNLV3y7dgVdgpb?=
 =?us-ascii?Q?pYBP3WoPOHkukf+2f+npJC5IGsisvf3YWyldLyim61csof+wqNyy2oLJQhIb?=
 =?us-ascii?Q?U1lQQqG9iu6xTey08H/pNOuX9mSoNo/VR4bcFMEeqEeu+Tj6uL0ZTf/o0xun?=
 =?us-ascii?Q?3f3oKoBay+nUWH8Pw5O+1UKMToboIEn+3XdxeBAo5E7YfttRBTHiycLOSc6M?=
 =?us-ascii?Q?+HY6GUyI5HNKZOjaJGX3o+l4Kzb+wwWj3PWNjOrPjpfZPO1YEsYRWsxa9wAU?=
 =?us-ascii?Q?CY6V0CABJbB4vEp/Hy5BUyiQsQXptsHNCZdCgODUuPTCljGO4WIbkSNzAkKd?=
 =?us-ascii?Q?6/YGVAdtmFuX0H1ZTP9zgUlzDcdxiJjEdEenSSVwQl0a0LY5pQ/uMqbjFtuv?=
 =?us-ascii?Q?k7fkBwJM6FyfXcnY57JPCHXWpESo9zbt6wiBd+ShCIuy5ejAGCM9KRsscZl0?=
 =?us-ascii?Q?MWQRj9j98914jXgEUvrTFtkuGQKjgYdO+bAbcfTJF248vKTByPFfyDOyanls?=
 =?us-ascii?Q?QbuBu58yV8E3RoKDcZmYO+9fJxJm6jcJJyUKeEVUtYB8vr9s4z3yLXs3clKi?=
 =?us-ascii?Q?/0XA3fovVy88zOnl2ssESg2TWYGac9r3/B6Ca393VRiEKvJ8Ky66VCRmph8c?=
 =?us-ascii?Q?8sYu+5a087WnM2yOGszKqacdiiUN6oXbtlDk41m+OejQB8ZU2gSI/gK4G2HR?=
 =?us-ascii?Q?XClgeHtHWzd3OnYL75kT676Ya35FFm/RLeOiuWxNO2u3qx4nAN81hhW/oSXg?=
 =?us-ascii?Q?O1qhsWsKUfQeAkEL1JX7J7UkkmbA/Vt01RknJBE7x9ly/h+xXw7+wVC4rEho?=
 =?us-ascii?Q?PuFGkc+zncJZ/rTkVd+KgppubZEe3XROsDY0d5YNrq9M/6xkxQHRO3XDr907?=
 =?us-ascii?Q?fcycGSirACymRIwh7Et3DuF+yy9s2cGXJDKY3kG40okPZlUqdHdyS2MDINq7?=
 =?us-ascii?Q?QCXok9HOdqMp0n8CECtFhJA7WLjHWYD1cMIwCLdU+DU+kPjU1CVJTttCS0XI?=
 =?us-ascii?Q?RQFg9cLr8QqNRICxkNmVarpV0eTqx9qu6c8vVWXx?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 30f3cb41-15d3-4b4b-5b65-08dbb60b12a3
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 16:44:47.8219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xxvgfUrbDKuQQ43nIhH7oF3H2+bFfHvAabUuI4hGb6ZtaeuioLv4Bn1RBlxlOEEYBt+mQstiD8dSvrWtpdICGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8566
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 15 Sep 2023 09:45:49 -0700 (PDT)

Chen Ni wrote:
> Use devm_kstrdup() instead of kstrdup() and check its return value to
> avoid memory leak.
> 
> Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
> Changelog:
> 
> v2 -> v3:
> 
> 1. Use devm_kstrdup() instead of kstrdup()
> 
> v1 -> v2:
> 
> 1. Add a fixes tag.
> 2. Update commit message.
> ---
>  drivers/nvdimm/of_pmem.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index 1b9f5b8a6167..5765674b36f2 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -30,7 +30,13 @@ static int of_pmem_region_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> -	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> +	priv->bus_desc.provider_name = devm_kstrdup(&pdev->dev, pdev->name,
> +							GFP_KERNEL);
> +	if (!priv->bus_desc.provider_name) {
> +		kfree(priv);
> +		return -ENOMEM;
> +	}
> +
>  	priv->bus_desc.module = THIS_MODULE;
>  	priv->bus_desc.of_node = np;
>  
> -- 
> 2.25.1
>