Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759814AbXKGS7w (ORCPT ); Wed, 7 Nov 2007 13:59:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758384AbXKGS7m (ORCPT ); Wed, 7 Nov 2007 13:59:42 -0500 Received: from lazybastard.de ([212.112.238.170]:43086 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086AbXKGS7m (ORCPT ); Wed, 7 Nov 2007 13:59:42 -0500 Date: Wed, 7 Nov 2007 19:54:53 +0100 From: =?utf-8?B?SsO2cm4=?= Engel To: Christoph Lameter Cc: =?utf-8?B?SsO2cm4=?= Engel , Johannes Weiner , akpm@linux-foundatin.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman Subject: Re: [patch 04/23] dentries: Extract common code to remove dentry from lru Message-ID: <20071107185452.GD8918@lazybastard.org> References: <20071107011130.382244340@sgi.com> <20071107011227.298491275@sgi.com> <20071107085027.GA6243@cataract> <20071107094348.GB7374@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 36 On Wed, 7 November 2007 10:55:09 -0800, Christoph Lameter wrote: > > From: Christoph Lameter > Subject: dcache: use the correct variable. > > We need to use "loop" instead of "dentry" > > Acked-by: Joern Engel > Signed-off-by: Christoph Lameter > > Index: linux-2.6/fs/dcache.c > =================================================================== > --- linux-2.6.orig/fs/dcache.c 2007-11-07 10:26:20.000000000 -0800 > +++ linux-2.6/fs/dcache.c 2007-11-07 10:26:27.000000000 -0800 > @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub > spin_lock(&dcache_lock); > list_for_each_entry(loop, &dentry->d_subdirs, > d_u.d_child) { > - dentry_lru_remove(dentry); > + dentry_lru_remove(loop); > __d_drop(loop); > cond_resched_lock(&dcache_lock); > } Erm - wouldn't this break git-bisect? Jörn -- Joern's library part 5: http://www.faqs.org/faqs/compression-faq/part2/section-9.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/