Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Jerry Liu <jerry.liu@technexion.com>
To:     laurent.pinchart@ideasonboard.com
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jerry Liu <jerry.liu@technexion.com>
Subject: [PATCH] media: uvcvideo: Modified uvc_ctrl_fill_xu_info 'kmalloc' to 'kzalloc'
Date:   Fri, 15 Sep 2023 09:12:14 -0700
Message-Id: <20230915161213.42503-1-jerry.liu@technexion.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PhYJOIxzVFuZ8IQ2KRLA6mZHOt8Xx/VwfAZyEwumt6hivDVnF41779Y/jGpP?=
 =?us-ascii?Q?cIeUVNE1B6QU6uD4MiNR7aKyc/GE/Klz/EITmbkUIYfPBMwDQKtc4dTcE30h?=
 =?us-ascii?Q?m7jU+L14cEdJ0PgNFpRJs/CprZHRWvZIj9t7izJXgbVkpAU+gtWslmjlgvFB?=
 =?us-ascii?Q?o5FCsEZoJEg2FAPwBHDsSdkfVRggLbzc3dDvmRG9LXheaGU3aghjj+pt/QGc?=
 =?us-ascii?Q?xIAsF3yp9sQVjOEGYlifwZbc/rHK47+nqAatY03pHKyYXgGSdDi0Ga+DNNof?=
 =?us-ascii?Q?0NgAeewLvMEuaHFcWXanxerJvA9ydH8/1F5u6IhMiR54HjcXa4scInteLoao?=
 =?us-ascii?Q?Oq3dPGNXo225+WGF5VLE8yXZgL1ZmuarhTk5mRp/xctllKGLuApf4WqA1909?=
 =?us-ascii?Q?ZgL/mU1GMH37DiLTloBnWYJ+7RR/0VczW0yIbPQi12B8xA2M20LQyRzpoyYE?=
 =?us-ascii?Q?ZAMntxlipPBD/zp44iNNEC+MW5sGfXsOFirZvgdNXAsdnJFaTLs4k/gVfWD6?=
 =?us-ascii?Q?hjBxvWR12UmDaKZwMdU/r82ZEOQd3p/2RRbDVOLjX4S4V9aeMDTOUqUOH+7W?=
 =?us-ascii?Q?NnoZcuHk/pm9PPkP/iF/6KmbbZafFCeZCu9z+ozGywBCad7z4B2XX/T7rktU?=
 =?us-ascii?Q?T1FRGoa5wGGz8xOwVf5TrDq1jFxyNP95kq/M9bw6f580Pi+Tgc7wSaVNXMca?=
 =?us-ascii?Q?8td1/rT20MV8KbYG0CfXhnlRMny9kyDeB+1n5hctAxvroQYtw6TRrAfM84lD?=
 =?us-ascii?Q?sxJn2FqNrB32B+7QOebRA6/1gsur3pfwUV97XRX6RBq38j3krHp5T1eYXZE1?=
 =?us-ascii?Q?zirXU4R7KORnfdrwb4/pgBmy6dZ9mljsjwFPFwDD3xrja6SBh2W50gOQ+qfg?=
 =?us-ascii?Q?xX5wywtZ79WMa37HalWUWgmDGOr+4wloJpl21gxZFvCpce+NZmnzmaXE7cTz?=
 =?us-ascii?Q?N/urSnlAJ77dlsHYwUo4bYmrgFMsQHfcV5pJGYIRzt61gFg7adOgf35gvTHK?=
 =?us-ascii?Q?/yzUcTsXu+ocfvTvx6zofFn8Hdkuy7vVpzK+N+gOygvam0+AsOOGilz9se/6?=
 =?us-ascii?Q?mrDBaVz0iS5UxCipN2CdGF5CcQTMWMlgrY8KMq4/ea7QfhC88IOVGmCoSDjz?=
 =?us-ascii?Q?VUR6YPcX/qE9yX5oZ/wlj3Cd/Vpk7YxQnSB/RWJa/uJkkFi9cdmk+CEDfMzB?=
 =?us-ascii?Q?6xXV+6vh4WkLNMV2OCkKAOaT/9M5Pqmx+6uj4BHpLvwDSx9OY/tRuaFs/FnW?=
 =?us-ascii?Q?SPvpglX29Nm02MkxhGrhOsfYlFNh1nCICz7GUzjf37yuqWYw9sDTIMDZcNUC?=
 =?us-ascii?Q?3vLgAqJk91CJP4OusHnzrU8Vm2U7qmDt5aFJPwNLEIqHD1BZwygUUU+Uy1l1?=
 =?us-ascii?Q?O53TwnYGtQV5vy8TCpaglhk+AZr5cHCFff5zPyaFcvTZXSsr7no2FiL6dbUw?=
 =?us-ascii?Q?gQ36CoDQItmJ3n5rVuXLxLegQkKSrDFjR63mBed60XM5CxWbkQUcfryoNh3D?=
 =?us-ascii?Q?yRCaPLg4wXxSmW1xIDBE73J3xUv/xl6h8aMuXuyQuqPScxpSpgygpzU4jHxr?=
 =?us-ascii?Q?Vg937l+gTm2y6wSbxsV36B3iwB0PJ/SjXAln0kojtJBf0q8oYHPTS2S104+s?=
 =?us-ascii?Q?+A=3D=3D?=
X-OriginatorOrg: technexion.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e85466dc-e442-4196-c0ab-08dbb606fa4e
X-MS-Exchange-CrossTenant-AuthSource: PUZPR03MB7015.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 16:15:29.0604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5ee19679-b9a6-4497-8ed2-1eda849e753b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZjguxTt61/Y0qjiNCQXRiXXcKYzKInE0OSCD6458NgCNDNBh8ZuCUeE8TWhQGGZAN3/e6orV0YLkeWR3dK2oteIAkfvwBmgRYW1gEx4L2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5783
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 09:17:02 -0700 (PDT)

If the request length of UVC XU is 1 (even though this is illegal), due
to 'data' may be the non-zero value, UVC_GET_LEN could potentially result
in a length that is not 1 because of the high byte is not zero. In order
to ensure that 2-byte data array is set to 0, 'kmalloc' is modified to 'kzalloc'.

Signed-off-by: Jerry Liu <jerry.liu@technexion.com>
---
 drivers/media/usb/uvc/uvc_ctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 5e9d3da862dd..054bc14f7a58 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -2088,7 +2088,7 @@ static int uvc_ctrl_fill_xu_info(struct uvc_device *dev,
 	u8 *data;
 	int ret;
 
-	data = kmalloc(2, GFP_KERNEL);
+	data = kzalloc(2, GFP_KERNEL);
 	if (data == NULL)
 		return -ENOMEM;
 
-- 
2.25.1