Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4947318rdb; Fri, 15 Sep 2023 18:39:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKF7BraK+ZNQqnpf9rxuBs+jNef1PP1lDRDz+aakEvV6WXugLBEUd9vrdqZIkGOby6eSc9 X-Received: by 2002:a05:6a20:9193:b0:130:7803:57bd with SMTP id v19-20020a056a20919300b00130780357bdmr3655920pzd.3.1694828365506; Fri, 15 Sep 2023 18:39:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694828365; cv=none; d=google.com; s=arc-20160816; b=SXY1D83A4CFPN3piLaUsuYGbZDlFj/nCp8yxS+kZTizbl+s/5lb99tkDZM5AB7RhBY 4jeVIkOYb75wau9hDY/9K5CkB8IeKa2LxNOGcBwwcvqPUB/3wVea1cumfLBR7tKdrqqQ IAKrTTJcTB7ZUb+ym5j7qY10iGE2fWs3vPxmYDq7W0JlepN3U7XBLqliPVY94o2YunkQ EBJ6DJMpCtxcGUiVZS4ciU88jRMcXMul7EHKzZO+rBgA7zpzu6IAUrpSWDZmM1a/2esV H+DDMrpQYmtM0JIUcsCQpJo7h/Xe7bINrulGnqMzMF+33wIKxy3hNohHA0/9GeTdOuhH JzZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ACgwXt5WGrX2j4PYTtUkL9OiFfodaBbXHcP278ZXTG8=; fh=J/Tdp6DUamc8sA1HTuiwIDZYTQ3lnfVGKPrVMKro77Q=; b=EP8IqmGZixN+IqCgZKlzbzD16j9tLLvkxGomRO8NCYqof7i4CqvYrzW41QhaCyJfeB qC1l9LqMjlST70vQvAtpiXEh4/y+YJ1nvA0hHlw1Pqs2T8jPdukcCGtWrNyVJEC28yCd 8nEZD/oeJ6LcPRsNL+CoYToKyy6FOV/7h0zPHhEnbFrVDDPheTmNFfwGfMGEMOVlwrN5 S7cPPy0YnNlDZ/2YirgllU0e6YkzNQ2YRlUD9sU6JCH6G9AFIZBjI5IPQuYGYthkDeXn qsBz9DHfLwvAExFBPbloG3wRSyFwewItWnlLokhoiiDfO3OKCUKohWjodJkCPLiRsZsM uozA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SLlzPpE2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id b2-20020a170902d40200b001bb792749a2si4036045ple.146.2023.09.15.18.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 18:39:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SLlzPpE2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6741E819068C; Fri, 15 Sep 2023 05:15:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234602AbjIOMPu (ORCPT + 99 others); Fri, 15 Sep 2023 08:15:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234662AbjIOMPt (ORCPT ); Fri, 15 Sep 2023 08:15:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C09F72119 for ; Fri, 15 Sep 2023 05:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694780101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ACgwXt5WGrX2j4PYTtUkL9OiFfodaBbXHcP278ZXTG8=; b=SLlzPpE2gZkEtXp5VCb2x8TgXAyEt5N0+IwSnR+j6b8eWY9N1fqHlbgtyWt9KXYF7BeJdb hFRawPsgLh2duIT+/6wzi+94DX7KkjRgmSxm0btPSYCKLr2KznLlZbt6e+lWHt5d7ez3tU c2Of6O1ZfkNFIwkMZzqgitA2umsvBEI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-4nVovntiNzWNMyYKgoc7XA-1; Fri, 15 Sep 2023 08:14:57 -0400 X-MC-Unique: 4nVovntiNzWNMyYKgoc7XA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40474c03742so10919885e9.3 for ; Fri, 15 Sep 2023 05:14:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694780096; x=1695384896; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ACgwXt5WGrX2j4PYTtUkL9OiFfodaBbXHcP278ZXTG8=; b=AMr2HRj7IDPSToPClgvqkSJQN8QbMYlSOSpZ00Qw62iPmltAyTRGS1yLGLopsQVNcl u0g0hz6v5QfeRVdNNy36KI7/bTguvb+bhS6iIrk0uHXBwfvNT+nJjaodexqWlPPF8W4p ZG3va3Pw2T0UIZ0mWYLb5YKqi/uFTA3UZkh1NSBx3dTe+ZFxazRXgjey1CCwnQa2V1/C Jnixmv3NWPB7R4N23dgfHxjqY6UPCCa7WzhoqqUv+VzpT3swSw+ZdI82RNFVO6q7ligK 2laAMPaJkCGrwKsFLM2lraM/VvH3M7sNGmeXo+Se94SlqvWB8cuDVd4ae48/XLLsxN6K rNzw== X-Gm-Message-State: AOJu0YyBlyGI1W9TmLB6lJMmADXxgUCAnIC5P7ye/aO85Ka7lgTV5rgE QNtvuXVEpZ3Pdw6QjV9YLtB0EZjJ7oUdQJd9MurLY4tZt1K5YzGSMJkeKqfeJV+0+vrBV0jHos8 zimM7ocLOTr55tEoT3/p4SZLV X-Received: by 2002:a1c:f204:0:b0:401:73b2:f04d with SMTP id s4-20020a1cf204000000b0040173b2f04dmr1397141wmc.14.1694780096483; Fri, 15 Sep 2023 05:14:56 -0700 (PDT) X-Received: by 2002:a1c:f204:0:b0:401:73b2:f04d with SMTP id s4-20020a1cf204000000b0040173b2f04dmr1397124wmc.14.1694780096124; Fri, 15 Sep 2023 05:14:56 -0700 (PDT) Received: from step1.lan ([46.222.72.72]) by smtp.gmail.com with ESMTPSA id b14-20020a05600c11ce00b003fee8502999sm7333595wmi.18.2023.09.15.05.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 05:14:55 -0700 (PDT) From: Stefano Garzarella To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Stefano Garzarella , Arseniy Krasnov , virtualization@lists.linux-foundation.org, oxffffaa@gmail.com, Bobby Eshleman Subject: [PATCH net-next 0/5] vsock/test: add recv_buf()/send_buf() utility functions and some improvements Date: Fri, 15 Sep 2023 14:14:47 +0200 Message-ID: <20230915121452.87192-1-sgarzare@redhat.com> X-Mailer: git-send-email 2.41.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:15:52 -0700 (PDT) We recently found that some tests were failing [1]. The problem was that we were not waiting for all the bytes correctly, so we had a partial read. I had initially suggested using MSG_WAITALL, but this could have timeout problems. Since we already had send_byte() and recv_byte() that handled the timeout, but also the expected return value, I moved that code to two new functions that we can now use to send/receive generic buffers. The last commit is just an improvement to a test I found difficult to understand while using the new functions. @Arseniy a review and some testing are really appreciated :-) [1] https://lore.kernel.org/netdev/63xflnwiohdfo6m3vnrrxgv2ulplencpwug5qqacugqh7xxpu3@tsczkuqgwurb/ Stefano Garzarella (5): vsock/test: add recv_buf() utility function vsock/test: use recv_buf() in vsock_test.c vsock/test: add send_buf() utility function vsock/test: use send_buf() in vsock_test.c vsock/test: track bytes in MSG_PEEK test for SOCK_SEQPACKET tools/testing/vsock/util.h | 3 + tools/testing/vsock/util.c | 124 ++++++++++++-------- tools/testing/vsock/vsock_test.c | 187 ++++++------------------------- 3 files changed, 117 insertions(+), 197 deletions(-) -- 2.41.0