Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <8b047dad-84ac-69f9-3875-38bca92d7534@amd.com>
Date:   Fri, 15 Sep 2023 11:52:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/2] KVM: SVM: Fix TSC_AUX virtualization setup
Content-Language: en-US
From:   Tom Lendacky <thomas.lendacky@amd.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Babu Moger <babu.moger@amd.com>
References: <cover.1694721045.git.thomas.lendacky@amd.com>
 <8a5c1d2637475c7fb9657cdd6cb0e86f2bb3bab6.1694721045.git.thomas.lendacky@amd.com>
 <ZQNs7uo8F62XQawJ@google.com> <f2c0907c-9e30-e01b-7d65-a20e6be4bf49@amd.com>
In-Reply-To: <f2c0907c-9e30-e01b-7d65-a20e6be4bf49@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFJ4bXZCRERnL0J6TlJjWHZBZlRUWlNySFVERmlKNjdOVFk4R2xYZjZDbitv?=
 =?utf-8?B?TDF6MkNZKzgzOXVoN2VHemNJeWhHYUZ3ZGd4NW1MaFpCVkxieHZWY284QkVT?=
 =?utf-8?B?QzVrUGxWdnpNQ1lDK2RGajJHa1BQT2Uwcnl6NzFCekZ3cTJUTUwwZXpCQm9T?=
 =?utf-8?B?VkFNSzRLejFtbXZxK29ZVlo5Ymp4ZXlselRJQUlCb3FzUHcxdEZLOThaNHdo?=
 =?utf-8?B?MCtFejFvaUV5b3NJYmgxV3BiQzFMVk8xUDQxRS9RTnlRVndqanBLZXM5aTFy?=
 =?utf-8?B?R3hDSktvMTJkdURINWt0Y1NkNWhadndTYWEvTHhNT0pSUktsL05CKzkvNmx1?=
 =?utf-8?B?WFRpZVhURTlsZ3Y2L1dyc2FNZENBU1p4S0JhMnFNQm5NblF5eHdGUkxKSnJt?=
 =?utf-8?B?OUw5MlJ1R0wwRjdhWko3MTZTODZnMlExQXNOQTJuZ3lKQjVZTDNjbDBCUW1t?=
 =?utf-8?B?SEdVWlNrT0RacVNPK0VtMVd1MFVqK2FkUGZoL2tCV1lhSm1JakN6M1VDNzNZ?=
 =?utf-8?B?MmEreFE1czE4ZFBKTmJ4RWo2SFZxaTBSSGRrNmhTYVNXUy9VNFFJVnh6NFpI?=
 =?utf-8?B?TVhrc2tGYlpDVHRqSTlTaGlBenpXMEFQZWdSYXoxLzlCcG52UlVSRWZDUHVG?=
 =?utf-8?B?aVJMbW9lRkozQm1HRTl6VTB5MUZGdVZaWXlsbU5vVnhzcHkvbG96S1pqYjBP?=
 =?utf-8?B?ejVYcldobzZ4bUpUejlIZjE4aWtVVldZZUN5QVlrVHdyZlpIdXVXN3R1enV5?=
 =?utf-8?B?UktLWURnb21UZ3c0SVBQTjl3RU16bDd1ME9qdDBhbHRDc3BiOWxrbkF2dlBB?=
 =?utf-8?B?b1VaWmU1U2pxaUxxbWFtNGxITXZScWd4R1ZmT2YvZER5UFdrYVNCbnBzM2R6?=
 =?utf-8?B?MDFPQnhDMzFzT1B3dTRuVitMUXgvcUR5MDUyNnNyU1JEU2hIQnVpT0sxZ0xH?=
 =?utf-8?B?S2ljNllja1l4WFJCVVJlU1hnU0RNMHJVN1VFMjZWb2tDdi9WNmx1UXplQVdX?=
 =?utf-8?B?UlYxdjdjaU8zaDZTR1djUzhyMmRyb0g5U2poNTE2TDEvajZjSFlrOGVZSGQ5?=
 =?utf-8?B?MUp3alFiSUVVczhJUFBaUG9pdDg1RWxpUTAzWXNyMG05OG0xVnVYdjYwNld0?=
 =?utf-8?B?N3Ewc3hSenExMCswVVE1SW1pTVAxMnNWK251MkROa2xLM3RTVThnVUNqbnpi?=
 =?utf-8?B?UHk5RXVDcUpzSlczdlZnSTFxQklQTFZFSUlxSDF0RGErZXpER0l5QURDcnFm?=
 =?utf-8?B?UjdVd0tIR1pBZ1YxOVJXOEhacW83ZFhGOHV3NXo2THV1R1VJdjl5d25icVUy?=
 =?utf-8?B?QUN6MFFyYktBYXo5dTkydEZrNE05UmtKNVN6Rm1UbmpGUUExbEdKb3NsWlJ6?=
 =?utf-8?B?aDNKT1FBdFZMSkl3cEp3L0FWZW85cy9zeGtVUkZ3RlVGMzcxS0UwcGRrbEhW?=
 =?utf-8?B?TFNuV3AvcWRrdk01aHo4WmZxU1lkKytxdCtIL0JRQ05kRUU2b2JKMTBOVFgr?=
 =?utf-8?B?UmVpN3BkaDBPZEdMTC9wMDNPQmxIOW40N3dqVGJoTEZ6WTNkanpTUG56M1lY?=
 =?utf-8?B?SU4wc1VvOG56R3IyWlhHWkdSZFhDV3JFQnJPOWIxeWpxazJTR0lpOUJTaW1T?=
 =?utf-8?B?eE9xdStlQTdyRkVMajVVeVV2ejVjYW5Xa0ZBcVM3V3FvbTE3MVJ5V3Yvanlm?=
 =?utf-8?B?VHQ2MWZ4ZjJBdzNlam43RHJXT055WE1GdjJMeGpNc1hkSTQvcmNLWEVLK25i?=
 =?utf-8?B?YzQ3TWdlUHpweVlDUjd3OWZBQjROcFJtbzBTNnIzV3E5S0hIQmFCcXVNYkY1?=
 =?utf-8?B?VW00UkR3N1VkZFpuUEhlSzltK0Izc2ZzbU9JbTRaZWt2OEQrV2paLzNhZWdq?=
 =?utf-8?B?aVVjc1pmQ3plaXA5QWFZRzcyNkVLWFdaYllwZWhmUXpWVkNmdmd2dGorY2p3?=
 =?utf-8?B?amY3L3JCQzMrUVpRMis1STZOQzlkMXdCS3lPSm5jTU9MTXlzV3g4ZVIrZXk0?=
 =?utf-8?B?T0VsUVgzSDhYTzZJRXhWNHB0TGdMTkc4cExPR2s2enNFd3dnRUVKdGMzWkVO?=
 =?utf-8?B?Nk9QSlRlVmxUQ0FyZHgxNVYrRncvSkdHKzMrQTBYQWdHeWZ6eVJzdFNMVEF1?=
 =?utf-8?Q?jQepyM9gmU5Fna9FHwdFjhbuW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa38bac-c58c-4a95-1703-08dbb60c2ba1
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 16:52:39.2497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EHeFKAfIOPLQVj2d0rivlifkzJsbXMgRC3HJ8vmOBnWFudoVcKq3hyZfmZ4BHcWVp3txwjDqkGueN0DojVOw7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6414
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 15 Sep 2023 09:53:21 -0700 (PDT)

On 9/14/23 15:48, Tom Lendacky wrote:
> On 9/14/23 15:28, Sean Christopherson wrote:
>> On Thu, Sep 14, 2023, Tom Lendacky wrote:

> 
>>
>>> +        if (guest_cpuid_has(vcpu, X86_FEATURE_RDTSCP))
>>> +            svm_clr_intercept(svm, INTERCEPT_RDTSCP);
>>
>> Same thing here.
> 
> Will do.

For RDTSCP, svm_recalc_instruction_intercepts() will set/clear the RDTSCP 
intercept as part of the svm_vcpu_set_after_cpuid() path, but it will only 
do it based on kvm_cpu_cap_has(X86_FEATURE_RDTSCP) being true, which is 
very likely.

Do you think that is good enough and we can drop the setting and clearing 
of the RDTSCP intercept in the sev_es_vcpu_set_after_cpuid() function and 
only deal with the TSC_AUX MSR intercept?

On a side note, it looks like RDTSCP would not be intercepted if the KVM 
cap X86_FEATURE_RDTSCP feature is cleared, however unlikely, in 
kvm_set_cpu_caps() and RDTSCP is not advertised to the guest (assuming the 
guest is ignoring the RDTSCP CPUID bit).

Thanks,
Tom

> 
> Thanks,
> Tom
> 
>>
>>> +    }
>>> +}