Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Fri, 15 Sep 2023 19:43:58 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Suren Baghdasaryan <surenb@google.com>
cc:     Hugh Dickins <hughd@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        syzbot <syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com>,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [mm?] kernel BUG in vma_replace_policy
In-Reply-To: <CAJuCfpE8jnvL23W6fY4_HZf-969aEgvR3-LGRTUC-SFhPFju+w@mail.gmail.com>
Message-ID: <c5c51578-efdc-7de-2238-4039fb1b6c36@google.com>
References: <ZP/3hgDCXeceE9uU@casper.infradead.org> <ZQB76G/6NxVgoE9u@casper.infradead.org> <CAJuCfpGEa504z1pgqR9KtCWQPESTcRcu8xoyxcNOv=6t4R+ong@mail.gmail.com> <CAJuCfpHYNbH0WmfDnpX6eqL3f3Z632iQrcw6oqPXtB0_QjaiiQ@mail.gmail.com>
 <CAJuCfpF4j6fKpk853tXu155jbfk1z_PbWXjf4bypYwDRf78-iw@mail.gmail.com> <CAJuCfpETZr56WD5j7aQY-dY84ciur=QTZYxuShmjEG+fZFhDsw@mail.gmail.com> <CAJuCfpECwpQ8wHnwhkLztvvxZmP9rH+aW3A39BSzkZ9t2JK6dQ@mail.gmail.com> <ZQNaT/3xPxATKJVR@casper.infradead.org>
 <CAJuCfpEAZbtUrwrfqd+PWJv9efVy1HRbqrLUYAP4rYRvk0vWug@mail.gmail.com> <CAJuCfpGp2CwGJmmwzK7WdudOyL1CCWVaERRK9qTtNA8SZ365SA@mail.gmail.com> <ZQN58hFWfgn+OfvG@casper.infradead.org> <CAJuCfpGRSJhBBZop_L-UubuveUWBca4YtyPBzM2KZGEx7iwhXg@mail.gmail.com>
 <da13f5a-b87f-d776-e58a-d492fa2773f9@google.com> <CAJuCfpGO4bRZaDJv5Vuf2wLh3t4hE=5EqDObm_UfcQk4B08PrQ@mail.gmail.com> <CAJuCfpE8jnvL23W6fY4_HZf-969aEgvR3-LGRTUC-SFhPFju+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463760895-168202884-1694832249=:16517"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463760895-168202884-1694832249=:16517
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 15 Sep 2023, Suren Baghdasaryan wrote:
> On Fri, Sep 15, 2023 at 9:09=E2=80=AFAM Suren Baghdasaryan <surenb@google=
=2Ecom> wrote:
> >
> > Thanks for the feedback, Hugh!
> > Yeah, this positive err handling is kinda weird. If this behavior (do
> > as much as possible even if we fail eventually) is specific to mbind()
> > then we could keep walk_page_range() as is and lock the VMAs inside
> > the loop that calls mbind_range() with a condition that ret is
> > positive. That would be the simplest solution IMHO. But if we expect
> > walk_page_range() to always apply requested page_walk_lock policy to
> > all VMAs even if some mm_walk_ops returns a positive error somewhere
> > in the middle of the walk then my fix would work for that. So, to me
> > the important question is how we want walk_page_range() to behave in
> > these conditions. I think we should answer that first and document
> > that. Then the fix will be easy.
>=20
> I looked at all the cases where we perform page walk while locking
> VMAs and mbind() seems to be the only one that would require
> walk_page_range() to lock all VMAs even for a failed walk.

Yes, I can well believe that.

> So, I suggest this fix instead and I can also document that if
> walk_page_range() fails it might not apply page_walk_lock policy to
> the VMAs.
>=20
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 42b5567e3773..cbc584e9b6ca 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1342,6 +1342,9 @@ static long do_mbind(unsigned long start,
> unsigned long len,
>          vma_iter_init(&vmi, mm, start);
>          prev =3D vma_prev(&vmi);
>          for_each_vma_range(vmi, vma, end) {
> +                /* If queue_pages_range failed then not all VMAs
> might be locked */
> +                if (ret)
> +                        vma_start_write(vma);
>                  err =3D mbind_range(&vmi, vma, &prev, start, end, new);
>                  if (err)
>                          break;
>=20
> If this looks good I'll post the patch. Matthew, Hugh, anyone else?

Yes, I do prefer this, to adding those pos ret mods into the generic
pagewalk.  The "if (ret)" above being just a minor optimization, that
I would probably not have bothered with (does it even save any atomics?)
- but I guess it helps as documentation.

I think it's quite likely that mbind() will be changed sooner or later
not to need this; but it's much the best to fix this vma locking issue
urgently as above, without depending on any mbind() behavioral discussions.

Thanks,
Hugh
---1463760895-168202884-1694832249=:16517--