Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Fri, 15 Sep 2023 11:43:46 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v10 12/15] cxl/pci: Disable root port interrupts in RCH
 mode
Message-ID: <6504a5e23cee9_d7cc8294b7@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230831170248.185078-1-terry.bowman@amd.com>
 <20230831170248.185078-5-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230831170248.185078-5-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4GDjtmvL48jLEg5AZuTG05zs6b0JIew+xxY7EbVHY4GDe6k2UTO70UKGdKY9?=
 =?us-ascii?Q?GM9zQCwcH3HkNpHWQhvmxI+yCto9HiUg1KQiVo6PKtMjXnN4WBAQcEg52rBs?=
 =?us-ascii?Q?/1gIg8rtUV5WV8NE/E4U4l8HRFhqtaLaCQd9BUrDx2SwQl6nJOAb1MQQWS8T?=
 =?us-ascii?Q?MTbMloaVRfl6EoeR4GOUw6Adqo9O2QoFooDd3w8MrJ0BHwhJ4iXfaVwi5tj3?=
 =?us-ascii?Q?hNBYvTMEWo2SnsP7PV9qXoxba8pBSnOsDi4Db5r9XNe5f0JIwUws7gfGrANK?=
 =?us-ascii?Q?jlVyOe/u+WfbT3h0DI+rJVzihOSiZDSjuiMKn5uNfV6mRIeoM/+frHyaYmwy?=
 =?us-ascii?Q?iSlyEMSlN+PRp18MdJQjccYtOKQt5LDPkh3sA65wAPy/JUATedDAuLwzCYZH?=
 =?us-ascii?Q?f1+8xvLHZTyuXNZhPsqxvUcHEPSXHJ+Pwwqk0k7T5mCEDUckHTK/2OpWYZgm?=
 =?us-ascii?Q?om/2gFTThCeKkss9FDYeCCDArJWjTteUwzaAcQQtlkwFAsp5U9B8Tx//tiRy?=
 =?us-ascii?Q?ZpCiKgxP1uXCXJC5Zo1Af8f7tKDB8+oJpvXTiyJcLgYzvZLsB+7Wy+/A2B0L?=
 =?us-ascii?Q?BnJ7salHdwrUVGBURsfQ2/r3F/VAAz0suc6Hg/z+IcML3mjy3uYD5vVdlkPZ?=
 =?us-ascii?Q?XXo2Il9ttGVhBE3M741GKsP15tEq0QydvG8Ejo2sUfjptxYY/a8vl/EcpnNf?=
 =?us-ascii?Q?WLFOLecXetIamLXBJHYVPvdyuOorrLLuZLFTmIBAqSAQdcxtMeVvwLn9gZOw?=
 =?us-ascii?Q?oo43/0ZkYWvUnl4m4i40fYQJIg7Zz3B83KMI9jr8N9ra1Az2xK9h3+RVmcYE?=
 =?us-ascii?Q?Wz3qGx9dTRTAQkxAhT6cvS36YpXeUZ+6JLk2wRncKgFRRaUdcUPo9f/drF/e?=
 =?us-ascii?Q?HwyxDVUIcdOxZKrWjqicpLHhceCDWYJakNud7Vh4R5aXxskFlT1l3HWMFQkU?=
 =?us-ascii?Q?NcuC7V98sv6+bS83H5FJgIs6mWYcvJuQhAkeJWOS2uKE2TD2yJFOchS0tZVt?=
 =?us-ascii?Q?bbyxHb9ir0knwDzeLhM0XeX7VzNbssF3pN9MvTahU07BEUy1m1GkuXE96ZbZ?=
 =?us-ascii?Q?qLDN4AIqM4R+D3SRiNnf1EIJn772BIObESAlc/OMFDrg5IW+3tAb5b3lx3CB?=
 =?us-ascii?Q?KTp8UXKjrH70gcYUEYhwWIHFIWpo5c7d7WRV9lZWmPHRKGX0IsHk38ect7rb?=
 =?us-ascii?Q?d5cOW1NXGWTY/bBhHTx5mlm9MbUsoQuAmsPG2K2Px+ASyWJ7vY/lgbhKWyxZ?=
 =?us-ascii?Q?ey2x8EeMvwAJSs2JGE8yeGf0GX+62Pg3jLzC4PG559Y9MmOPLsI0qLBKqjKR?=
 =?us-ascii?Q?HxgkpNUNPaD+Q7vF9+x9tbZrpVsXuZiM2At0LHtoux1P6TeRvF7nO65urVzt?=
 =?us-ascii?Q?+uxwz+OZXijwr2BNdtBYVB0V6g38fOSzevhNJoq5Nk4zvFZtV4baYuPHgse5?=
 =?us-ascii?Q?FMINbBaVaH7JHTxDkYBfmysDH+sLtW+zIQCqHbjdM6VnMFG8ZYluNMW7uGmQ?=
 =?us-ascii?Q?2TWzd5CalJ1EPQ22sxushohKhMsgi879qWjj+zKOIXtK0xrKRX+XNXyiox9f?=
 =?us-ascii?Q?4laQbUZZTbOUfSh8IqEyBiElyp1G7sVotD2BXVUtc7Na88Mv6zyibeYNNfNq?=
 =?us-ascii?Q?WA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e1047e5c-e1c7-4104-2f40-08dbb61bb357
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 18:43:49.4236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZkRwhMYWuSTsgty/2p/l49sb8tftDvRpTZTQLQ87rtwErZJmlkUev3Au1yOxMm3CXC9kB2QyTjS6e0aX/mqc64pexSfA9ECqGiSnMw5vrY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7757
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 11:57:07 -0700 (PDT)

Terry Bowman wrote:
> The RCH root port contains root command AER registers that should not be
> enabled.[1] Disable these to prevent root port interrupts.
> 
> [1] CXL 3.0 - 12.2.1.1 RCH Downstream Port-detected Errors
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
[..]
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 2a22a7ed4704..d195af72ed65 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -1042,6 +1042,9 @@ __devm_cxl_add_dport(struct cxl_port *port, struct device *dport_dev,
>  
>  	cxl_dport_map_regs(dport);
>  
> +	if (dport->rch)
> +		cxl_disable_rch_root_ints(dport);
> +

Similar to the comment about cxl_dport_map_regs() not being appropriate
in an enumeration routine, this also needs to move out of _add_dport. It
occurs to me that it should also be undone on driver detach just like
other device "enables".