Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <b948d505-3cfd-318d-20eb-9f60a2865d23@quicinc.com>
Date:   Fri, 15 Sep 2023 14:50:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs
Content-Language: en-US
To:     John Watts <contact@jookia.org>, <dri-devel@lists.freedesktop.org>
CC:     Neil Armstrong <neil.armstrong@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <devicetree@vger.kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
        Chris Morgan <macromorgan@hotmail.com>,
        <linux-kernel@vger.kernel.org>, Jagan Teki <jagan@edgeble.ai>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>
References: <20230911090206.3121440-1-contact@jookia.org>
 <20230911090206.3121440-3-contact@jookia.org>
From:   Jessica Zhang <quic_jesszhan@quicinc.com>
In-Reply-To: <20230911090206.3121440-3-contact@jookia.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/11/2023 2:02 AM, John Watts wrote:
> SPI drivers needs their own list of compatible device IDs in order
> for automatic module loading to work. Add those for this driver.

Hi John,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> 
> Signed-off-by: John Watts <contact@jookia.org>
> ---
>   drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 589431523ce7..90dea21f9856 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -465,6 +465,12 @@ static const struct nv3052c_panel_info ltk035c5444t_panel_info = {
>   	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
>   };
>   
> +static const struct spi_device_id nv3052c_ids[] = {
> +	{ "ltk035c5444t", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, nv3052c_ids);
> +
>   static const struct of_device_id nv3052c_of_match[] = {
>   	{ .compatible = "leadtek,ltk035c5444t", .data = &ltk035c5444t_panel_info },
>   	{ /* sentinel */ }
> @@ -476,6 +482,7 @@ static struct spi_driver nv3052c_driver = {
>   		.name = "nv3052c",
>   		.of_match_table = nv3052c_of_match,
>   	},
> +	.id_table = nv3052c_ids,
>   	.probe = nv3052c_probe,
>   	.remove = nv3052c_remove,
>   };
> -- 
> 2.42.0
>