Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <b3b54c2a-e567-a4fe-d022-eae04aa07354@wanadoo.fr>
Date:   Thu, 14 Sep 2023 20:31:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: RE: [PATCH 0/5] clk: imx: imx8: Fix some error handling paths
To:     "S.J. Wang" <shengjiu.wang@nxp.com>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>,
        Peng Fan <peng.fan@nxp.com>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>
Cc:     "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
References: <cover.1693126687.git.christophe.jaillet@wanadoo.fr>
 <AS1PR04MB92641B7B3944C2CF9F3DA3B3E3F7A@AS1PR04MB9264.eurprd04.prod.outlook.com>
Content-Language: fr
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <AS1PR04MB92641B7B3944C2CF9F3DA3B3E3F7A@AS1PR04MB9264.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 14/09/2023 à 12:22, S.J. Wang a écrit :
>>
>> This serie fix some error handling paths. It is split in different patches to ease
>> review because the issues are unrelated and the proposed fixes are maybe
>> wrong (I don't have the hardware to test anything)
>>
>> Patch 2 and 3 are more speculative than the 3 oher ones. Review with care.
>>
>>
>> Finally, I got some problem when generating the serie, and some patches
>> have been hand-modified afterwards.
>> They look good to me, but I hope have not screwed up things...
> 
> 
>  From the 3rd patch,  it can't be applied, maybe there is generating issue.

I will resend.

CJ

> 
> Best regards
> Wang Shengjiu
> 
>>
>> Christophe JAILLET (5):
>>    clk: imx: imx8: Fix an error handling path in
>>      clk_imx_acm_attach_pm_domains()
>>    clk: imx: imx8: Fix an error handling path if
>>      devm_clk_hw_register_mux_parent_data_table() fails
>>    clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe()
>>    clk: imx: imx8: Add a message in case of
>>      devm_clk_hw_register_mux_parent_data_table() error
>>    clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains()
>>
>>   drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------
>>   1 file changed, 15 insertions(+), 12 deletions(-)
>>
>> --
>> 2.34.1
> 
>