Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 15 Sep 2023 15:22:07 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        David Rientjes <rientjes@google.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Barry Song <song.bao.hua@hisilicon.com>,
        Michal Hocko <mhocko@suse.com>,
        Matthew Wilcox <willy@infradead.org>,
        Xiongchun Duan <duanxiongchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Usama Arif <usama.arif@bytedance.com>
Subject: Re: [PATCH v3 00/12] Batch hugetlb vmemmap modification operations
Message-ID: <20230915222207.GB426926@monkey>
References: <20230915221548.552084-1-mike.kravetz@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230915221548.552084-1-mike.kravetz@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XFQgPp6nKItBrJTbJU4erXtWyv0DdWXFkNt6XoB4SFieQmPRiB7yV+CRJrpc?=
 =?us-ascii?Q?1oNDkqYUppcjdFXZNhQYF7sFRnME50ucV/m9lr5pUzBARRvu9dYp6vlWHkCJ?=
 =?us-ascii?Q?gj9sIfH3SjaSrzG3wrJl3xNJQ9Wodh2bG8H8iSEmpgi+3GX5pw5uVb34Zjft?=
 =?us-ascii?Q?LuXSi+mCnKCOM7zpDD4afsbYZn+Q5vzT9dzWnqTlesNOSEu8J+xRpWFUp7Ek?=
 =?us-ascii?Q?7bJOiJC+beAwpr63UwDODqT1MIofYaLSvi85+D51GMwlRJwND2S6kR3SlLr0?=
 =?us-ascii?Q?5d+l5hW4oq+Ohq6MCld8qSKJY3liNOip2siMfegqlpZ3QCYDs5uNa8RepKaI?=
 =?us-ascii?Q?atC/6ROfjF8r2PNBk46Gn6EbI4jBJg+Vht5nxJEpzHiEmAmMd21Ka98KIDXd?=
 =?us-ascii?Q?0bOhB+Rmq6aSZYGYLaTvM8Ci8tKRdyOo72Z/v94iJDUrsAdfONDXcAv0hI13?=
 =?us-ascii?Q?C/4x9Ne9lQlLKPoxdfGF1Sroq/qs4MkLBN5kg27zbjF/iC6NWGX7Jt0wlzdF?=
 =?us-ascii?Q?uAJXxi7Jhc+QV1OUhPypxDZFdoeqMTFK6nlsEG7HtCuFy/7ncFDD2Zhjgq4x?=
 =?us-ascii?Q?gsvogOg4vVIP4txxsw6hjSJpNXCysG8vr0bglvLhDLJI4gvOoOKTaG7Q2Bt3?=
 =?us-ascii?Q?ljlJ828PF8BY0pSiB+O96M9ZQTqpCC+txAKb+lwwQ34/CywEFbfSHjefdxnx?=
 =?us-ascii?Q?r9XfKpl5ZtvD/H6glF2jp7xqfmJdBZb6G17+GsXOxzkwNbAriSg5Sajkop4U?=
 =?us-ascii?Q?3Fmhwg8hwnylMUevG71kfXeZQMohf9caWrVcGRRnaZbMNNiBVHoSMMMQbUYA?=
 =?us-ascii?Q?c9kD00o/Fao0URJOU6rLO/ErspRTombVgEv+mB4ZOgPrNs3reqMOV/eZatrI?=
 =?us-ascii?Q?HiQ5oqLzB8vp7k93UYCSzf7To+V5ys11UzhuubbLzxBfVvDBQkhz2MYIqo0b?=
 =?us-ascii?Q?c1qarKYjCziOE5nFDsQgpuFaPjSfnYhIPf6K5cJ3fvUBiyvm1ZB6i6B5x1On?=
 =?us-ascii?Q?uBHf7L7aeAMMCuAwb6tex4naN0bReJLmRtVW2FcmW4T9l0UnXI0Z2UESxOce?=
 =?us-ascii?Q?FprQ2BeoxDKMaDqSrY+Ih/GuRnpjbEc+JG8rNg4jsn3PAZXbihQMoCoh8gZI?=
 =?us-ascii?Q?NOKbVD+fojZNXNZSEvIapCu+vhZNZTVMdswXx3BTk2vVNuTZrLcEO6PVTK0q?=
 =?us-ascii?Q?MeqtghLoGH8j0hXSPTrmxa7YZLvNdaS4sEokSvmcoqRPcxJwUP121TApssgS?=
 =?us-ascii?Q?gc+YLdOFcrAB8s5Q/ZlhxQBJ1SfLW7skFzMQwyinWjWvYfQVljpt45tX3WqV?=
 =?us-ascii?Q?FR3rf2WVcgbJSQqwMPCdn2q7wjrHBxDI6AQPdPgqG12fJqeyAvUdYJHnlhkk?=
 =?us-ascii?Q?uwHEIM4vqOaYalIK6AcxgOD8CPE4S1QNmIwgS3yq9pjdWZtMdMbg2CR106pp?=
 =?us-ascii?Q?+aOle0c94JGfV1oD6hd1ySS1ZKksLdLktSTUfzbxJ+prftvDeEIPcg/6s/W5?=
 =?us-ascii?Q?AsBckX6V+VzKudcBDPNGzGgLjSjYUTzQ+Y0Rq9nf3NsWtVsvAsPe9N8Qa8Gn?=
 =?us-ascii?Q?h8hZmgQMeIQ2Myfk0sX2DtRlKoIn1OgJglPovzNdOooc0YnKgANQqbFb/G2q?=
 =?us-ascii?Q?kQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?9lN25z2vYriGpg9SIuUftm6Yg0GUrR51HIBU0sfP8G+1eqfTnV19MoDTNzpr?=
 =?us-ascii?Q?CoC6UF7LVykzWTG5oZLDGcVuaZGCrlQFpwVW7JMVRW0Orn9nJOJ0sbwQQ7Th?=
 =?us-ascii?Q?gUH7iPv6kwMTGmtZ0XjCO+ScFbriUra5kwm0S8r62y/wYiWvtobZSFqJZ2tZ?=
 =?us-ascii?Q?V/QxKmEDCoOscC8xkBCuLBwp3xJf2Sq4cUnS12hwRU/4+q1ZnqjKNHQLUrYO?=
 =?us-ascii?Q?f19NI7IoDowh+YtfUkAwyemSNsFtueQdbBMsP4EnFI4CZV+A6EuQjCJFPH4u?=
 =?us-ascii?Q?k7TIWmJUHkR2eIZjjFB1cxDvu44PMMss5UT6FM/tUnko6GmpRCiHyCKDrnCI?=
 =?us-ascii?Q?nK3yum70tOjVtRMJJcJSYOZw2goDJHNQf2ZhKTHDmE9cF3yK+lXeTVuylOfY?=
 =?us-ascii?Q?JHYxVqC6MdCUoej/tUTJFZ4Q3ijayHuVyZyJoxvzVu0Qb/1kMaWI/0vYUmmK?=
 =?us-ascii?Q?vCE8Uzf/7YcRunZK0AEH8XjsCfkKK0CKZvttzRZoYzspiFyXaJQHa+khOQ3e?=
 =?us-ascii?Q?0jd+zMk9U6xQDG+xouJX7MAuZLe8881psXlRlsQ2u0TnP73z8L6l4xRe/8wj?=
 =?us-ascii?Q?VKkVI0nbFsiojvPsqm1wUwb/VQ8eYv7pH+W2qmNcVtWed/Nx5sDzFXSUmvwy?=
 =?us-ascii?Q?jfYk8xgwCXzUX/yC4bgh3XlGqnzu6loGO0NP4dGLuVXUlnuQ2myBQ+p21Nov?=
 =?us-ascii?Q?eaJzeMPgIimTeuqsbnk3JNZcTvNEWqwpNpM1Q3DmfoczClA2Kfu8WvIRgqGh?=
 =?us-ascii?Q?CZ92Rq6xZmZ+d91x1S0w8S5p1VA6tpRHGako38JeBcqGCcYs/w/VtqkT4oWg?=
 =?us-ascii?Q?3/Te7lyiFyrw/63p994dZXXUINp5DVLQto2vjep1zmIVu+QHEOuvYZkyd978?=
 =?us-ascii?Q?66j9rfMLtiZhmT5sbEW95g694D5C6zuRWeew6DdlusFlrW8EM80cEDPNYhoR?=
 =?us-ascii?Q?78tZNYf/22/1A1BX8s5qVoHfZ5VqprNFNZpP/xhRw6OPjjAOFfIe9Fvmo/j7?=
 =?us-ascii?Q?SkcwzqTsdzxMnxROfpqu+8kw/QiUlbKUlFzCChA+96hg2xJoBxnusgYdR5QS?=
 =?us-ascii?Q?RmKp8WzpanFXFtsfnNNCPcW7fIqchpQPTLrWaCiVfFSyMN706iMiUZ5O/N81?=
 =?us-ascii?Q?HV7wgyqe+xkH?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c6ce474-9d5d-47d3-eef6-08dbb63a341d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 22:22:10.3381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uqYfMkgHojreD9Q4XNAPlsC2UrMtaSxTr+hK0yw8vColf8Hd1iMj/Y4ROnFqlYwuJvQR6ojKrhYi2Poqd8UqAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5801
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-15_20,2023-09-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=887 mlxscore=0 adultscore=0
 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000
 definitions=main-2309150201
X-Proofpoint-GUID: RGZlVui4P77FHejROOx7SY4rFLWoi7Jh
X-Proofpoint-ORIG-GUID: RGZlVui4P77FHejROOx7SY4rFLWoi7Jh
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 15 Sep 2023 15:25:30 -0700 (PDT)

On 09/15/23 15:15, Mike Kravetz wrote:
> The following series attempts to reduce amount of time spent in TLB flushing.
> The idea is to batch the vmemmap modification operations for multiple hugetlb
> pages.  Instead of doing one or two TLB flushes for each page, we do two TLB
> flushes for each batch of pages.  One flush after splitting pages mapped at
> the PMD level, and another after remapping vmemmap associated with all
> hugetlb pages.  Results of such batching are as follows:
> 
> Joao Martins (2):
>   hugetlb: batch PMD split for bulk vmemmap dedup
>   hugetlb: batch TLB flushes when freeing vmemmap
> 
> Johannes Weiner (1):
>   mm: page_alloc: remove pcppage migratetype caching fix
> 
> Matthew Wilcox (Oracle) (3):
>   hugetlb: Use a folio in free_hpage_workfn()
>   hugetlb: Remove a few calls to page_folio()
>   hugetlb: Convert remove_pool_huge_page() to
>     remove_pool_hugetlb_folio()
> 
> Mike Kravetz (6):
>   hugetlb: optimize update_and_free_pages_bulk to avoid lock cycles
>   hugetlb: restructure pool allocations
>   hugetlb: perform vmemmap optimization on a list of pages
>   hugetlb: perform vmemmap restoration on a list of pages
>   hugetlb: batch freeing of vmemmap pages
>   hugetlb: batch TLB flushes when restoring vmemmap
> 
>  mm/hugetlb.c         | 288 ++++++++++++++++++++++++++++++++-----------
>  mm/hugetlb_vmemmap.c | 255 ++++++++++++++++++++++++++++++++------
>  mm/hugetlb_vmemmap.h |  16 +++
>  mm/page_alloc.c      |   3 -
>  4 files changed, 452 insertions(+), 110 deletions(-)

Just realized that I should have based this on top of/taken into account
this series as well:
https://lore.kernel.org/linux-mm/20230913105401.519709-5-usama.arif@bytedance.com/

Sorry!
Changes should be minimal, but modifying the same code.
-- 
Mike Kravetz