Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230915024559.32806-1-haibo.li@mediatek.com> <20230915094004.113104-1-haibo.li@mediatek.com>
In-Reply-To: <20230915094004.113104-1-haibo.li@mediatek.com>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Fri, 15 Sep 2023 18:53:34 +0200
Message-ID: <CA+fCnZd0FkKNf1ZQxbXWvNM8NAt=ML+yXu5n4VgLOmhFf9TPfQ@mail.gmail.com>
Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal
To:     Haibo Li <haibo.li@mediatek.com>
Cc:     akpm@linux-foundation.org, angelogioacchino.delregno@collabora.com,
        dvyukov@google.com, glider@google.com, jannh@google.com,
        kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-mm@kvack.org, mark.rutland@arm.com, matthias.bgg@gmail.com,
        ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com,
        xiaoming.yu@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 15, 2023 at 11:40=E2=80=AFAM 'Haibo Li' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> I checked inline mode just now.kasan_non_canonical_hook can print
> something like below:
>
> Unable to handle kernel paging request at virtual address ffffffb80aaaaaa=
a
> KASAN: maybe wild-memory-access in range [0xffffff80aaaaaaa0-0xffffff80aa=
aaaaaf]
>
> When addr < KASAN_SHADOW_OFFSET meets,the original addr_has_metadata shou=
ld return false
> and trigger kasan_report in kasan_check_range.

It should, but I don't think it always does. But if it works for you,
let's leave it at that. I'll double check why it failed for me later.

Thanks!