Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <d8c1b001-1908-7e8f-70d3-30f01299f09d@intel.com>
Date:   Fri, 15 Sep 2023 11:07:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 07/10] platform/x86/intel/ifs: Metadata validation for
 start_chunk
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <20230913183348.1349409-8-jithu.joseph@intel.com>
 <3dc5207d-37b7-52fe-954-889d5456192d@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <3dc5207d-37b7-52fe-954-889d5456192d@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVFHRkpJREE5OW1JUVNkOHNlR0RJamJPOFFSZDJZNXlrbVpvQzRGUHJOZm1N?=
 =?utf-8?B?RzZHbDV1STN1UnJnR1I4UkJHS1EvdkYydVljdk5MNzF2WmlmelFTa3g0dWJl?=
 =?utf-8?B?S2hsSDQ1Lyt4Ly9rY1BJLysrc05iaGN2dGJMMTFsZ0JCYytSZFlaYXZoN0Yy?=
 =?utf-8?B?bjF6V2dVNFkvd0EweDhpUERZRlBDbGlDam9iZDFNbFlKVkJkT0dHYUxmQzl4?=
 =?utf-8?B?d3ZNS2xJQTc1Y3VxOFdIcHlmRkpSSUUzRnliVzF3Z2ZZVFdibWNwVk11RDFO?=
 =?utf-8?B?MVlWMEtyYXgrY3hWVnBqeDRkQWxHK3lCWndTR2I0cmlFd0o1NXh4ZGt5QXFp?=
 =?utf-8?B?a3lEWXArMWhWSjdRNnExZ3k4bUV2dURzTGdQSFU5c0I2S0RFdU5scm9VTllE?=
 =?utf-8?B?clBPZkhGNVZnY0E1Qjg0dWlvaFl0WDdqUkp0OXdvZE52V0xOTEdMVTJKQ0xN?=
 =?utf-8?B?Y0RhUnNkcmF5NmNTeXNQaTQ3UTV3YlA2NGlBYitDZ2NWYlQweTRFcDJ4OXZO?=
 =?utf-8?B?ZERxNEhndXcyZkhUUU92Qll1b05sK3FOVFY4ajFIUk9rV2cvbXdBaGQ4MmhW?=
 =?utf-8?B?SWtnb0hIMmtqbEZCZ0w1QVN4SVZZYldITGRUQXZLZlY3UmNudUFWNmFFVUd5?=
 =?utf-8?B?YkRPbFZRU3JIMlIySW9OZlBpWWJUbVVWYjMrSzRtZnlGRWlpQWt4dVl6bWtI?=
 =?utf-8?B?bnFyM3FvSHROeVRhMnUvN09Gdk1LZzc0OEhuTzN0UmpFM0dEYzdtMFVTcC9S?=
 =?utf-8?B?bWxON1hsUGpwYTdiSE5sdzV1aEVZVWhMcHhmMUZVREJhT1YycWUwUElwVlBP?=
 =?utf-8?B?WVR3LzllSmdYNFFxWDJBanVqdjJvV05LQ2V6ZEd3RDg5QzFRb0E4K2loQTh2?=
 =?utf-8?B?RGt5ZEs5SGpKOFNwSGQ0ajFHUXo2TXU2U0N1RUZ6NXRBQ0JpamJTa2YxUzFp?=
 =?utf-8?B?SWptMXJHRHprRDJKeExxOXU0eHQ4UGFKc29ES3JCVXovMmlBcFh1ZmdnK2py?=
 =?utf-8?B?TWRjRVl6ZGNFSmphZnJyRHFDL2FmU3NJMDU4ME9xL25IRmpFemZTSUU3aVF5?=
 =?utf-8?B?NDZaK1JyRlFOd2xtRis2bVE5MjhNaEZpL1lhT0JFY2ZwRkY4Mm43K2E2U29C?=
 =?utf-8?B?cmp0NzZHYTNYNVd5RmUyUlBQSStHQU1SaytVV1IvZFpYSGJqMUVncHJjb2F4?=
 =?utf-8?B?RU56Z0Rhb1V3VCtFa0gyTlRyUjVUTWJFZVFackx2MlJkRTA4RmMxVUNDQVhX?=
 =?utf-8?B?K1owcHNwZWFQVnBzSHJLdWdVYnJaaFBXQmd0VzJ1NUJLTDNNQ0VXdUgxN012?=
 =?utf-8?B?YlBrT2tVZSsreXNQUWxlU0g2Vzc5ckdDdXpBbXVUUTFiOWNSL2Fja01HZTZt?=
 =?utf-8?B?Z2l3VnhuMFdkc3BUb0E5YVc3aUI5dzZIVUo2QlNCL1VLVVJYajJMc0hrNDA1?=
 =?utf-8?B?UFFXMEwvWmlBcEZhdm9HK0piVTAyYlRXTDh5MTArQkIrM0pqTnVPN2Y4ZzlP?=
 =?utf-8?B?MjAvZmhDZGNQS0pMZW9mTUt3L1hCbGI5RzBEeTZRc3hqWHZvWmxxdkhyaTFG?=
 =?utf-8?B?aUIxZHZIM0tDZVJXbStwYitZenhoZzlZMk1RRmNMNkFEQlpHUC9MTFoxUU1u?=
 =?utf-8?B?Z0hreUFWeWkya3JzTzRlRzBEUzBVbEZ0LzVlOUlOYjlYOVZlMzJrYzY3Q0wz?=
 =?utf-8?B?UStOZUs0Q0w5Zk9wYWg3RHF6T09zU093L2pwanNTak91d002ZTNEdEVrVDRo?=
 =?utf-8?B?NlFsYTlwM2RvY3d3UTdlK1VFSUxWZC9HbkZyckFjMThLSG9KWmN3K1BBeFR4?=
 =?utf-8?B?MHVmbGtmMFRKUWxqOERsUUVjNlVXL1RNQXk0eXVNRFJMRU5VK1R3S3BxSm0w?=
 =?utf-8?B?dEI0MVcvNWxIYndoRG9ZM3ZnRnBWN2ExcDc0bU1DaERXU0c2V3lZbzNycDB0?=
 =?utf-8?B?K2FQODRqa0QvbHRzQUpxb01XbTBLUU9zd2I0MlZQa3pHUnpFSHMvY3ZuSWww?=
 =?utf-8?B?MkVaVGhlZ1BLRndMM21WS1RpaG9RRmxCUXI4Zzl5MnBBYk4xaGFUUnNFYzkz?=
 =?utf-8?B?a3RvRUhkdTdTamNVWnBjOWkyREgwTk1kK1FSbFhDcHN6OG5aajFxaVJ1Vmh5?=
 =?utf-8?B?RHJNbXNlRFdxTW9XZUlic1hWOHRleGkycmpjZXo5VjFxSjFqZ056ZEZtNm93?=
 =?utf-8?B?Y1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ce0e60-5bcb-4732-b0c8-08dbb616a633
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 18:07:39.8460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ymqRX6Of8lXX+EtAw8rNZCorywdL0oTn+gYWF3u1rvnQ0E4gSOKiDCFf86EL78koAlnWWU0n087EmrmLrPjPBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7968
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 11:09:46 -0700 (PDT)


On 9/15/2023 9:59 AM, Ilpo Järvinen wrote:
> On Wed, 13 Sep 2023, Jithu Joseph wrote:
> 
>> Add an additional check to validate IFS image metadata field
>> prior to loading the test image.
>>
>> If start_chunk is not a multiple of chunks_per_stride error out.
>>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
>> ---
>>  drivers/platform/x86/intel/ifs/load.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
>> index 778a3b89a24d..88630366a23c 100644
>> --- a/drivers/platform/x86/intel/ifs/load.c
>> +++ b/drivers/platform/x86/intel/ifs/load.c
>> @@ -292,6 +292,13 @@ static int validate_ifs_metadata(struct device *dev)
>>  		return ret;
>>  	}
>>  
>> +	if (ifs_meta->chunks_per_stride &&
>> +	    (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride)) {
> 
> While this is not incorrect, it would make the code easier to understand 
> if you add != 0.

Agree ... Will change

Jithu