Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp5054376rdb; Sat, 16 Sep 2023 00:33:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfy90bknlHKM4x6lbsMNAUukpoNdLbTxdTc8KYAVY92A9qm9WGwp5//HUnlFikF7WMI8fX X-Received: by 2002:a05:6a00:24ca:b0:690:463a:fa9d with SMTP id d10-20020a056a0024ca00b00690463afa9dmr4310810pfv.22.1694849609690; Sat, 16 Sep 2023 00:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694849609; cv=none; d=google.com; s=arc-20160816; b=jb4o3/zIIW79RqBA4y3LMDAjwKArRtr5GGfrU5WKcOv/yHzD347z9wVdmC8YQKNrV0 2rQfzxM/33da2b0T7VEEURVVMcmYuIvaEKw6Zkf0g2O/lradp5x1q6PM3x9QTE5VRKd+ CzKfrGEB+QjTjIJ7DzI4/UypykD/xtwZlrmFxK7P2+UfbB3alzSI4Vocrwd42tsSDJXs jEMno+IdtYJJWrk/GQSNioQLMZgwFwjVtMqpv79R5pv80kBSnxG6q0G7GIEnqba2kGWQ 25J1OT3lNVNg2OfZG2HyKtlnZbQIsZsTUFL/NZEQhtJwH5mRf2cei6Ux8z4iECdWQzJL S+JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=hiYpz5dXhxfUZTQa6zmGlfzr3xCWWU+duccDm51H4g4=; fh=d9wb67V2UAqstBRWx2XvsCKLBzBZ8CftsBm8e5GuT8E=; b=iqKzzT0r71UoSkYvyGeUPnbYGDl4nfZQigHny/NKv+xTED+HraUCBvuZsnRzDPcprZ nWweUCUPau24/0NAZQ75ZofrXnNywzSSBZLdXuBFflve9ZNKXue0KrKt2O2a3dOjBzv4 UYMu7BX/LxbdZ9FRVVuhR3C1oagx+rV68jjLNRCyYRjLE/zKcRIun9czBZTkN3jPQYqA otT8Y4u9hKAb4uY5svyP3x27+SN9pLKkaZ/ukFh7GXVeSWjrTRAqrgEq48GVPELJ4g7H bqipeRNr0i2JPkreyCMrIDK5owi4ga9HouxUgJdt2ak93oZ6q9SMgkdwxsONJNZzeY2H Vxmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FDwIB5wr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id h185-20020a636cc2000000b005775a435989si4416082pgc.671.2023.09.16.00.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 00:33:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FDwIB5wr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D0D6B827DFA5; Fri, 15 Sep 2023 05:37:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234970AbjIOMhM (ORCPT + 99 others); Fri, 15 Sep 2023 08:37:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234963AbjIOMhG (ORCPT ); Fri, 15 Sep 2023 08:37:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3438EA1 for ; Fri, 15 Sep 2023 05:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694781375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hiYpz5dXhxfUZTQa6zmGlfzr3xCWWU+duccDm51H4g4=; b=FDwIB5wrFFMG78uzY058HLLGgEQ67zOlytTnxrmo2foE9QHyfPeAopTetvqgSeRXtUPvdG 2pSguqdo2KxDqFsFpYp7OKXqGgBdZBJR36c8c8L6jbYpf3dXR0zd+WfAT+0w7OfIsY09Qe cWvdEp6MPEHzZsJa5Lx1cDPrBqTKLXg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-151-cqmwHRoKMT67BfSo_FuhuQ-1; Fri, 15 Sep 2023 08:36:10 -0400 X-MC-Unique: cqmwHRoKMT67BfSo_FuhuQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E060811E86; Fri, 15 Sep 2023 12:36:09 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB98F200BFE3; Fri, 15 Sep 2023 12:36:06 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <72e93605b28742c2a496ce4890ecaa80@AcuMS.aculab.com> References: <72e93605b28742c2a496ce4890ecaa80@AcuMS.aculab.com> <5017b9fa177f4deaa5d481a5d8914ab4@AcuMS.aculab.com> <20230914221526.3153402-1-dhowells@redhat.com> <20230914221526.3153402-10-dhowells@redhat.com> <3370515.1694772627@warthog.procyon.org.uk> <3449352.1694776980@warthog.procyon.org.uk> To: David Laight Cc: dhowells@redhat.com, Al Viro , Linus Torvalds , Jens Axboe , "Christoph Hellwig" , Christian Brauner , "Matthew Wilcox" , Brendan Higgins , David Gow , "linux-fsdevel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kunit-dev@googlegroups.com" , "linux-kernel@vger.kernel.org" , Andrew Morton , Christian Brauner , "David Hildenbrand" , John Hubbard Subject: Re: [RFC PATCH 9/9] iov_iter: Add benchmarking kunit tests for UBUF/IOVEC MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3585403.1694781366.1@warthog.procyon.org.uk> Date: Fri, 15 Sep 2023 13:36:06 +0100 Message-ID: <3585404.1694781366@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:37:14 -0700 (PDT) David Laight wrote: > I was thinking of import_iovec() - or whatever its current > name is. That doesn't actually access the buffer described by the iovec[]. > That really needs a single structure that contains the iov_iter > and the cache[] (which the caller pretty much always allocates > in the same place). cache[]? > Fiddling with that is ok until you find what io_uring does. > Then it all gets entirely horrid. That statement sounds like back-of-the-OLS-T-shirt material ;-) David