Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 12 Sep 2023 11:04:14 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     "Colin King (gmail)" <colin.i.king@gmail.com>
Cc:     Brian Foster <bfoster@redhat.com>, linux-bcachefs@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] bcachefs: Fix a handful of spelling mistakes in
 various messages
Message-ID: <20230912150414.p3fx5ryd77e2ju43@moria.home.lan>
References: <20230912082527.3913330-1-colin.i.king@gmail.com>
 <ZQBs2yEEupnoa2ZI@bfoster>
 <82d97565-ebb4-806c-70ba-c0fec16d51d5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <82d97565-ebb4-806c-70ba-c0fec16d51d5@gmail.com>
Precedence: bulk

On Tue, Sep 12, 2023 at 04:00:23PM +0100, Colin King (gmail) wrote:
> On 12/09/2023 14:51, Brian Foster wrote:
> > On Tue, Sep 12, 2023 at 09:25:27AM +0100, Colin Ian King wrote:
> > > There are several spelling mistakes in error messages. Fix these.
> > > 
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > ---
> > >   fs/bcachefs/alloc_background.c | 2 +-
> > >   fs/bcachefs/backpointers.c     | 2 +-
> > >   fs/bcachefs/btree_iter.c       | 2 +-
> > >   fs/bcachefs/fsck.c             | 2 +-
> > >   fs/bcachefs/recovery.c         | 2 +-
> > >   fs/bcachefs/snapshot.c         | 2 +-
> > >   fs/bcachefs/super-io.c         | 2 +-
> > >   7 files changed, 7 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
> > > index 540d94c0cceb..dd9f3cbace1e 100644
> > > --- a/fs/bcachefs/alloc_background.c
> > > +++ b/fs/bcachefs/alloc_background.c
> > > @@ -1247,7 +1247,7 @@ static noinline_for_stack int __bch2_check_discard_freespace_key(struct btree_tr
> > >   		return ret;
> > >   	if (fsck_err_on(!bch2_dev_bucket_exists(c, pos), c,
> > > -			"entry in %s btree for nonexistant dev:bucket %llu:%llu",
> > > +			"entry in %s btree for non-existent dev:bucket %llu:%llu",
> > 
> > "nonexistent" doesn't necessarily need to be hyphenated, right?
> 
> either way is valid, but some folk prefer the hyphenated version as it's
> apparently easier to scan.

Let's stick with the non hyphenated.