Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <c71c610d70727b94dfaa1bdd537235cde13db7c6.camel@xry111.site>
Subject: Re: [PATCH] LoongArch: Fix some build warnings with -W1 option
From:   Xi Ruoyao <xry111@xry111.site>
To:     bibo mao <maobibo@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Date:   Sat, 16 Sep 2023 18:07:58 +0800
In-Reply-To: <1918be3c-3560-bd3d-6518-c5e49319b1d6@loongson.cn>
References: <20230916092330.971630-1-maobibo@loongson.cn>
         <CAAhV-H50_aY8Sw0uPSs1VuNOtbaHF2-a5mZE2jnSC7QPUaWf=Q@mail.gmail.com>
         <1918be3c-3560-bd3d-6518-c5e49319b1d6@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2023-09-16 at 17:56 +0800, bibo mao wrote:
>=20
>=20
> =E5=9C=A8 2023/9/16 17:42, Huacai Chen =E5=86=99=E9=81=93:
> > Hi, Bibo,
> >=20
> > On Sat, Sep 16, 2023 at 5:23=E2=80=AFPM Bibo Mao <maobibo@loongson.cn> =
wrote:
> > >=20
> > > There are some building warnings when building LoongArch kernel
> > > with -W1 option as following, this patch fixes these building
> > > warnings.
> > Don't touch asm-offsets.c now, because it is being refactored by the co=
mmunity.
> Well, I will bypass this file and send the next version.
>=20
> Do you think that is it deserved to add -Wno-override-init option
> to remove compiling warning about file syscall.c? I am not sure about it.

What is a -W1 option?  At least GCC 13 does not recognize it.

And generally you cannot randomly add warning options building the
kernel and expect a clean result.  I don't think we should "fix"
breakages caused by custom warnings at all, unless the warning indicates
a real issue.


--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University