Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230828100421.19758-1-balamanikandan.gunasundar@microchip.com>
 <CACRpkdZKALgcN58Es_hKL1MyEKYaTezuRGyaMkkBYyfXhRpdKg@mail.gmail.com> <CAPDyKFrX1JNBio1tm4TbOwO4KSGP5ZHsLbJEXVv8qn-2Cq_KJg@mail.gmail.com>
In-Reply-To: <CAPDyKFrX1JNBio1tm4TbOwO4KSGP5ZHsLbJEXVv8qn-2Cq_KJg@mail.gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 14 Sep 2023 15:49:21 +0200
Message-ID: <CACRpkdaAqG86XwO0FcKdgNggthW7=v2L=GfhUbr-dhc99tXxyw@mail.gmail.com>
Subject: Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc:     Balamanikandan Gunasundar 
        <balamanikandan.gunasundar@microchip.com>,
        dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        ludovic.desroches@microchip.com, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, hari.prasathge@microchip.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 14, 2023 at 2:16=E2=80=AFPM Ulf Hansson <ulf.hansson@linaro.org=
> wrote:
> On Tue, 29 Aug 2023 at 09:18, Linus Walleij <linus.walleij@linaro.org> wr=
ote:
> >
> > On Mon, Aug 28, 2023 at 12:04=E2=80=AFPM Balamanikandan Gunasundar
> > <balamanikandan.gunasundar@microchip.com> wrote:
> >
> > > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) whi=
le
> > > checking if the device is compatible with atmel,hsmci. Instead handle=
 it in
> > > the if() condition. The compiler optimizes out the entire if() clause=
 if
> > > the first expression in the if() clause is constant false.
> > >
> > > Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@m=
icrochip.com>
> > > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Thanks for tidying this up Balamanikandan!
>
> Linus, we didn't manage to get this into v6.6. So, it's probably
> better if you pick up this via your tree for v6.7.

Oh it's actually Bartosz managing the GPIO tree these days.
(Which I am very happy about!)

The best is to resend the patch to the GPIO maintainers and
linux-gpio@vger.

Yours,
Linus Walleij