Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <1e2ecded-c1f6-462c-f66e-756a9d76c41d@intel.com>
Date:   Sat, 16 Sep 2023 02:03:03 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Peter Anvin <hpa@zytor.com>
References: <20230912065249.695681286@linutronix.de>
 <20230912065500.823314239@linutronix.de>
Content-Language: en-US
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
Subject: Re: [patch V3 01/30] x86/microcode/32: Move early loading after
 paging enable
In-Reply-To: <20230912065500.823314239@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjR3Q3VpbGI0WHRaVjVWSFk3VG9qUjJBTTFPZUY1NnZuN1VPNU4xTFdzY0sx?=
 =?utf-8?B?QU9JZlZYeEFxZHJEUUptM1FoZU53TUVCaC9RcGFWbm1DcDBpVUx4b3RrdXBW?=
 =?utf-8?B?MzJsV1RGR0tqbzhOTlpYSTM0Y3RaenU2SzdUUVdXSXk0OTlYMFdvUldPenlQ?=
 =?utf-8?B?blhKMWE4allRcCthaWhSWXJuVms5UmpPUjNFVlM4U0R4WTltREhzbGEvNm9k?=
 =?utf-8?B?MjBRcDdUNVhGSVJiQlg5RkxtQ0RJVUNubEU5NzdiQ2ZCOU1IY0t1c1hXeHMr?=
 =?utf-8?B?UEJtVGtqQkhQM09NcGkrQUwzbjRwYXpweVhyMERPQTZVMTBlYUFrWlBsRWll?=
 =?utf-8?B?RktJUGE0ekZheGtUTlhKL0JwZk44c1VtZkFuaUF2WWwwZlh4Nnl1ejE2MWty?=
 =?utf-8?B?OUdzaXlOWHNKeEhLUXRNNEN5Ny9oRVJBT0M2MTZyMmdwSk50NjlpMVFId3hN?=
 =?utf-8?B?M3l2L2x3cTNNR3lUek9MaEx0VmdBYWV4TjNJNUgwWFlqTldJZXBCZXhZeFp2?=
 =?utf-8?B?WmY5M2ZTV1gzdzQyQUUyRHZ0cUNTYk9MR1UxQ2xYcXZwZGR4clcva29vbFFp?=
 =?utf-8?B?WjFEQmdsMmhTV2M0dTViQjRQSVpNT0x6TmZGcTU5VXhGVWFuSUxvam9PSE85?=
 =?utf-8?B?ZGxjK1ROQlNLYUxFV1EvVEZFZVlmL3ZGVnJlejlET0xkVXdLS3IrL0pJTlZS?=
 =?utf-8?B?L0tEa3JuNmV6VXpKRnN4OFJvQXEzODlVUHVzVW1JUUYzRzlMM3l4UW1DdW9h?=
 =?utf-8?B?bkpDZGNiOURnMHdtYkJzTmRNM1NmTCs2YWN5MWxZTk4rTzd5N1lRNGQ3WE13?=
 =?utf-8?B?NzZablBJM0x5a2g5NE1RcTJBdEhBVXRsZExwYUhBVzdFaTc1ZWdtTFJDYmt0?=
 =?utf-8?B?czE0Uy94NEJ5dmJFOEdyTiszVjUwb0tQNFJQbFh3KzZGTEdCVnFXKzUwQXVt?=
 =?utf-8?B?NkxFV0Y3OWlsQm95NFh6alhxbng4REx2bEJodlFrQTdraVBQbW52YUdqa1pX?=
 =?utf-8?B?bm55dEl1NldWU1FXaUc0T0lKVGlRQU11MCttb0ZJSldtQWdCVW9IcDAxV3Jq?=
 =?utf-8?B?c0lpWkJtSWRsdklYbHZ1eGVtOHlSTkJGWnUzQlBiaTYwN3ZDNkd3VStNVzhn?=
 =?utf-8?B?Q1VlelAwWjRFYmxXS0owUlVBS0ZpN1MwTVgyMFM5SnhycWcvQkxKNjRaL2c2?=
 =?utf-8?B?b3gzajVaekEzSW1ZNGxYL0YwRnQ2Yk83cTRrMlp4bzVsaXpURWFWcWwwR2NQ?=
 =?utf-8?B?WDlmQlF2bTJ2NW84L1dzYWhGSjJvLytudHJLVisyeFlQWVV6cXRjRVp6VnBH?=
 =?utf-8?B?Z2xnMUEzYWYvNlJ5YzkzeDFXOEhuNUorN1hYRUtsWkhXODFzcXdXSXFwUHUv?=
 =?utf-8?B?dXRJb3BOa2RtN0FZOHZ0M01IdTBVTm5oVXExUHhXSEcyL3ZaejJ2VHBrOTRo?=
 =?utf-8?B?TGdiR0c0SXdUTXhRTFVKZWVSWmUya3h2Q2dmMmZNZm9veExnUTFQSGg5Z1FR?=
 =?utf-8?B?NG5HT1g3a0JDZ3A5WTM1QTl4clZTck9Sd3gyRkQ1OU0xbWxOdVpucy9STDBs?=
 =?utf-8?B?WDFrcVVMUGdWdjBDa0tXRHNxVTVmdzNQMFBaVjVpUUJUZU1TTVdKbk5jbnBK?=
 =?utf-8?B?QXc1dzQ2bFA1b3BNRDhsTUVoK0ZhVjFwNmFxWHowSTRFMzRpNzBxZVJxMGRy?=
 =?utf-8?B?d09LbVd1TWtNL0ZDKzFqeXcrdkRWOWFtM1VVQ2kxVllMLzQ5MlBGeDNwVk9K?=
 =?utf-8?B?OWpqYnhtcnVVS3FhSnp1UFlhZkl3UHNJeEd0YlhaQyt5OFprelRmY1FPQ0Qw?=
 =?utf-8?B?MTZpSk9mUHJIYWZ0SSs5U1dvOVh2NzlXOUZVT1RjSU4wdkJTeW11NFVjMFhr?=
 =?utf-8?B?amR6dWRpZ0ZqOW9HOGpwVW5zcS9jNGxZOGhTd0ZtWHpXMWZIMWxPREgwWmdq?=
 =?utf-8?B?NVVwRmJiQ3ZXb1BjWGNtMTlLSC9hZnQxd2JndVdVcWFRY3lYYTlpYzFFVXp6?=
 =?utf-8?B?TUoxOEJJckxJRFZoNzRGeFp6Qk5BMGdMOHcvWlZFaGZCNG52TWQ4a0RjTHI5?=
 =?utf-8?B?WmVSQzNWcjJXeVZFQmZsa2h5QVFQN3lXaS9uQkNPcVpMQXdkb0pTWitqeVoz?=
 =?utf-8?B?bDFVMWoxdHljYWl0OTFGY3M4Y3JOWnJoRS9MMXgrTTRVWFFlMGJOdEp2QmNa?=
 =?utf-8?B?R2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d99c8b84-a064-4ae9-2073-08dbb693bd67
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2023 09:03:06.0014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xzhZbGFG7jlrr+kRwxBJKiZ+ieoXJPM1kg+UpOWjCEq7rT6OwpLIg3ldLl2OPmJAm7LrVyudsSXYBzspcFbdjunOc0b5Aoj4ewpzfN6XMq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6890
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 16 Sep 2023 02:13:17 -0700 (PDT)

On 9/12/2023 12:57 AM, Thomas Gleixner wrote:
> 
>   static int apply_microcode_early(struct ucode_cpu_info *uci, bool early)
>   {
...
> -	if (early)
> -		print_ucode(old_rev, uci->cpu_sig.rev, mc->hdr.date);
> -	else
> -		print_ucode_info(old_rev, uci->cpu_sig.rev, mc->hdr.date);
> -

Nitpick:

with this change, there is no need for the second argument -- 'bool early'.

Thanks,
Chang