Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <9daacd2f-0dbf-dddc-9403-b802447896a2@ideasonboard.com>
Date:   Sat, 16 Sep 2023 14:50:24 +0200
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sebastian Reichel <sre@kernel.org>,
        dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AB436C46-413A-4469-BA07-F3ED1CECF02F@goldelico.com>
References: <20230412073954.20601-1-tony@atomide.com>
 <9daacd2f-0dbf-dddc-9403-b802447896a2@ideasonboard.com>
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Tony Lindgren <tony@atomide.com>
Precedence: bulk

Hi Tomi and Tony,

> Am 13.09.2023 um 13:59 schrieb Tomi Valkeinen =
<tomi.valkeinen@ideasonboard.com>:
>=20
> On 12/04/2023 10:39, Tony Lindgren wrote:
>> We may not have dsi->dsidev initialized during probe, and that can
>> lead into various dsi related warnings as omap_dsi_host_detach() gets
>> called with dsi->dsidev set to NULL.
>> The warnings can be "Fixed dependency cycle(s)" followed by a
>> WARNING: CPU: 0 PID: 787 at drivers/gpu/drm/omapdrm/dss/dsi.c:4414.
>> Let's fix the warnings by checking for a valid dsi->dsidev.
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>> ---
>>  drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c =
b/drivers/gpu/drm/omapdrm/dss/dsi.c
>> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
>> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
>> @@ -4411,7 +4411,7 @@ static int omap_dsi_host_detach(struct =
mipi_dsi_host *host,
>>  {
>>  	struct dsi_data *dsi =3D host_to_omap(host);
>>  -	if (WARN_ON(dsi->dsidev !=3D client))
>> +	if (dsi->dsidev && WARN_ON(dsi->dsidev !=3D client))
>>  		return -EINVAL;
>>    	cancel_delayed_work_sync(&dsi->dsi_disable_work);
>=20
> Shouldn't this rather be
>=20
> if (!dsi->dsidev)
> 	return 0;
>=20
> before the if (WARN_ON(dsi->dsidev !=3D client)) line?

Yes you are right. We have a different variant in our Pyra kernel:

What we currently have in our Pyra tree is: =
https://git.goldelico.com/?p=3Dletux-kernel.git;a=3Dcommitdiff;h=3D5bf7bd6=
4eec1eb924e794e8d6600919f0dae8c5a;hp=3D27a0cd6263194d1465e9c53293d35f8c8c9=
88f9d

        struct dsi_data *dsi =3D host_to_omap(host);
=20
-       if (WARN_ON(dsi->dsidev !=3D client))
+printk("%s\n", __func__);
+
+       if (!dsi->dsidev || WARN_ON(dsi->dsidev !=3D client))
                return -EINVAL;
=20
        cancel_delayed_work_sync(&dsi->dsi_disable_work);

>=20
> If dsi->dsidev is NULL, then attach hasn't been called, and we =
shouldn't do anything in the detach callback either.
>=20
> With your change we'll end up doing all the work in the detach =
callback, without ever doing their counterpart in the attach side.

If useful, I can post above mentioned patch (without printk).

BR and thanks,
Nikolaus