Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Sat, 16 Sep 2023 19:14:57 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Louis-Marie <rauline.lm@protonmail.com>,
        Linux USB <linux-usb@vger.kernel.org>,
        Linux Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hayes Wang <hayeswang@realtek.com>,
        Simon Horman <horms@kernel.org>,
        Antonio Napolitano <anton@polit.no>,
        Douglas Anderson <dianders@chromium.org>,
        Andrew Gaul <gaul@gaul.org>,
        =?utf-8?B?QmrDuHJu?= Mork <bjorn@mork.no>,
        Jean-Francois Le Fillatre <jflf_kernel@gmx.com>,
        Dennis Wassenberg <dennis.wassenberg@secunet.com>,
        Nicolas Dumazet <ndumazet@google.com>,
        Mark Pearson <mpearson-lenovo@squebb.ca>,
        Hannu Hartikainen <hannu@hrtk.in>,
        =?utf-8?Q?=C5=81ukasz?= Bartosik <lb@semihalf.com>
Subject: Re: Lenovo Hybrid Dock MAC passtrough patch
Message-ID: <ZQWcQTQahx-QEGDl@debian.me>
References: <guK8MKcjWbPsZ1LuRVYxFf7WfsWa025shmVj7iq289LHf59N6i6OlkD0N9KhICJzbMfFW2aXYbguZ1NtZNn6PlA_-JvF3k7uJtG89THdZ6w=@protonmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="OfTnmoJtB1ynC3bV"
Content-Disposition: inline
In-Reply-To: <guK8MKcjWbPsZ1LuRVYxFf7WfsWa025shmVj7iq289LHf59N6i6OlkD0N9KhICJzbMfFW2aXYbguZ1NtZNn6PlA_-JvF3k7uJtG89THdZ6w=@protonmail.com>
Precedence: bulk


--OfTnmoJtB1ynC3bV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 16, 2023 at 11:41:49AM +0000, Louis-Marie wrote:
> Hi,
> I would like to submit a patch for enabling mac passtrough for the Lenovo=
 Hybrid Dock.
> Tested with Fedora 6.4.12.
>=20
>=20
>=20
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.cindex 0c13d=
9950cd8..02e6404bf6ea 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -781,6 +781,7 @@ enum rtl8152_flags {
> =C2=A0#define DEVICE_ID_THINKPAD_USB_C_DONGLE =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A00x720c
> =C2=A0#define DEVICE_ID_THINKPAD_USB_C_DOCK_GEN2 =C2=A0 =C2=A0 0xa387
> =C2=A0#define DEVICE_ID_THINKPAD_USB_C_DOCK_GEN3 =C2=A0 =C2=A0 0x3062
> +#define DEVICE_ID_THINKPAD_HYBRID_USB_C_DOCK =C2=A0 =C2=A0 =C2=A0 0xa359
>=20
> =C2=A0struct tally_counter {
> =C2=A0 =C2=A0 __le64 =C2=A0tx_packets;
> @@ -9583,6 +9584,7 @@ static bool rtl8152_supports_lenovo_macpassthru(str=
uct usb_device *udev)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 case DEVICE_ID_THINKPAD_THUNDERBOLT3_DOCK_GEN=
2:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN2:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN3:
> + =C2=A0 =C2=A0 =C2=A0 case DEVICE_ID_THINKPAD_HYBRID_USB_C_DOCK:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 case DEVICE_ID_THINKPAD_USB_C_DONGLE:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return 1;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> @@ -9832,6 +9834,7 @@ static const struct usb_device_id rtl8152_table[] =
=3D {
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_LENOVO, =C2=A00x7214) },
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_LENOVO, =C2=A00x721e) },
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_LENOVO, =C2=A00xa387) },
> + =C2=A0 { USB_DEVICE(VENDOR_ID_LENOVO, =C2=A00xa359) },
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_LINKSYS, 0x0041) },
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_NVIDIA, =C2=A00x09ff) },
> =C2=A0 =C2=A0 { USB_DEVICE(VENDOR_ID_TPLINK, =C2=A00x0601) },
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 15e9bd180a1d..ad98c8ffbc69 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -470,6 +470,9 @@ static const struct usb_device_id usb_quirk_list[] =
=3D {
> =C2=A0 =C2=A0 /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) =
*/
> =C2=A0 =C2=A0 { USB_DEVICE(0x17ef, 0xa387), .driver_info =3D USB_QUIRK_NO=
_LPM },
>=20
> + =C2=A0 /* Lenovo ThinkPad Hydrid USB-C Dock */
> + =C2=A0 { USB_DEVICE(0x17ef, 0xa359), .driver_info =3D USB_QUIRK_NO_LPM =
},
> +
> =C2=A0 =C2=A0 /* BUILDWIN Photo Frame */
> =C2=A0 =C2=A0 { USB_DEVICE(0x1908, 0x1315), .driver_info =3D
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 USB_QUIRK_HONOR_BNUMINTERFACES =
},
>=20
> Signed-off-by: Louis-Marie Rauline <rauline.lm@protonmail.com>
>=20

Can you send above suggestion as formal patch instead? See
Documentation/process/submitting-patches.rst for how to properly submit
patches. And also, use git-send-email(1) when sending them so that patch
corruption (like tabs converting to spaces and line wrapping as in above
diff) doesn't occur.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--OfTnmoJtB1ynC3bV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZQWcPQAKCRD2uYlJVVFO
o/u6AP9cLVGluMyFIUFqW+ia7vUD0EjgYMoxOm7zjRV1fgMrGgEAmmMhnk3BbOTT
qXMf8rc686SvEWjuGWj1DsJAlmWAMgU=
=mQv0
-----END PGP SIGNATURE-----

--OfTnmoJtB1ynC3bV--