Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <93997981fb20fd83f42b83853e258ea28575cbe1.camel@gmail.com>
Subject: Re: [PATCH v4 02/42] ARM: ep93xx: add swlocked prototypes
From:   Alexander Sverdlin <alexander.sverdlin@gmail.com>
To:     nikita.shubin@maquefel.me,
        Linus Walleij <linus.walleij@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Damien Le Moal <dlemoal@kernel.org>,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 16 Sep 2023 17:38:57 +0200
In-Reply-To: <20230915-ep93xx-v4-2-a1d779dcec10@maquefel.me>
References: <20230915-ep93xx-v4-0-a1d779dcec10@maquefel.me>
         <20230915-ep93xx-v4-2-a1d779dcec10@maquefel.me>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

Hi Nikita!

On Fri, 2023-09-15 at 11:10 +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
>=20
> Add ep93xx_regmap_write and ep93xx_regmap_update_bits to make drivers
> compilable before actual implementation is added.

It should be possible to re-arrange the patch series so that real
implementation comes before the drivers using it.

We must assure that bisecting the kernel tree is possible, that
means no matter which (initial) part of your series is applied, there is no
regression allowed.

> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> =C2=A0include/linux/soc/cirrus/ep93xx.h | 6 ++++++
> =C2=A01 file changed, 6 insertions(+)
>=20
> diff --git a/include/linux/soc/cirrus/ep93xx.h b/include/linux/soc/cirrus=
/ep93xx.h
> index 56fbe2dc59b1..8b4b8221ed4c 100644
> --- a/include/linux/soc/cirrus/ep93xx.h
> +++ b/include/linux/soc/cirrus/ep93xx.h
> @@ -3,6 +3,7 @@
> =C2=A0#define _SOC_EP93XX_H
> =C2=A0
> =C2=A0struct platform_device;
> +struct regmap;
> =C2=A0
> =C2=A0#define EP93XX_CHIP_REV_D0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A03
> =C2=A0#define EP93XX_CHIP_REV_D1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A04
> @@ -34,4 +35,9 @@ static inline unsigned int ep93xx_chip_revision(void) {=
 return 0; }
> =C2=A0
> =C2=A0#endif
> =C2=A0
> +static inline void ep93xx_regmap_write(struct regmap *map, unsigned int =
reg, unsigned int val) {}
> +static inline void ep93xx_regmap_update_bits(struct regmap *map, unsigne=
d int reg,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int mask, unsigned int val)
> +{ }
> +
> =C2=A0#endif

--=20
Alexander Sverdlin.