Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <bdd2b752-21f9-4d1e-85e1-75a04479bc73@arinc9.com>
Date:   Sat, 16 Sep 2023 19:00:17 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 07/10] dt-bindings: net: enforce phylink
 bindings on certain ethernet controllers
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     Marcin Wojtas <mw@semihalf.com>, erkin.bozoglu@xeront.com,
        Jakub Kicinski <kuba@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Daniel Machon <daniel.machon@microchip.com>,
        =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Vladimir Oltean <olteanv@gmail.com>, netdev@vger.kernel.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-renesas-soc@vger.kernel.org,
        Jose Abreu <joabreu@synopsys.com>,
        Daniel Golle <daniel@makrotopia.org>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Sekhar Nori <nsekhar@ti.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Magnus Damm <magnus.damm@gmail.com>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Steen He gelund <steen.hegelund@microchip.com>,
        Rob Herring <robh+dt@kernel.org>, mithat.guner@xeront.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        devicetree@vger.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        John Crispin <john@phrozen.org>,
        George McCollister <george.mccollister@gmail.com>,
        Marek Vasut <marex@denx.de>,
        "David S. Miller" <davem@davemloft.net>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        DENG Qingfang <dqfext@gmail.com>, Felix Fietkau <nbd@nbd.name>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-mediatek@lists.infradead.org,
        Eric Dumazet <edumazet@google.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Alexandr e Torgue <alexandre.torgue@foss.st.com>,
        Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
        =?UTF-8?Q?Alvin_=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org
References: <20230916110902.234273-1-arinc.unal@arinc9.com>
 <20230916110902.234273-8-arinc.unal@arinc9.com>
 <169487630940.1637895.12001153052612710003.robh@kernel.org>
From:   =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <169487630940.1637895.12001153052612710003.robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 16.09.2023 17:58, Rob Herring wrote:
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000: 'anyOf' conditional failed, one must be fixed:
> 	'fixed-link' is a required property
> 	'pcs-handle' is a required property
> 	'tbi-handle' is a required property
> 	'phy-handle' is a required property
> 	'sfp' is a required property
> 	'managed' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml#

I will address the examples once I get a comment on my paragraph starting
with "RFC:" on the patch log.

Arınç