Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp5489866rdb; Sat, 16 Sep 2023 21:46:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQU3KxYKf4LVe0AO6i2waHlLR+sBNgTodYDmgc/vUjQQlsdfZsK9pwb0V1eGfP1S+JuEAD X-Received: by 2002:a17:90b:4a8c:b0:26d:d3a:5e48 with SMTP id lp12-20020a17090b4a8c00b0026d0d3a5e48mr12303160pjb.15.1694926000801; Sat, 16 Sep 2023 21:46:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694926000; cv=none; d=google.com; s=arc-20160816; b=x1k4IiTBXKGOcixnyV+gDpiE4vTeh3/svBzOAQlwYNaH4l7xscKrCnGfneLNjWtja8 9pfbqK8+6KCMQg0BaMK//itq9h/3GtwalivdjzuYK7PGH/HSfSOgEdF+/edock+o4p9H nVtla2fZjhrkXGcMOvmwR45J9SiLUq0oL1TTVdQmdX/Z4TBgvywKuTnBcEByB9/Ht1pB CYoSrQoPT6rIKjBxO65kV/SoU422YiYrBSjsbLDpjeUKKveqTKdHnPxUiDFJLcJOtF5E tFnYh33nKnVRJHcj0AOUByoP69MRJ8Ns7eGhvdSceUTAuhl8Y/cW7a2wVPJ//bpeonMT 61XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/kqZRW9gXRNvc1F996eE1e2wizoKvGhnn1qjNWI2aaY=; fh=osRuhd8ymWapU0IYvZgvh/1X4iBtq6oxDgJSeRwvD6Y=; b=e3P8OAQEL3OPYu5w3zyA/9z0DWB4t9kUccYGr1PT30gwvWpxmvlBtHfxtoEUkr9za0 Xe1gsxTbq7WhGjSuXgrKuyzWIjx086N7DL7pB7U8tR6P0CSxTzo0ZhsfBrS6MXkRIE9g DEnN6sV1KyBYL1RfdEwiZjjW2jo7zddi6qGjyitg04aQINcp7enzqOPTW24vX03HkcWm 19VqW8BDXW1Xr0PoaJRL25cf7Ukzavf554Lev03wedXuGlT9GLyO10a0VAtTgki4GPmP El05jvobV/lcAxWd/SB5qucSPSDEXQNeR5fQ69goCZ6Mwzqk8DaKDWb2H0Lv7PPkybtV ZrNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="aL/BfTCx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id ot4-20020a17090b3b4400b00274ea3cb558si668741pjb.80.2023.09.16.21.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 21:46:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="aL/BfTCx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4CD82836C024; Sat, 16 Sep 2023 05:43:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239232AbjIPMnC (ORCPT + 99 others); Sat, 16 Sep 2023 08:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239410AbjIPMm4 (ORCPT ); Sat, 16 Sep 2023 08:42:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E01E21B0 for ; Sat, 16 Sep 2023 05:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694868070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/kqZRW9gXRNvc1F996eE1e2wizoKvGhnn1qjNWI2aaY=; b=aL/BfTCxgCh4wJRUHxlcQDWRCOz6Zka2iugI0xYLFYr8ri+N3SPK9uLbpNzIwN+iuy8RVi 62mdC2BTPkjfexQCP9Bhm3XtoXfStUDTC4FYZ4rmKTV0tqOgF05r4NwGzCz1pRscLwbWcC RDgDkPXRNSEFv8o3PUmdbi1FPFlA4+Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-qxep9wqRMGimdZPrcCGAcw-1; Sat, 16 Sep 2023 08:41:06 -0400 X-MC-Unique: qxep9wqRMGimdZPrcCGAcw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E02785A5BA; Sat, 16 Sep 2023 12:41:06 +0000 (UTC) Received: from fedora (unknown [10.72.120.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC47F2026D68; Sat, 16 Sep 2023 12:41:00 +0000 (UTC) Date: Sat, 16 Sep 2023 20:40:55 +0800 From: Ming Lei To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, hch@lst.de, bvanassche@acm.org, kbusch@kernel.org, mst@redhat.com, damien.lemoal@opensource.wdc.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [PATCH v2 2/5] blk-mq: remove RQF_MQ_INFLIGHT Message-ID: References: <20230913151616.3164338-1-chengming.zhou@linux.dev> <20230913151616.3164338-3-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913151616.3164338-3-chengming.zhou@linux.dev> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 16 Sep 2023 05:43:41 -0700 (PDT) On Wed, Sep 13, 2023 at 03:16:13PM +0000, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > Since the previous patch change to only account active requests when > we really allocate the driver tag, the RQF_MQ_INFLIGHT can be removed > and no double account problem. > > 1. none elevator: flush request will use the first pending request's > driver tag, won't double account. > > 2. other elevator: flush request will be accounted when allocate driver > tag when issue, and will be unaccounted when it put the driver tag. > > Signed-off-by: Chengming Zhou Reviewed-by: Ming Lei Thanks, Ming