Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230914022204.1488383-1-irogers@google.com>
In-Reply-To: <20230914022204.1488383-1-irogers@google.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 16 Sep 2023 22:26:39 -0700
Message-ID: <CAM9d7cjNxuOVM95OoYEhuj0rePMt4tfQ0RGepW4R5WHvjX3v-g@mail.gmail.com>
Subject: Re: [PATCH v1] perf jevents metric: Fix type of strcmp_cpuid_str
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        John Garry <john.g.garry@oracle.com>,
        James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Sep 13, 2023 at 7:22 PM Ian Rogers <irogers@google.com> wrote:
>
> The parser wraps all strings as Events, so the input is an
> Event. Using a string would be bad as functions like Simplify are
> called on the arguments, which wouldn't be present on a string.
>
> Fixes: 9d5da30e4ae9 ("perf jevents: Add a new expression builtin
> strcmp_cpuid_str()")
>
> Signed-off-by: Ian Rogers <irogers@google.com>


Applied to perf-tools, thanks!

Namhyung