Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp5513819rdb; Sat, 16 Sep 2023 23:22:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESKORj+nunyr+lutaJDTGp8AWIurJ/PvcgSi8YllVuDnOmp0et6G+TQTt/3xaML+yNEtMC X-Received: by 2002:a17:902:d509:b0:1c2:c60:8387 with SMTP id b9-20020a170902d50900b001c20c608387mr6972876plg.0.1694931751734; Sat, 16 Sep 2023 23:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694931751; cv=none; d=google.com; s=arc-20160816; b=HgoyxlVdqAJnxR3bboyt9O7TB2njFlAeiIJX/G/L93+Qwg5Q3J3hiFW4RfH3fLoS1d +dhWVrbwp1ZGE6NK637S1ITFWJP1MtUIGtUfCcIkc2wvVk8cu+rlMUWSv3PqA4JbGc5X 9Pk9X/Xt6ZK0Uk0Zhn9WF62DyQprVGG0XTOTT7pn9QNiD2Vl3L0YSZtiJjDVfSCGqKav Qe5TLEbrq1/ytjddROIZ12JFFG9Fi4oXuljKtOHwSG8GfhiquMzQPV6Ii45stTC0NiQ6 aYloo3aUY+9ZfyAxq4rqGUsOEC+RPeFZe7ISGMxEceXSGDMBlrCcXvZo6xma48BEPm+B 9jCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l5b78G1Xe/uMbbRctSNTpM0K2JqIF7YMEFr4py30NLE=; fh=hF2hLj383m8f6orlN4eUtLijQrASCyn7z6mC3L5k2tU=; b=EGLK4ouCvnlYhX3H4DdNN1S/kimqoetJuZzwcwpRJsIMCBH4QxgMvJcHYhghcmGvxU F8ha6E7AlC3ri5R1+aJ5pkZWCllvhuZ2xk4Mhpf76PX2AA7UJTwJSUs+GTYFZmwj+n1E DVA5yYEM7vnUeFDfw0qhck0Kuc1qH1v9g91TPBeX0LrXK73622ixgewxmO2vkIwIE3Mr MX4B6cj2sS3YyhF25I3f38AkJeGcol0R6A3l0WTh7gKUCDeIKgqrClJkiNFtrXIIRt5q uQDH8Utlk5VIF3MCOhUYDknWfeQLO9mTYqdSV2GRDEXpW+hADjZFuzzqi1pUn60/Xp9D dd4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HWxGzrJS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ne9-20020a17090b374900b00274c03f8c24si2201561pjb.24.2023.09.16.23.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 23:22:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HWxGzrJS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 47EEE8328AD8; Fri, 15 Sep 2023 07:35:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235770AbjIOOfo (ORCPT + 99 others); Fri, 15 Sep 2023 10:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbjIOOfn (ORCPT ); Fri, 15 Sep 2023 10:35:43 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024C91AC; Fri, 15 Sep 2023 07:35:39 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9a58dbd5daeso297039766b.2; Fri, 15 Sep 2023 07:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694788537; x=1695393337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l5b78G1Xe/uMbbRctSNTpM0K2JqIF7YMEFr4py30NLE=; b=HWxGzrJStLkjqprmbesLMwZHt2KgWITMMlVYsCUYqLcjNZQXNSH5bvEYeeG0kWYX3L auMoieZp1kTmPj3NDPQjB0gwBHg7AL6z6V6vKXIKjcKW1b5Sk6Ij4u58Xlzi2+ffGCZy Ru6nt/Djge5YekPGxgB1p/dD269JhKysMbY6QiNcPVara850Mte7ejlufyLqi2CaAFwc csJkwvRd1GjKEzbjbUkV6K8b3Z+8sE3Q6O3vjWeZOCp7lY8rAedUhXqJOg7RlcYoI9/i 8OATMBT8q3VZPTu6UToSDC/vSylAuU/bFrDd1Yy6s1/V8LXkhrlY4M6daNNljuYUgJbW jUew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694788537; x=1695393337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l5b78G1Xe/uMbbRctSNTpM0K2JqIF7YMEFr4py30NLE=; b=YkVc1P1ghCa+boRDAm7cEtFip4LIs/nAGYlIM91DVHkzo8o+OCvh1P6AVv8OKNOQDV 9ukKzN+0UgUbhfIkIzwmk9VJwnP1emoC/omjzvJm2GWSapbt9ZiyqkrPR4A+bjxze+rW 9qbm65RPtjV7CQGOdJ/3gpsLTWbIe35UFrRHvLxcNSUn2hImx61YSHXrNK3bfDYetku+ sJ26UeXJ/imVn2IShShkZCOyMK+eci0kip6hxJlWbgtQSb2YE+UXEC1u4RSlJmG/FBnF nbuuFovb1hvsZe0zecSdKEcYSNd8pia0JBd90o4YlEts8fRUqtrOfxVtMGzyLOrihxyr Af/Q== X-Gm-Message-State: AOJu0YxPJAu1E0usK4uf2EP7zahmkyzd17m352r3XCzJ/tjKlsyTxAum Z8vR9lF8s1yg2FwYGhYDYLo= X-Received: by 2002:a17:906:150:b0:9a5:cab0:b061 with SMTP id 16-20020a170906015000b009a5cab0b061mr1613521ejh.51.1694788537224; Fri, 15 Sep 2023 07:35:37 -0700 (PDT) Received: from skbuf ([188.26.56.202]) by smtp.gmail.com with ESMTPSA id kg11-20020a17090776eb00b009a1a653770bsm2531814ejc.87.2023.09.15.07.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 07:35:36 -0700 (PDT) Date: Fri, 15 Sep 2023 17:35:34 +0300 From: Vladimir Oltean To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Woojung Huh , Arun Ramadoss , "Russell King (Oracle)" , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Petr Machata , Lukasz Majewski Subject: Re: [PATCH net-next 1/2] net: dsa: microchip: Move *_port_setup code to dsa_switch_ops::port_setup() Message-ID: <20230915143534.upiemn6ytjhmcot7@skbuf> References: <20230914131145.23336-1-o.rempel@pengutronix.de> <20230914131145.23336-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230914131145.23336-1-o.rempel@pengutronix.de> <20230914131145.23336-1-o.rempel@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 15 Sep 2023 07:35:42 -0700 (PDT) On Thu, Sep 14, 2023 at 03:11:44PM +0200, Oleksij Rempel wrote: > Right now, the *_port_setup code is in dsa_switch_ops::port_enable(), > which is not the best place for it. This patch moves it to a more > suitable place, dsa_switch_ops::port_setup(), to match the function's > purpose and name. > > This patch is a preparation for coming ACL support patch. > > Signed-off-by: Oleksij Rempel > --- Reviewed-by: Vladimir Oltean