Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Sun, 17 Sep 2023 20:47:20 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Stefan Moring <stefanmoring@gmail.com>
Cc:     broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronxi.de,
        festevam@gmail.com, linux-imx@nxmp.com, linux-psi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] spi: imx: take in account bits per word instead of
 assuming 8-bits
Message-ID: <20230917184720.wzigwjk4v5wakmz6@mercury.elektranox.org>
References: <20230917164037.29284-1-stefanmoring@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vvnncv4uod55cjfd"
Content-Disposition: inline
In-Reply-To: <20230917164037.29284-1-stefanmoring@gmail.com>
Precedence: bulk


--vvnncv4uod55cjfd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Sep 17, 2023 at 06:40:37PM +0200, Stefan Moring wrote:
> The IMX spi driver has a hardcoded 8, breaking the driver for word
> lengths other than 8.
>=20
> Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
> ---

patch subject is missing the 'spi: imx:' prefix. Otherwise:

Reported-by: Sebastian Reichel <sre@kernel.org>
Fixes: 15a6af94a277 ("spi: Increase imx51 ecspi burst length based on trans=
fer length")
Tested-by: Sebastian Reichel <sre@kernel.org>

(no need to Cc stable, since the regression is only in v6.6-rc1)

-- Sebastian

>  drivers/spi/spi-imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index a8a74c7cb79f..498e35c8db2c 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -662,7 +662,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx=
_data *spi_imx,
>  		if (spi_imx->count >=3D 512)
>  			ctrl |=3D 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
>  		else
> -			ctrl |=3D (spi_imx->count*8 - 1)
> +			ctrl |=3D (spi_imx->count * spi_imx->bits_per_word - 1)
>  				<< MX51_ECSPI_CTRL_BL_OFFSET;
>  	}
> =20
> --=20
> 2.42.0
>=20

--vvnncv4uod55cjfd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmUHSbUACgkQ2O7X88g7
+powOA//QZi68hCcG91zq7ECQd53AtdSj97EofoYYBRp1lQsfEkwzm4aHVzgvais
C4hXyiMZBLBstnH8+yTu/h5md2IwzZQVSftEyPyzrGIQwWu89DRZtUnWbo6fMtdI
Qq5T310rWgGETjjItrUgm727TJFbpSz/bIwSXYBLBaUIgcJnjITm2BwzyDDkpncl
qSA2Iww8oC/Lcowj9MJQ3JFu9YIpgdhaUdLARSzV3qGHJ235gh9FadH4S1sl2XXL
KHgYC9tJwuTz54vdqXSmOs3Qj/UF4JY0KAuKCZOHy43IDPtuuxIG87dU65+Fhd5M
nlorLWNa9r80VyilEJWkRu+GVOoIX17fDR0geYDU4AJfHYuIjYqSBHJ3AJU1Y384
irzfV4GePDnpAX7Noh1Q/Y8XqciD1P5I2JREyzWYvcyC+SvALU5gfJXU3Sy7pnXL
Yvvt9BqZSqrva3nbj3ModjoxRJqLdJIPGSeMdN+DaQ1AM2iVAQSiiX9bmbu4/JQ7
TmESFigxFC/D+1z7eS2qQmVPumMMFRfNPVBwo0f0hX48MIqU3I0KVpEnbI03ibKQ
z0eqhjg2jGtpQvZjdmcKUTsgUzZopUy/ramuPm5Dts0kbh+IVbil3ElEevzsCUQr
NR4Un8cDpWDdBTBRVYEjyEoK4v3nPMmq8JM26RK6EpBMpTSQeuw=
=2z3Y
-----END PGP SIGNATURE-----

--vvnncv4uod55cjfd--