Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp5855587rdb; Sun, 17 Sep 2023 16:04:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjaD0BS0G1eVYiopVDHmLZW1xH3K+HhLGOh8IwmqAjNOgUmZKL4yjC9kbKuGi5ypFUfysu X-Received: by 2002:a05:6a00:22d1:b0:68e:3772:4e40 with SMTP id f17-20020a056a0022d100b0068e37724e40mr7880847pfj.3.1694991877754; Sun, 17 Sep 2023 16:04:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694991877; cv=none; d=google.com; s=arc-20160816; b=FG38trl81SyTKGXrKbpsJVLnB0I02teO/dGoJxVTve7UZO880Pqfi7fqhNxK1AX0gI nd8+Hp5Qrzm/mEf7KUUel8YSrMjklCY05lKHqFRiC2za9VyHPhrQf7bfckG1iogQmWXd H6978WCqF5WNEvWuztTV0IP8ZWirfvMqyyx/+n7az4xKzAEPRO6qsFaO6Z4gQRLbI3QJ 4GVYXhk9ROfpIOTlQyvxY+XPxSxd+D0QHg64gnCGr5WIO/fGclyY+tQO5rzrINCq0KXJ AI7PEohaQzeUlW2c/+wq6HWgxNc2Oso6GKT9Bx4xpY4noIMR5Y79Qy8RMB6xlWcNkK7B 6ycw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=nRVx5i+8USC91YzqQPV0HVkgXBAWAOVqx9+jbhEu9bM=; fh=HI0kWu6UoutmSClvlVnNR3WzhY1ODmT162LzQTVE4t8=; b=KPdLUnvdhjRibgPMrGv1MVvoLZd79/ImUunvYoCFDTBnObJMh7g5MEk5T7ckUgX0TI DSn6co5XEocsFu8OpBIlhITK3aQ3cUPubi0XeQo6h8zVZ/0yE31JCflNsl0yaP2nPVJ/ 1qyFKLR/5ESOmEkL4881KOXHejFb4fLsGaHxTPGkEGzYT56IOUuClM1hpssBqg95pRyh sUF9gViEj9oD+fX5K5x5XtBWo+OfI2zsKv6Xlh0+hKBs/zebbR/UkMK84GYfQ4M58nv8 +opdz5f2tfxW9TZS9P1y/RQMCK9usPh2mFIjcN9tzYt+dk825/pQLLtw5A9Zs8O7LsKh c6Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ezJyhtT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z14-20020a65610e000000b0056951c32d80si6766910pgu.556.2023.09.17.16.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 16:04:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ezJyhtT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5C9B680781FD; Sat, 16 Sep 2023 13:03:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236073AbjIPUDB (ORCPT + 99 others); Sat, 16 Sep 2023 16:03:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbjIPUC2 (ORCPT ); Sat, 16 Sep 2023 16:02:28 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F15991AD for ; Sat, 16 Sep 2023 13:02:23 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6bf01bcb1aeso1875487a34.3 for ; Sat, 16 Sep 2023 13:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694894542; x=1695499342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nRVx5i+8USC91YzqQPV0HVkgXBAWAOVqx9+jbhEu9bM=; b=ezJyhtT6F40Pw19MmrlzduJK4G5vnk5txjT+utnqstmFxzqoe64C0LY/E1IVWR7FPX 0X0XJJcGTEoNchPYDMgcF3QspCAVe0F4UMBIEKUjuUY2InS2i7mfP9YN1uO/LQqMyAEg 4HnTga6D6YCL3IMTyO3SacTsNGtPx0yiEJaBoEZalO9fEzlfYl+w0TSqapBQ3zxAibxz xOLPXRmiToshS8akXuhmx+v0w0wbv33o7/EOEGAFwg1OvHGS5loIkuS6DIdM0P+140ta Xn5Et6ZylKOr2iW2Vh3Gu6n1mygXBGS4Zoz8iZABg2P6mKaufrTyyUknC5xS7MkkIuci zhNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694894542; x=1695499342; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nRVx5i+8USC91YzqQPV0HVkgXBAWAOVqx9+jbhEu9bM=; b=NNmGY23AwqhNC/AztJez0jJZG8dz+A+N6Jg0mElPUgmnSCRaMOGDgMxk6AS4byM4Mh FnuppP5SSCabO9Q2K5ZETm6gELYRw7Z4kwCi0QIseKtyUoVzzxYj27irQk7XlT4mCE5G Nz0jRx2ymm++Uznu0M9ZEz0f4/K2hsVCp+oV85Sx5jOaZjQG2Wa1L4ItR90/H4JhQfsp 2/nFV40f5PhV/qQdYFnsflN9AexnuozLtiINlYf2ISpOWUZ2BHWRX6AiCwQe9CA0FICI KDDYUeVkPrkMyeh5/qzqRkIe0m2/QhUNEDIS2IL1obFJzqDL7u9BvBMU/0J4uBULx693 rSuw== X-Gm-Message-State: AOJu0YyHdfHZ8JY1+wtgQm7VwAzHplDC0pBbXu4RFhx+68nz5ajtnRMk /BmqlNUkF+g6IZUIbW1wcScScPBXEmk= X-Received: by 2002:a05:6830:1d7:b0:6b8:7880:de9 with SMTP id r23-20020a05683001d700b006b878800de9mr5662922ota.19.1694894542607; Sat, 16 Sep 2023 13:02:22 -0700 (PDT) Received: from [192.168.1.224] (067-048-091-116.res.spectrum.com. [67.48.91.116]) by smtp.gmail.com with ESMTPSA id e15-20020a9d63cf000000b006b99f66444bsm2758972otl.71.2023.09.16.13.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Sep 2023 13:02:22 -0700 (PDT) Message-ID: <9770fe32-2b0c-639e-481a-dd8686e5eb7d@gmail.com> Date: Sat, 16 Sep 2023 15:02:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] driver core: shut down devices asynchronously Content-Language: en-US To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J . Wysocki" , Tanjore Suresh , Martin Belanger , Oliver O'Halloran , Daniel Wagner , Keith Busch , Lukas Wunner References: <20230913210516.3545-1-stuart.w.hayes@gmail.com> From: stuart hayes In-Reply-To: <20230913210516.3545-1-stuart.w.hayes@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 16 Sep 2023 13:03:29 -0700 (PDT) On 9/13/2023 4:05 PM, Stuart Hayes wrote: > Shut down devices asynchronously, ensuring that each device is shut down > before its parents. > > This can dramatically reduce system shutdown/reboot time on systems that > have devices that take many seconds to shut down, such as some NVMe drives. > On one system tested, the shutdown time went from 11 minutes without this > patch to 55 seconds with the patch. > > Signed-off-by: Stuart Hayes > --- > v1->v2: rewritten using kernel async code (suggested by Lukas Wunner) > --- > > drivers/base/base.h | 2 + > drivers/base/core.c | 135 ++++++++++++++++++++++++------------------ > include/linux/async.h | 6 ++ > 3 files changed, 87 insertions(+), 56 deletions(-) > Please disregard this patch... I realized this could be done in a simpler way. I'll send a V3 this week.