Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Chang S. Bae" <chang.seok.bae@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Borislav Petkov <bp@alien8.de>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Peter Anvin <hpa@zytor.com>
Subject: Re: [patch V3 01/30] x86/microcode/32: Move early loading after
 paging enable
In-Reply-To: <1e2ecded-c1f6-462c-f66e-756a9d76c41d@intel.com>
References: <20230912065249.695681286@linutronix.de>
 <20230912065500.823314239@linutronix.de>
 <1e2ecded-c1f6-462c-f66e-756a9d76c41d@intel.com>
Date:   Sun, 17 Sep 2023 21:17:33 +0200
Message-ID: <87jzsozk1e.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Sat, Sep 16 2023 at 02:03, Chang S. Bae wrote:
> On 9/12/2023 12:57 AM, Thomas Gleixner wrote:
>> 
>>   static int apply_microcode_early(struct ucode_cpu_info *uci, bool early)
>>   {
> ...
>> -	if (early)
>> -		print_ucode(old_rev, uci->cpu_sig.rev, mc->hdr.date);
>> -	else
>> -		print_ucode_info(old_rev, uci->cpu_sig.rev, mc->hdr.date);
>> -
>
> Nitpick:
>
> with this change, there is no need for the second argument -- 'bool early'.

Duh. Yes ...