Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp5873008rdb; Sun, 17 Sep 2023 17:04:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHk2Idx3XShlzUIbwhlGOu/LORALf417lVes0rqWUSyc8w9+f5xHkhKVQr7YuoMDIUpKurJ X-Received: by 2002:a17:90a:7483:b0:26f:7555:76 with SMTP id p3-20020a17090a748300b0026f75550076mr5348655pjk.11.1694995484831; Sun, 17 Sep 2023 17:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694995484; cv=none; d=google.com; s=arc-20160816; b=OMeaMiW3h1UBm+lMaHbZkO+43iGLMW1rnHnHxfVB3qEJ2XCUSFZ4LRz/ML0wDqjI4x 2LhBPgExjZB2xryBS2n7GnePeJo2mnnao26zzsCkCvHVnD+tyr8yZ2YYCEOOkjILuxW9 TfumMqP/O5laeY9vYiWngXkmNsAlJeTJsGC51DwY82t5BXhAcgm4pKhTyt3bIcK3dVWD F+ZRwni/O6d+0YZbydWDwFaOuS39eDidmlmtD7VEKH4644gbw9repYtBfNsN3n6E6mKE swcB5ifgpZiRP3XHN3d++tiHV8xI2Bqwn3qXu818gqmgzCBzpnXXgWarx8q4/i7DOuFy 3h+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:content-transfer-encoding :mime-version:subject:message-id:date:dkim-signature; bh=RUAZKy0i2RhNoGwCEKKaHZw8uNE3KiwddZ/JLiavyo0=; fh=q0TLCQSNPOFC/px7VHF1+KvjmoORcZngC8nAdCL3zfM=; b=Gj372Co0Sj3XG9SSbfj2hAkB3b/Gi57rZAfsk5i+DPYjqT6e9TwTYgF6SDnZ2+5BmF v28Dw7pO0kB4xKrwNPEK0OJHJQkCtNLAm6RElpEzVs34eswn8lRoYLZLSDKFF8YqnF+6 lV3P89/f5yOpUnO8v6UnZKt+a+6OxK/nTk/gJOwkbCA73+/W54XlW4npEpTdWx3SD33A byzsP+4n3xgJQK2tinLkE4w2p+5PQndcN++9bn9ipiocadjrra4aLAAzmSLGfHWQL/L+ kk5DtWKPca28zYT3VL0rrYHh+mUFuGjXB17RhOHn9ASfzE6JNTBkN5WJoOIjYi89Jp2/ 562g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=CiifftBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=rere.qmqm.pl Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id f18-20020a17090aa79200b0026d01e90c10si6964877pjq.65.2023.09.17.17.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 17:04:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=CiifftBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=rere.qmqm.pl Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 36E2781F3597; Sun, 17 Sep 2023 14:45:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239056AbjIQVfo (ORCPT + 99 others); Sun, 17 Sep 2023 17:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232790AbjIQVfX (ORCPT ); Sun, 17 Sep 2023 17:35:23 -0400 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E283131 for ; Sun, 17 Sep 2023 14:35:17 -0700 (PDT) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4Rph6T6vVHz62; Sun, 17 Sep 2023 23:35:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1694986514; bh=ZXKOuSqqrpe9gHfiZs/YFUPhkzcUcHYoH9le5k5Brg0=; h=Date:Subject:From:To:Cc:From; b=CiifftBrNTE4JluaAJIPMFmQhNAxHryOvCcqDE4PsE6qRjIOlGdOAdSz4ZDAwnhJJ p0s/wyI3WoFig9i/RlZw92+YrWiYyt/d9GvNbqCT/Cb9UrRPErbY6Qg3Wx/+2o8Ahs vwZlk6hbjCeoWKYJQ17ekjas6hwrCPZGjmCTuJUTAyd0xwJO1yJfNRtNThU/Trzdex /e2RMzj1T8ISUXTSWP62RCfsAkZMsjDdWEpoza1ZUlX45bnFzu6ZiN21tbsNBa2axq MccqfqwtLheu4owkZj14WtzOBsZbDCnUBK1TUB3hgQ+JzaDLre97uSlyTdXkX7qIm9 eNtJdnH9d7fMw== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Sun, 17 Sep 2023 23:35:13 +0200 Message-Id: Subject: [PATCH 0/2] regulator/core: A quick fix for struct device handling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Vladimir Zapolskiy , Zeng Heng X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 17 Sep 2023 14:45:04 -0700 (PDT) When fixing a memory leak in commit d3c731564e09 ("regulator: plug of_node leak in regulator_register()'s error path") it moved the device_initialize() call earlier, but did not move the dev->class initialization. The bug was spotted and fixed by reverting part of the commit (in commit 5f4b204b6b81 "regulator: core: fix kobject release warning and memory leak in regulator_register()") and introducing a different bug: now early error paths use kfree(dev) instead of put_device() for an already initialized struct device. This series fixes the original bug and reverts the problematic fix. Michał Mirosław (2): regulator/core: regulator_register: set device->class earlier Revert "regulator: core: fix kobject release warning and memory leak in regulator_register()" drivers/regulator/core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.39.2