Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20230814015700.70156-1-nathan@nathanrossi.com> <CAOMZO5A=q8Kb1pmM0nALerka11F_U3024YrPbRSboX0ay_PyOw@mail.gmail.com>
In-Reply-To: <CAOMZO5A=q8Kb1pmM0nALerka11F_U3024YrPbRSboX0ay_PyOw@mail.gmail.com>
From:   Nathan Rossi <nathan@nathanrossi.com>
Date:   Mon, 18 Sep 2023 15:46:55 +1000
Message-ID: <CA+aJhH2YD2tfEe6FsD4E8Dd1FfAjOLoBcghFA+HUYpCRC3Rw2Q@mail.gmail.com>
Subject: Re: [PATCH] soc: imx8m: Enable OCOTP clock for imx8mm before reading registers
To:     Fabio Estevam <festevam@gmail.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Nathan Rossi <nathan.rossi@digi.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 18 Sept 2023 at 13:26, Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Nathan,
>
> On Sun, Aug 13, 2023 at 10:57=E2=80=AFPM Nathan Rossi <nathan@nathanrossi=
.com> wrote:
> >
> > From: Nathan Rossi <nathan.rossi@digi.com>
> >
> > Commit 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the
> > register") added configuration to enable the OCOTP clock before
> > attempting to read from the associated registers.
> >
> > This same kexec issue is present with the imx8m SoCs that use the
> > imx8mm_soc_uid function (e.g. imx8mp). This requires the imx8mm_soc_uid
> > function to configure the OCOTP clock before accessing the associated
> > registers. This change implements the same clock enable functionality
> > that is present in the imx8mq_soc_revision function for the
> > imx8mm_soc_uid function.
> >
> > Signed-off-by: Nathan Rossi <nathan.rossi@digi.com>
>
> Thanks for the fix:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Should it also have a Fixes tag?

Potentially, though none of the previous commits (or their referenced
commits) attempted to resolve the issue for the imx8mm_soc_uid
function so I was not sure if a fixes would apply in this case or to
which commit? Though with that said this change would only need to be
applied to kernels that have applied the referenced commit, so that is
probably the ideal target for the fixes. I can send a v2 with the
Fixes included? Otherwise I have included the specific fixes commit
information below.

Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading
the register")

Thanks,
Nathan