Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <f3982556-dddc-4936-a628-a1fc8f05a750@gmail.com>
Date:   Sun, 17 Sep 2023 05:28:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] firmware: qcom: qseecom: Add missing AUXILIARY_BUS
 dependency
To:     Bjorn Andersson <quic_bjorande@quicinc.com>,
        Johan Hovold <johan+linaro@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Randy Dunlap <rdunlap@infradead.org>
References: <20230915-qseecom-auxiliary-fix-v1-1-38a46cfbfdb0@quicinc.com>
Content-Language: en-US
From:   Maximilian Luz <luzmaximilian@gmail.com>
In-Reply-To: <20230915-qseecom-auxiliary-fix-v1-1-38a46cfbfdb0@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/16/23 00:50, Bjorn Andersson wrote:
> The newly introduced QSEECOM driver fail to link if the system is built
> without CONFIG_AUXILIARY_BUS, make sure it is selected.
> 
> Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/r/9f156fa6-e5aa-4cb2-ab2b-b67fd8fc4840%40infradead.org
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Thanks for the quick fix!

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

> ---
>   drivers/firmware/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index a94202229a71..8c608be30060 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -229,6 +229,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
>   config QCOM_QSEECOM
>   	bool "Qualcomm QSEECOM interface driver"
>   	depends on QCOM_SCM=y
> +	select AUXILIARY_BUS
>   	help
>   	  Various Qualcomm SoCs have a Secure Execution Environment (SEE) running
>   	  in the Trust Zone. This module provides an interface to that via the
> 
> ---
> base-commit: dfa449a58323de195773cf928d99db4130702bf7
> change-id: 20230915-qseecom-auxiliary-fix-1574abe3bc98
> 
> Best regards,