Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <6e31d07f-133e-4abe-8225-45c822429bae@quicinc.com>
Date:   Mon, 18 Sep 2023 09:39:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl
To:     Rob Herring <robh@kernel.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <agross@kernel.org>,
        <konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
        <quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
        <quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
        <kernel@quicinc.com>
References: <20230915015808.18296-1-quic_tengfan@quicinc.com>
 <20230915015808.18296-2-quic_tengfan@quicinc.com>
 <6f40ee72-b763-c58d-44df-ea40d1309820@linaro.org>
 <35371580-8e5a-4f72-aec2-951268c296a3@quicinc.com>
 <20230915145947.GA3716246-robh@kernel.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <20230915145947.GA3716246-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 9/15/2023 10:59 PM, Rob Herring 写道:
> On Fri, Sep 15, 2023 at 03:30:16PM +0800, Tengfei Fan wrote:
>>
>>
>> 在 9/15/2023 3:04 PM, Krzysztof Kozlowski 写道:
>>> On 15/09/2023 03:58, Tengfei Fan wrote:
>>>> Add device tree binding Documentation details for Qualcomm SM4450
>>>> TLMM device.
>>>>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>
>>> ...
>>>
>>>> +
>>>> +patternProperties:
>>>> +  "-state$":
>>>> +    oneOf:
>>>> +      - $ref: "#/$defs/qcom-sm4450-tlmm-state"
>>>> +      - patternProperties:
>>>> +          "-pins$":
>>>> +            $ref: "#/$defs/qcom-sm4450-tlmm-state"
>>>> +        additionalProperties: false
>>>> +
>>>> +$defs:
>>>> +  qcom-sm4450-tlmm-state:
>>>> +    type: object
>>>> +    description:
>>>> +      Pinctrl node's client devices use subnodes for desired pin configuration.
>>>> +      Client device subnodes use below standard properties.
>>>> +    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
>>>> +    unevaluatedProperties: false
>>>> +
>>>> +    properties:
>>>> +      pins:
>>>> +        description:
>>>> +          List of gpio pins affected by the properties specified in this
>>>> +          subnode.
>>>> +        items:
>>>> +          oneOf:
>>>> +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9])$"
>>>
>>> This is still wrong. How many GPIOs do you have? Please open existing
>>> bindings for recent device (e.g. sm8550) and look how it is done there.
>> yes, will update to "^gpio([0-9]|[1-9][0-9]|1[0-2][0-5])$".
> 
> What about 106, 116, etc.?
> 
> Rob
understand more, need "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-5])$".

-- 
Thx and BRs,
Tengfei Fan